From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21863 invoked by alias); 3 Jun 2019 14:57:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21853 invoked by uid 89); 3 Jun 2019 14:57:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=logs, FORMAT, extremely X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 03 Jun 2019 14:57:06 +0000 Received: from [172.16.0.120] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 671F41E059; Mon, 3 Jun 2019 10:57:04 -0400 (EDT) Subject: Re: [RFC 1/2] Remove linux-waitpid.c debugging code To: Tom Tromey , gdb-patches@sourceware.org References: <20190530213046.20542-1-tom@tromey.com> <20190530213046.20542-2-tom@tromey.com> From: Simon Marchi Cc: Pedro Alves Message-ID: <691455f5-bc20-5260-b1ec-6bf57f17579f@simark.ca> Date: Mon, 03 Jun 2019 14:57:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190530213046.20542-2-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-06/txt/msg00025.txt.bz2 On 2019-05-30 5:30 p.m., Tom Tromey wrote: > The debugging code in linux-waitpid.c is one of the few remaining > spots that depends on the gdb/gdbserver difference. > > My first thought was that this code is not extremely useful, so this > patch removes this code. (However, if it is actually useful to > someone, we could make it work by introducing a new abstraction.) > > gdb/ChangeLog > 2019-05-30 Tom Tromey > > * nat/linux-waitpid.c: Don't include server.h. > (linux_debug): Remove. > (my_waitpid): Update. > --- > gdb/ChangeLog | 6 ++++++ > gdb/nat/linux-waitpid.c | 34 +--------------------------------- > 2 files changed, 7 insertions(+), 33 deletions(-) > > diff --git a/gdb/nat/linux-waitpid.c b/gdb/nat/linux-waitpid.c > index a7d11ab8d32..298032dff9a 100644 > --- a/gdb/nat/linux-waitpid.c > +++ b/gdb/nat/linux-waitpid.c > @@ -19,35 +19,10 @@ > > #include "common/common-defs.h" > > -#ifdef GDBSERVER > -/* FIXME: server.h is required for the definition of debug_threads > - which is used in the gdbserver-specific debug printing in > - linux_debug. This code should be made available to GDB also, > - but the lack of a suitable flag to enable it prevents this. */ > -#include "server.h" > -#endif > - > #include "linux-nat.h" > #include "linux-waitpid.h" > #include "common/gdb_wait.h" > > -/* Print debugging output based on the format string FORMAT and > - its parameters. */ > - > -static inline void ATTRIBUTE_PRINTF (1,2) > -linux_debug (const char *format, ...) > -{ > -#ifdef GDBSERVER > - if (debug_threads) > - { > - va_list args; > - va_start (args, format); > - debug_vprintf (format, args); > - va_end (args); > - } > -#endif > -} > - > /* Convert wait status STATUS to a string. Used for printing debug > messages only. */ > > @@ -79,20 +54,13 @@ status_to_str (int status) > int > my_waitpid (int pid, int *status, int flags) > { > - int ret, out_errno; > - > - linux_debug ("my_waitpid (%d, 0x%x)\n", pid, flags); > + int ret; > > do > { > ret = waitpid (pid, status, flags); > } > while (ret == -1 && errno == EINTR); > - out_errno = errno; > - > - linux_debug ("my_waitpid (%d, 0x%x): status(%x), %d\n", > - pid, flags, (ret > 0 && status != NULL) ? *status : -1, ret); > > - errno = out_errno; > return ret; > } > Pedro probably has a stronger opinion about this (as he is probably the one who has spent the most time staring at those logs), but I would think that this logging is useful when debugging interactions with the kernel. Simon