From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id OrdEGwpORmJ/KQAAWB0awg (envelope-from ) for ; Thu, 31 Mar 2022 20:57:46 -0400 Received: by simark.ca (Postfix, from userid 112) id 5ABBB1F163; Thu, 31 Mar 2022 20:57:46 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9365B1E150 for ; Thu, 31 Mar 2022 20:57:45 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F33AC3899430 for ; Fri, 1 Apr 2022 00:57:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F33AC3899430 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1648774665; bh=7MjR7/9Hh9Fu2RVl5dJ0/36OU2CzDcaEKOD/rVMwWNU=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=R9U7H9Kw/BCIw9Cf2TyFONeLBXg6jm1iNVlO/WXVJSEr1LgS+Q2CenESyh/xhxwxr GnEHysCt2K3l7ZqfUI+QvhZvBrTH/u1G7RirheuRJRW9eZPobSuKrVg9ILScA1Z6NL Wpy1tKR27l5YLh6YEarMPWyEb3oMdRJaZnJhUsi0= Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 63E753858C52 for ; Fri, 1 Apr 2022 00:57:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 63E753858C52 Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 2310EgnU027080; Fri, 1 Apr 2022 00:57:14 GMT Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com with ESMTP id 3f1s8cwe2c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 01 Apr 2022 00:57:14 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 2310oaen040116; Fri, 1 Apr 2022 00:57:14 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2105.outbound.protection.outlook.com [104.47.58.105]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3f1s963jmm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 01 Apr 2022 00:57:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RTc8tH9/5Wqa/9EjjmFwvUxYvn0VKz1mGeni1GVmROo44NaYihUW1Gt/4i3LsPuJ2Klq1pukAzdvP1B3RBqyOa5FoZ7sSmPTIfKIWuMVomcyT9hFJtOAz2rBGLtxqON0BQYFilSs7diAUSRsK2ZPXQAFT/VoWK7YVf9gbCfOLGCT5uMokm3g06AaJJpTEHQDd0qSksWQSEhyaRWNIT5hJnooCcHBDiZsw+k2s5gFbuitCtUXTv4c5PqYPdG7aQOuuhC3gwAQpo+RRxaS27Sbq8t5YrlG5m8MRcHSzF+g421AXEZznfJJs8AKLR1K781or33s6Dblr8ONEAkTFhuDuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7MjR7/9Hh9Fu2RVl5dJ0/36OU2CzDcaEKOD/rVMwWNU=; b=IHz5FBDagRQDlYhD7IzH3PKxtZSjL7wXgwSFxH0I3ieEO7N3iziMPcDjPyW/1fEid34FwqgfL1+6vrf3z+UOseBKSd5R5KWEprbrW+rzSHkwmeBnRPn9LW0bdcemhae9egAJPL/FSbEWfc5oeAwTyOuVAn0bl93c3v8hv9+qSYtuumcD+JC8tiut1/GiRcVxWusSyt3gzpPQ9yqOWFGa0vqh0rX5KQPDIXBbVSxa96BMv+cnjyExVocRtMwRHL0bFcQbVnHZP0ejnNO+RUDbENcDbtmttRPt9y3WFZ5bfTxsSksBEateCLZ7JfBdPTFfDiCtJ741IJvtq2HOfzxFyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from SJ0PR10MB4655.namprd10.prod.outlook.com (2603:10b6:a03:2df::23) by DM6PR10MB4299.namprd10.prod.outlook.com (2603:10b6:5:216::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.25; Fri, 1 Apr 2022 00:57:12 +0000 Received: from SJ0PR10MB4655.namprd10.prod.outlook.com ([fe80::8537:4552:d54f:e597]) by SJ0PR10MB4655.namprd10.prod.outlook.com ([fe80::8537:4552:d54f:e597%5]) with mapi id 15.20.5123.023; Fri, 1 Apr 2022 00:57:12 +0000 Message-ID: <68ff0d4f-2b63-fcad-6798-d6dbc458a914@oracle.com> Date: Thu, 31 Mar 2022 17:57:09 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 1/3] gdb/ctf: don't create a buildsym_compunit when building partial symbols Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20220331212019.2811099-1-simon.marchi@polymtl.ca> <90ec7aeb-6e9d-bd6c-236e-d74c2c6bf2a6@oracle.com> <6c5620d6-c076-33b0-d8d1-11701a53afd8@polymtl.ca> In-Reply-To: <6c5620d6-c076-33b0-d8d1-11701a53afd8@polymtl.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DM5PR19CA0002.namprd19.prod.outlook.com (2603:10b6:3:151::12) To SJ0PR10MB4655.namprd10.prod.outlook.com (2603:10b6:a03:2df::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 652abf0d-a046-4cb8-412c-08da137a8e3e X-MS-TrafficTypeDiagnostic: DM6PR10MB4299:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: w1mbTCXyYGoUXPJCuSuJ1W8haX1YEUNMh24Iu5ts1FnQeql1VHQ4ZfWwEmYhLw+FYfxvKcoteFKQk4qK7JuAgXPsNU1VdFRZ7G8aSZRVhYCsyRt+2nOCQPcy05CKOcWRgTJdfaBAg5ARH281sAc1U/fES5sN8xsvXodEdR8Hc/pqFcWjFVDPCDZmuB0ORUbCIBqRaZ8NvO8QJGQMhZiJ7xNQQMwyC8MmHZ4FHzZdH5pW+rWRRI7e086mLowZg5C283CI/Md0c0JJ8YbGj1W8yfboh1Vt+x7ExYaYCrpeszORKM0LqYFUagDvMrp61+s7p6fSKid10iXhnRO3QjZ4gRezLzrDaj4gNDtPlow7oaeI350C/qo4B+wyiIno0nkaTxJORJt98Z/rU/cZfRUocaU2z5/m5fwdOCFROLWLH0S6svQfieMKLGBvzqTTDW6c5LiKgRdWRLMqH9rvXvFL1hPU4JscS7Ce+uRkzNb6RDI/4Jh4EEVZsJ+iQpYhevPxdNLXMfxYfl3SB7hDD+tU7o4HxYP4VB6w8M5XdEQG4Fhpdp4qBNAhfJ1Af7nj+O4zvDcylhIcS6aDm7rhESSCpQ69dmgJNBZ2B4VqlywBzdVE8yptt0VAof7ELuvmz+a7C9OwUQ7jzGOmbDFSGFkSBU0JjNp0r9Gv1J0Nst1hQ8KjOt5VdxxaeN7r88iMrkY8MAo6eTmlwc20zzckXj0qYdYEc6YY9yntLDNmaqQB8YU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB4655.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6512007)(38100700002)(53546011)(52116002)(6506007)(36756003)(86362001)(5660300002)(31686004)(2616005)(6666004)(8936002)(8676002)(966005)(6486002)(66556008)(66476007)(31696002)(186003)(66946007)(316002)(508600001)(2906002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V3k1d2V1WVIwT2htRGpJVFJTNDBPcC9DdmhqdThrNnB0WEFEMDRDbllHZ3JS?= =?utf-8?B?a0lWREpIRUNodHdtMzZrM2hYbmpBQmpRSDFpMEZKeHhDWkJBRWtyM0trTjE2?= =?utf-8?B?UUVZVlYzNnZoU2MrMnE3OEVaaHBzNExaNEZSZE5uWUQ5ckhLUmhJTjZWQkZW?= =?utf-8?B?dXRwbFFCWFE4NHg3OUhhZ2VyQ1VwU2xjWXZYalQ2K25jTnQvNE9wcllwbzc0?= =?utf-8?B?NjBuQk01QUZ3cGZ5YlJudzFOWlc5d0RNSTFQajIzRnJ3STc3RFpHSTNQcDFI?= =?utf-8?B?VUh4dC82amw5c0lFM042SkRma1p5Rk1BaldFUDl2RzlFZzdJdndhQVNLOFBK?= =?utf-8?B?ZUc2UTdMcHFoYkNud0NDUGFyY3ZVL0M1VldRY2FjTGhscy81Ly8xQnJHQXZ3?= =?utf-8?B?dHQrT1l4ekZSRWxlWG5HMkYzNTB2UWVLWCtKdndaVE9vdTAySnRZNm1hN244?= =?utf-8?B?ME8zdURyRVhqRFNBTUdRTmJYSjJ3cDFPZlR5ekc4TW93WUJLTGhOUUUxdTZ0?= =?utf-8?B?YzJBU1hZWDNnZFhGUURJL2svLzdVK3FWNkRnK2JXd0U0ODM4NlVwWU9EUjEr?= =?utf-8?B?dXp1TTllZE5odldsR1RiMEY1MmVpQktGTlVza0xlRS9vbll6NURCNW5pR21V?= =?utf-8?B?WXJscUZDL2Z0ZkJMeVR4TmpKL2c1Y1liTnlzVVdPTVh3VEwzaGVqeDJaRmpJ?= =?utf-8?B?T2NSaHhmc1JOaDF4MFllRDVxbld2QkYyc0Y3YmYyRVRZYzltRWpRRGF3R0Zh?= =?utf-8?B?MVhmYjdhaVFNOXVXRjB0S2JGK2trak1oV21wekJGdVhhQUlnVEJnTG0zM1ov?= =?utf-8?B?ZEdhWlc5QmR0QUY1ZDJVM09YMlQ4OTNIRjlxQ3k5MGdRYWprZWFKQTFuQ3Ix?= =?utf-8?B?WjRndFRHTzFsUGsyZEtrc2VybW1zRzd6bzdwZk5DRHR2Q3R3K0wwU0lXYk9T?= =?utf-8?B?dkc5aGtJL2hRZmdJZXNqak9GM2E4MzErS2FRZ3JHdVgvVDRudkN2TDhXeE1Y?= =?utf-8?B?T2JlZG1TclVtSk1uUzkxU0REVlE2eHRpUTd1ZEt4MDl2eDBPaGdDV0tUaGhH?= =?utf-8?B?Tm8zUDNpNXVXeHY2RmZqRHIxL3JDMjF3V1FRSGJ1eUhKOTRSY1hDRjJqU2Yy?= =?utf-8?B?VmY4UlZnWVdldTJLL2VQNU5sKzEyVW80Tzk5ZVZoQnRlY1p1aGhqa3BzY3Iv?= =?utf-8?B?UFFud0RjZU9wOU1wZU1UT293MUYwOUI3VHZDU3ZrZHA2bzFTUE9SUXA1RVVP?= =?utf-8?B?eW9YamZ0OXlXek5ZZTRtUVJmdXJ6NWRxMGFhT29LV0ZEK0szY0t4WUJ1Qmhx?= =?utf-8?B?RnRrZUMyM3hqaG1IUjFXN3VnZGNYcVZrVHdxUDczQTk0Sm1oc1VDSnp3dTZO?= =?utf-8?B?KzVWL3dCM1FzbmI3RUpBNVBxdTNJZHIwRW00b2pZejV5eUl3MUlORVJtdUh1?= =?utf-8?B?NzZ0dUFvdG81eGMxeU00SkNNSG9OZHlyWjdoSUhUaklZa2ptSnU0YUhrWW5v?= =?utf-8?B?eTJIZ2QwZXRYQXNWOTlsNkx1Y3ZSTGc1cW4yQVYzd2VVZW5sZENHT2ljZXJr?= =?utf-8?B?Y1Zmd2FJRUhZUEhPdWVHNG13aFV5dnF4dHVYaStrMkJkOTJDeG1pcFdQcnFP?= =?utf-8?B?WWlCRUZuYUU2aUNwMEF2SVFCL0hJVk5pRzltUTQwUW1PZEhqRFlORWxsbUxi?= =?utf-8?B?YVh3NHZPRmpPOUtvMmx0L01zUEFDSHVnL0lHZUduTEFZOXRWL0x0NGN1RHVi?= =?utf-8?B?RXg3YklTUmd3MW5LcXZMd2VXeUFqNjlqVjE4VTVpZFhWbXpwSXdBYTlNOGpq?= =?utf-8?B?WEVWVTFpSm14NXVFR1l4S2EyQ1VjN1NrVFRpZk9tbllickhuRDVJQVF0STE4?= =?utf-8?B?Y3JMVTlVeWFQRjNERW5KMytOYWc1UWdrZCs3SG1mYWpYcGRKZm9oSG1vUmYz?= =?utf-8?B?alNtSnBxcWFVNGs3cXJQRXoxN1ZJNEhOdEc4V0ZqS1NBb3FPcWlVQVRpMmVI?= =?utf-8?B?Zlk2cVllbUlYckxtN2MvajFRZmJiK0hnSUdsVmQxVSs4Mit0SCtOOEpLaGdL?= =?utf-8?B?OTl4M0lQMys4cExyajFhVGlLMlJ5MFl1eVpZdWhzMnRtVDNYTHFJTjc5T0JZ?= =?utf-8?B?STRjeldkMXdRcTZVcTFwZG5RU2hmMkhVSUlJOFRnTXFNa01kMFhGSzllZzJF?= =?utf-8?B?ODUwMzNZcEN3ODVEQjZQRGN4TzkwWVNNTlRxWDdBOVVMOWJOM0JTZk9FR2p5?= =?utf-8?B?N1Y3MTBSOGN3RFJQd0FuT0dUeStaM0E5Z2Mydk1OcGptTm9YSytVS2locEdP?= =?utf-8?B?TXk1cGJkcWF5RjltRm56djVnY29EUmlHVXp0T1JSc0VWZHlkVkt0eG1wNHRJ?= =?utf-8?Q?5FNOPDaX6T3EqFAZfmxZiOE+w4mS5Ss9zGp5x?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 652abf0d-a046-4cb8-412c-08da137a8e3e X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4655.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2022 00:57:12.0978 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UWzRT1F+Rd7M5gnEurp5qUUcqn0f+KidN34i/A7HM/E3qrSa/dchn9WAO0gvk5D2D54JAmwnD3ptSf9a+a7fNw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4299 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425, 18.0.850 definitions=2022-03-31_06:2022-03-30, 2022-03-31 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999 phishscore=0 suspectscore=0 malwarescore=0 adultscore=0 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2204010002 X-Proofpoint-GUID: VXhCmTTyJfGElSnIwvmqP-7NN_RooWz8 X-Proofpoint-ORIG-GUID: VXhCmTTyJfGElSnIwvmqP-7NN_RooWz8 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Wei-min Pan via Gdb-patches Reply-To: Wei-min Pan Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Hi Simon, On 3/31/2022 5:14 PM, Simon Marchi wrote: >> A CTF archive contains conflicting type info and is treated as a CU. >> Since one can't switch scope among CUs in CTF, not reading archives >> might not be a problem. Please go ahead and make the change. It can >> be revisited when we come up a test case that shows otherwise. >> >> Thanks. > Hi Wei-Min, > > I'm not sure we are on the same page. I don't know much about CTF, so > let's make sure I understand things right. I am not sure how CTF debug > info is organized, and in particular what an "archive" is. If you can > explain this or give a reference, that would be useful. Here is the spec for CTF V3: http://www.esperi.org.uk/~oranix/ctf/ctf-spec.pdf which hopefully is helpful. > > I'll attach the output of "readelf --ctf=.ctf" for the file I am working > with. > > My understanding from the readelf output is that there is some debug > info (function, types, etc) described at the top-level. It doesn't seem > associated to a source file, and it seems to contain things that are > global. > > Then there is one "archive" for each compiled .c file, such as: > > CTF archive member: /home/simark/src/babeltrace/src/lib/current-thread.c: > > Each archive contains very little data, my guess is that it only > contains what is not already described at the top-level? Yes, that's my understanding too. > > Right now, in GDB, we create one CU (partial_symtab, and then > compunit_symtab after expansion) for the top-level, and the one CU for > each archive. My patch does not change that. It only removes a > "new buildsym_compunit" call that just seems useless / to do nothing. > > In other words, no user-visible changes are expected from this patch. OK. Thanks. > > Simon