From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118977 invoked by alias); 23 Aug 2019 22:24:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 118758 invoked by uid 89); 23 Aug 2019 22:24:05 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=pay X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 23 Aug 2019 22:24:04 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id x7NMNtoq029982 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 Aug 2019 18:24:00 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca x7NMNtoq029982 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1566599041; bh=UwaCXQOrAv35sbW+aiXNxifyJKvpsNHV3mLu3rKBeAw=; h=Subject:To:References:From:Date:In-Reply-To:From; b=JAmSWvTx1xBs7g78Z3yRCTaQHMbaIjl+Ru2+pqHtnNc8uplu0DFxV/nmm7POsfPc8 hgNKYj+I4m8tVnv/6HsFoN3pR1BPauCuT/5/bR8/EuwMDGhOJg9pmQtzV4eCKHKlz1 d2nVlgQAxCKTtNIVSr7iXVIDHyRqaUK/jP2FZdj0= Received: from [172.16.2.176] (wsip-184-188-36-2.sd.sd.cox.net [184.188.36.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 4CA671F327; Fri, 23 Aug 2019 18:23:55 -0400 (EDT) Subject: Re: [PATCH] Remove some variables in favor of using gdb::optional To: Pedro Alves , gdb-patches@sourceware.org References: <20190804201023.25628-1-simon.marchi@polymtl.ca> <9b1cdf6d-baae-3a5e-c2ea-fcdf124b7a1b@redhat.com> <65a23d93-bf2e-de1a-9052-f6d75832c2a1@polymtl.ca> <697c3e3d-4f75-4fb2-685b-a6fa59c7a2a3@polymtl.ca> <5d2e7548-1303-ba42-6d67-93ab37f6577d@redhat.com> <829ab63c-55b0-07bc-1517-0efe9aeecc95@polymtl.ca> <5ce0fc27-657c-a48a-8544-150a2a82b12f@redhat.com> <5994de6e-cb4b-2ec2-f6f9-1ee41da1827e@polymtl.ca> From: Simon Marchi Message-ID: <68b3420e-6eb2-ad6c-e263-6a51e6682a00@polymtl.ca> Date: Fri, 23 Aug 2019 22:24:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-08/txt/msg00560.txt.bz2 On 2019-08-23 4:23 p.m., Pedro Alves wrote: > Sorry for the delayed nit, but the first time I didn't really pay attention > the the enumerator names you were using. Reading back, I notice that you > used "dynamic". I don't know what that means here? Don't you mean > "external", as opposed to static? Like, wouldn't this be more to the point? > > enum { > symbol_linkage_unknown, > symbol_linkage_static, > symbol_linkage_extern, > } symbol_linkage = symbol_linkage_unknown; Oh yes of course, I was confused static/extern with static/dynamic. I'll use that, thanks. Simon