From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id FZ4jJZxE72lBPT4AWB0awg (envelope-from ) for ; Mon, 27 Apr 2026 07:12:28 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=vrany.io header.i=@vrany.io header.a=rsa-sha256 header.s=protonmail3 header.b=DrTEkJ3P; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8275E1E067; Mon, 27 Apr 2026 07:12:28 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7FB811E067 for ; Mon, 27 Apr 2026 07:12:25 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id A0C2D4BA2E09 for ; Mon, 27 Apr 2026 11:12:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A0C2D4BA2E09 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=vrany.io header.i=@vrany.io header.a=rsa-sha256 header.s=protonmail3 header.b=DrTEkJ3P Received: from mail-106100.protonmail.ch (mail-106100.protonmail.ch [79.135.106.100]) by sourceware.org (Postfix) with ESMTPS id 88F134BA799F for ; Mon, 27 Apr 2026 11:12:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 88F134BA799F Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=vrany.io Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=vrany.io ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 88F134BA799F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=79.135.106.100 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777288321; cv=none; b=Z1NvDeUzcP3jh/LLPdT7z1w7l6wrs1IoTkRkOuCAGdWdrdimPzltPf8rxpyZOQuN008DXq7hrBIwACoGGW3cpWe8WTN1AKAzj1+COXoC9bf1X0FfvH6tE/yDFiVDs57FOdC86xsGmMScswdMIdxwjdywbBJtCPIl8Qr6pHHyBdg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777288321; c=relaxed/simple; bh=ge0gX4MF3ZN3E70kONrAXh7FmhWZU2/WXZCDYGJEjn4=; h=DKIM-Signature:Date:To:From:Subject:Message-ID:MIME-Version; b=ck+PTXnUVwAmFql82JfWgtV/n8f4+R8j9/ttbR0tFb/jl4sF5tlZMFi2LzL/eNblVrMbhoWRAP8BmJRnIrNzUr/ckrfSa7bgxQeD+2CoybE5Z68+2AoUuGnHpM8xJyiivodZSWME3UbiHXUi0YnvEd6oieKPNCy6PBSIY3QmRdo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 88F134BA799F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrany.io; s=protonmail3; t=1777288316; x=1777547516; bh=ge0gX4MF3ZN3E70kONrAXh7FmhWZU2/WXZCDYGJEjn4=; h=Date:To:From:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=DrTEkJ3PNJ++fqsvQ7FbmEVoF3Ckizo66eAxuqcsfUrqCS9PZQhcUZOknV9VvDxRW S9707XPGg4Hk6K0z4LVCcPp7NvcQjJNXJ4DG4HBH1cnqQZlQMqEPsDHi7g8fENhylb D/wbqyO6U2pSBfHBbQcjXWCEp5YLOsXRyICwLt4DLW3j7kqGelxMMp6F95hjU7EoH2 be4FNkY5cDSBeMjP36UKNxx1hRPntisLjK8fdcoW37LNXvjBRhh/L4JJBEP90w+Q/U 3bDLAUHfJ2lF3Fzs+ZWiZ0n5ephKiuKshPwQxzd7WjMkPnYkPGUHxw1EPW8s+JjmzH iPSfj0IeY3igw== Date: Mon, 27 Apr 2026 11:11:49 +0000 To: Tom de Vries , gdb-patches@sourceware.org From: Jan Vrany Subject: Re: [PATCH 4/7] [gdb] Add block::superblocks Message-ID: <68a8fb3fdf0ed5a00262f8d37e31f879b0da214b.camel@vrany.io> In-Reply-To: <20260423063530.1074175-5-tdevries@suse.de> References: <20260423063530.1074175-1-tdevries@suse.de> <20260423063530.1074175-5-tdevries@suse.de> Feedback-ID: 40767693:user:proton X-Pm-Message-ID: 2a28932a6cebb897845d0c838211122e906d8e3f MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > Add a function block::superblocks that can be used to transform: Hi, a nit: shouldn't the commit summary and message say=C2=A0super_blocks (with= underscore)? On Thu, 2026-04-23 at 08:35 +0200, Tom de Vries wrote: > Add a function block::superblocks that can be used to transform: > ... > =C2=A0 while (block !=3D NULL) > =C2=A0=C2=A0=C2=A0 { > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ... > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 block =3D block->superblock (); > =C2=A0=C2=A0=C2=A0 } > ... > into: > ... > =C2=A0 for (auto b : block::super_blocks (block)) > =C2=A0=C2=A0=C2=A0 { > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ... > =C2=A0=C2=A0=C2=A0 } > ... >=20 > I'm not sure about the name.=C2=A0 It might suggest that block is not inc= luded in > the iteration, but in fact it is. > I considered block::block_and_supers () instead, but it seems a bit awkwa= rd. I'd personally prefer block::block_and_supers over block::super_blocks. It'= s bit awkward, but better awkward than misleading. > --- > =C2=A0gdb/block.h | 36 ++++++++++++++++++++++++++++++++++++ > =C2=A01 file changed, 36 insertions(+) >=20 > diff --git a/gdb/block.h b/gdb/block.h > index 091120ae2b8..4a1db79d7ed 100644 > --- a/gdb/block.h > +++ b/gdb/block.h > @@ -108,6 +108,27 @@ struct blockranges >=20 > =C2=A0struct block : public allocate_on_obstack > =C2=A0{ > +=C2=A0 /* Variant of next_iterator using the superblock field instead of= next.=C2=A0 */ > +=C2=A0 struct superblock_iterator : base_next_iterator > +=C2=A0 { > +=C2=A0=C2=A0=C2=A0 typedef superblock_iterator self_type; > + > +=C2=A0=C2=A0=C2=A0 explicit superblock_iterator (value_type item) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 : base_next_iterator (item) > +=C2=A0=C2=A0=C2=A0 { > +=C2=A0=C2=A0=C2=A0 } > + > +=C2=A0=C2=A0=C2=A0 superblock_iterator () =3D default; > + > +=C2=A0=C2=A0=C2=A0 self_type &operator++ () > +=C2=A0=C2=A0=C2=A0 { > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 this->m_item =3D this->m_item->superblock= (); > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return *this; > +=C2=A0=C2=A0=C2=A0 } > +=C2=A0 }; > + > +=C2=A0 using superblock_range =3D iterator_range; > + > =C2=A0=C2=A0 /* Return this block's start address.=C2=A0 */ > =C2=A0=C2=A0 CORE_ADDR start () const > =C2=A0=C2=A0 { return m_start; } > @@ -306,6 +327,21 @@ struct block : public allocate_on_obstack >=20 > =C2=A0=C2=A0 struct dynamic_prop *static_link () const; >=20 >=20 I think comment would be useful here, especially as "super_blocks" returns this block AND all its superblocks.=20 > +=C2=A0 superblock_range super_blocks () const > +=C2=A0 { > +=C2=A0=C2=A0=C2=A0 superblock_range::iterator begin (this); > + > +=C2=A0=C2=A0=C2=A0 return superblock_range (std::move (begin)); > +=C2=A0 } > + > +=C2=A0 static superblock_range super_blocks (const block *b) > +=C2=A0 { > +=C2=A0=C2=A0=C2=A0 if (b =3D=3D nullptr) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return superblock_range (); > + > +=C2=A0=C2=A0=C2=A0 return b->super_blocks (); > +=C2=A0 } > + Thanks!=20 Jan