From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24877 invoked by alias); 13 Jun 2017 11:06:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24667 invoked by uid 89); 13 Jun 2017 11:06:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Jun 2017 11:06:49 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 33608693E7; Tue, 13 Jun 2017 11:06:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 33608693E7 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 33608693E7 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id F2B6677BE7; Tue, 13 Jun 2017 11:06:49 +0000 (UTC) Subject: Re: [PATCH 0/5] Remove a few hurdles of compiling with clang To: Simon Marchi , Yao Qi , Eli Zaretskii References: <1497124689-11842-1-git-send-email-simon.marchi@ericsson.com> <83tw3n5jyk.fsf@gnu.org> <86tw3labb0.fsf@gmail.com> <83a85d5l4n.fsf@gnu.org> <93eb64489ac9d53665a144ddf5a966d5@polymtl.ca> <83wp8h40lo.fsf@gnu.org> <8660g0dzau.fsf@gmail.com> Cc: Simon Marchi , gdb-patches@sourceware.org From: Pedro Alves Message-ID: <689b4906-c752-d002-83d3-f03692a161d6@redhat.com> Date: Tue, 13 Jun 2017 11:06:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00367.txt.bz2 On 06/13/2017 11:23 AM, Simon Marchi wrote: > I have a concrete example that is currently in the pipeline. I hit this warning/error: > > /home/emaisin/src/binutils-gdb/gdb/nat/x86-dregs.c:209:7: error: variable 'i' is incremented both in the loop header and in the loop body [-Werror,-Wfor-loop-analysis] > i++; > ^ > /home/emaisin/src/binutils-gdb/gdb/nat/x86-dregs.c:199:32: note: incremented here > ALL_DEBUG_ADDRESS_REGISTERS (i) > ^ > > which would require changing this code: > > ALL_DEBUG_ADDRESS_REGISTERS (i) > { > ... > i++; > } > > to either the expansion of the macro: > > for (int i = DR_FIRSTADDR; i <= DR_LASTADDR; i += 2) > { > ... > } This, IMO. I think it's just that one place? > > or to a new macro that would take into account the increment: > > ITER_DEBUG_ADDRESS_REGISTERS (i, i += 2) // other users would use i++ > { > ... > } > That'd obfuscate too much for no real benefit, IMO. Thanks, Pedro Alves