[PATCH v3 06/24] Unit tests for gdbserver memory tagging remote packets

Luis Machado via Gdb-patches
2020-11-09T17:05:01Z

Updates on v2:

- Update unit tests to cope with additional tag type field in the remote
packets.

--

Add some unit testing to exercise the functions handling the qMemTags and
QMemTags packets as well as feature support.

gdbserver/ChangeLog:

YYYY-MM-DD Luis Machado <luis.machado@linaro.org>

* server.cc (test_memory_tagging_functions): New function.
(captured_main): Register test_memory_tagging_functions.
---
gdbserver/server.cc | 100 ++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 100 insertions(+)

diff --git a/gdbserver/server.cc b/gdbserver/server.cc
index 7eddd0e01f..6812b624f8 100644
--- a/gdbserver/server.cc
+++ b/gdbserver/server.cc
@@ -3647,6 +3647,103 @@ detach_or_kill_for_exit_cleanup ()
}
}

+#if GDB_SELF_TEST
+
+namespace selftests {
+
+static void
+test_memory_tagging_functions (void)
+{
+ /* Setup testing. */
+ gdb::char_vector packet;
+ gdb::byte_vector tags, bv;
+ std::string expected;
+ packet.resize (32000);
+ CORE_ADDR addr;
+ size_t len;
+ int type;
+
+ /* Test parsing a qMemTags request. */
+
+ /* Invalid request, addr len and type unchanged. */
+ addr = 0xff;
+ len = 255;
+ type = 255;
+ strcpy (packet.data (), "qMemTags_wrong:0,0:0");
+ SELF_CHECK (parse_fmemtags_request (packet.data (), &addr, &len, &type) != 0);
+ SELF_CHECK (addr == 0xff && len == 255 && type == 255);
+
+ /* Valid request, addr, len and type updated. */
+ addr = 0xff;
+ len = 255;
+ type = 255;
+ strcpy (packet.data (), "qMemTags:0,0:0");
+ SELF_CHECK (parse_fmemtags_request (packet.data (), &addr, &len, &type) == 0);
+ SELF_CHECK (addr == 0 && len == 0 && type == 0);
+
+ /* Valid request, addr, len and type updated. */
+ addr = 0;
+ len = 0;
+ type = 0;
+ strcpy (packet.data (), "qMemTags:deadbeef,ff:5");
+ SELF_CHECK (parse_fmemtags_request (packet.data (), &addr, &len, &type) == 0);
+ SELF_CHECK (addr == 0xdeadbeef && len == 255 && type == 5);
+
+ /* Test creating a qMemTags reply. */
+
+ /* Non-empty tag data. */
+ bv.resize (0);
+
+ for (int i = 0; i < 5; i++)
+ bv.push_back (i);
+
+ expected = "m0001020304";
+ SELF_CHECK (create_fmemtags_reply (packet.data (), bv) == 0);
+ SELF_CHECK (strcmp (packet.data (), expected.c_str ()) == 0);
+
+ /* Empty tag data (error). */
+ bv.clear ();
+ SELF_CHECK (create_fmemtags_reply (packet.data (), bv) != 0);
+
+ /* Test parsing a QMemTags request. */
+
+ /* Invalid request and non-empty tag data: addr, len, type and tags
+ unchanged. */
+ addr = 0xff;
+ len = 255;
+ type = 255;
+ tags.resize (5);
+ strcpy (packet.data (), "QMemTags_wrong:0,0:0:0001020304");
+ SELF_CHECK (parse_smemtags_request (packet.data (), &addr, &len, tags,
+ &type) != 0);
+ SELF_CHECK (addr == 0xff && len == 255 && type == 255 && tags.size () == 5);
+
+ /* Valid request and empty tag data: addr, len, type and tags updated. */
+ addr = 0xff;
+ len = 255;
+ type = 255;
+ tags.resize (5);
+ strcpy (packet.data (), "QMemTags:0,0:0:");
+ SELF_CHECK (parse_smemtags_request (packet.data (), &addr, &len, tags,
+ &type) == 0);
+ SELF_CHECK (addr == 0 && len == 0 && type == 0 && tags.size () == 0);
+
+ /* Valid request and non-empty tag data: addr, len, type and tags updated. */
+ addr = 0;
+ len = 0;
+ type = 0;
+ tags.resize (0);
+ strcpy (packet.data (),
+ "QMemTags:deadbeef,ff:5:0001020304");
+ SELF_CHECK (parse_smemtags_request (packet.data (), &addr, &len, tags,
+ &type) == 0);
+ SELF_CHECK (addr == 0xdeadbeef && len == 255 && type == 5
+ && tags.size () == 5);
+}
+
+} // namespace selftests
+#endif /* GDB_SELF_TEST */
+
/* Main function. This is called by the real "main" function,
wrapped in a TRY_CATCH that handles any uncaught exceptions. */

@@ -3664,6 +3761,9 @@ captured_main (int argc, char *argv[])
bool selftest = false;
#if GDB_SELF_TEST
std::vector<const char *> selftest_filters;
+
+ selftests::register_test ("remote_memory_tagging",
+ selftests::test_memory_tagging_functions);
#endif

current_directory = getcwd (NULL, 0);
--
2.17.1