From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130749 invoked by alias); 30 Jul 2018 23:07:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 130738 invoked by uid 89); 30 Jul 2018 23:07:08 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 30 Jul 2018 23:07:06 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w6UN70nw006450 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 30 Jul 2018 19:07:05 -0400 Received: by simark.ca (Postfix, from userid 112) id 70D3C1EF2A; Mon, 30 Jul 2018 19:07:00 -0400 (EDT) Received: from www.simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id E90F11E4AE; Mon, 30 Jul 2018 19:06:56 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 30 Jul 2018 23:07:00 -0000 From: Simon Marchi To: Tom Tromey Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PP?] Re: [PATCH] Delete test target descriptions when exiting In-Reply-To: <87d0v4o1oa.fsf@tromey.com> References: <1532983661-8486-1-git-send-email-simon.marchi@ericsson.com> <87d0v4o1oa.fsf@tromey.com> Message-ID: <685bce9bb51ca0e8ff428ec3f6441d94@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-07/txt/msg00800.txt.bz2 On 2018-07-30 17:26, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> Looking at the address sanitizer output, this was a quite low > hanging > Simon> fruit. We create target_desc objects for testing that we never > free. > Simon> Saving them in unique_ptrs takes care of it. > > FWIW this looks fine to me. Thanks, I'll push it soon. > As I mentioned a few minutes ago, I have a bunch of -fsanitize=address > and -fsanitize=undefined patches. I sent a few a little while ago, but > I have more here. I thought I'd mention the state of this so we can > avoid duplicating work. > > I have *not* looked at the AddressSanitizer leak reports at all, and I > wasn't planning to. Indeed, it's because you mentioned it that I took a look. I'll try to integrate that in my "standard" build. > And, I don't yet have patches for any of the existing bugs: > > https://sourceware.org/bugzilla/buglist.cgi?bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&list_id=43341&longdesc=AddressSanitizer&longdesc_type=allwordssubstr&product=gdb&query_format=advanced > > Of these, only 22860 occurs during an ordinary "make check"; for that > one I have an idea of how to fix it, but I haven't tried it. Understood. Thanks, Simon