From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 6ABA43858D35 for ; Fri, 31 Jul 2020 21:34:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6ABA43858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 521D51E111; Fri, 31 Jul 2020 17:34:07 -0400 (EDT) Subject: Re: [PATCHv3 2/3] gdb/testsuite: Detect and warn about duplicate test names To: Andrew Burgess , gdb-patches@sourceware.org References: <69e3904db9020da1941ec91e4b4b9c1ea2a6493d.1588245462.git.andrew.burgess@embecosm.com> From: Simon Marchi Message-ID: <685b3981-8a03-ff1b-ce22-a7fd101c6fef@simark.ca> Date: Fri, 31 Jul 2020 17:34:06 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <69e3904db9020da1941ec91e4b4b9c1ea2a6493d.1588245462.git.andrew.burgess@embecosm.com> Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Jul 2020 21:34:09 -0000 On 2020-04-30 7:20 a.m., Andrew Burgess wrote: > Building on the previous commit, this patch detects when two tests > have the same test name and causes Dejagnu to print a new result type > '# of duplicate test names' in the result summary. A line starting > with 'DUPLICATE: ' is also added to the gdb.sum and gdb.log files. > > The DUPLICATE markers will be printed the second time a duplicate test > name is seen, and every time after that. So you might see: > > PASS: gdb.base/sometest.exp: foo > PASS: gdb.base/sometest.exp: bar > PASS: gdb.base/sometest.exp: foo > DUPLICATE: gdb.base/sometest.exp: foo > PASS: gdb.base/sometest.exp: baz > PASS: gdb.base/sometest.exp: foo > DUPLICATE: gdb.base/sometest.exp: foo > > However, the results will report a duplicate count of 1, indicating > that just one test name (foo) was duplicated. > > Currently if the tests are run in parallel mode the new result type is > not merged into the combined summary file so users will need to run in > non-parallel mode to check this result. Similarly, the 'DUPLICATE: ' > markers will not be merged into the final gdb.sum file. A later > commit will fix this. Hi Andrew, When testing on Red Hat 7.8 (machine gcc135), I get this, which I think is related to this change. Running /home/simark/src/binutils-gdb/gdb/testsuite/gdb.ada/O2_float_param.exp ... can't unset "all_test_names": no such variable while executing "unset all_test_names" This machine has Dejagnu 1.5.1, which I suppose is the version that comes with this distro version. I'm kind of curious that this has not been reported before (or I missed it?). Do you think it would be easy to make this feature compatible with that version of Dejagnu? Otherwise, could we document the required version of dejagnu required to run the testsuite? Simon