From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sonic313-20.consmr.mail.ir2.yahoo.com (sonic313-20.consmr.mail.ir2.yahoo.com [77.238.179.187]) by sourceware.org (Postfix) with ESMTPS id 537A23896148 for ; Tue, 26 May 2020 16:31:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 537A23896148 X-YMail-OSG: KfNy0XMVM1k3KLQazUp0VkN7gyVoU0xvZA_g5cBWWKYCc4fhmYk1jJVFY0cYSp8 H05u8kI7TRiCXDfX659_U0Kn_sTvWH2vfh4f4X9MjM9cD1b2oVU9DgBuU9w07H6S1zp7ZWX7yUEw 7rMVd9f0u3fPF1FZo6Gi8wjfdPZgLZ7nNU02da74ZM57Aa_dv5oa.8KlqUqPhGSCnz9NxDDPg.Wa ZintG8YYdYW6pnkAUd3o3eMdVdLOdyllEpBhRUg3uoKHdr0Nrx_X.57fHDIo.FN7oEPO_cQ1tvB0 tLqPY63yJXK1Bejdxej3yFVenZYc2J22__Ep875bRCr9MXUvLwNy.gz41vI6Dkb1CFelsQkG98Nw _RbTi3x3soeQRPmpvax5ZU7lW5tP3.eVITV1.aRMIfipRyqheTXGFzvPCCYIhkFqWFZMwDnCWFNU SmvYAHhx_.vYCXYONhamvrsN_RKKDxJKXdxxyVCOv2tXI3jeeVoO2UVjU5P.V7NFSp9vAgLy5C20 44nOGtgfY7.yYux7gd0slo8ZYFDb2XoW9DnArWu7V8pUzmHOutSsCVGFu6o4LqSaHSHDwSVUAjXn h_uKstOmBOJpxW0mJljbRBKpYqmzqsDj4ILGLplx3qKO3WljCbjDjiml83_rsxpgotKUwKvx.klN _IWM.Y1egaQs0u2RSZmyuLPK4qlSajn1W2D.CpkrRmk98QB8kTt8uMrmOXPjurv5m2mv2MN._rI0 6eQ4VhWW8SO9Sl7wuC5OB8sPxT3_fUQD9gGNlwf0jZk1vJ26ZX3GvrveV5clusOgFhbXeGypOQ0H QTtS3CZWoBWQIW.D33p.2ccbgdUwOTXi2ISu254C0RWDup8.rV6Hrm5tM8BdTac9J21ZHm5W_bRO vBmuPEIJxVx9Rb4dmfr19Fra5H5ffv8MQLHpx4iL.tLUo8vWSdLEquILxp1XEF6q7V1IrNkh4nHd tEzcwthoiewCvm6PYxY1DDAGS2B4Jobij3gRV1OB4EAktMfq.Ljsz.WFz4TlBnUpNgugObBN_40I _XS3Zfm5r1l53g.Veblfs_znCpZ9ZD_1.UebD4x6uVekg1xLyKcGotVWBYaaOtyxq.AtmOH_xxDH _vyBPUp3VHezr3jDTM6IGMC_2lMelyUw2VQdnZ.wPbTGA3n_yrJufB5hj99EkH1qbLLLBpSU8nPi eetyBQQ_5mNBBcAXFjmARPZiqr5ZQCEVVgp5aG1IhF3lgaoVSbVB2q9GXxEZiWYvYsq4llLCi_NN el.uIYz9FsxSq3w13pJaFsT_s04CCxr_benJW5LHwzNalMYTyjSWmXlgPZjekTwNPrsMKIPW5C3q 6qAP9dlpI81lEggmHluNsqw-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ir2.yahoo.com with HTTP; Tue, 26 May 2020 16:31:33 +0000 Date: Tue, 26 May 2020 16:31:30 +0000 (UTC) From: Hannes Domani To: Gdb-patches Message-ID: <685376464.6597227.1590510690661@mail.yahoo.com> In-Reply-To: <73d80a58-df3b-6a85-8709-f751e83ec5d5@dronecode.org.uk> References: <20200525185659.59346-1-ssbssa@yahoo.de> <20200525185659.59346-3-ssbssa@yahoo.de> <73d80a58-df3b-6a85-8709-f751e83ec5d5@dronecode.org.uk> Subject: Re: [PATCH 2/7] Handle Windows drives in auto-load script paths MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.15960 YMailNorrin Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:76.0) Gecko/20100101 Firefox/76.0 X-Spam-Status: No, score=-8.9 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 May 2020 16:31:35 -0000 Am Dienstag, 26. Mai 2020, 18:04:13 MESZ hat Jon Turney Folgendes geschrieben: > On 25/05/2020 19:56, Hannes Domani via Gdb-patches wrote: > > Fixes this testsuite fail on Windows: > > FAIL: gdb.base/auto-load.exp: print $script_loaded > > > > Converts the debugfile path from c:/dir/file to /c/dir/file, so it can = be > > appended to the auto-load path. > > > > gdb/ChangeLog: > > > > 2020-05-25=C2=A0 Hannes Domani=C2=A0 > > > >=C2=A0=C2=A0=C2=A0=C2=A0 * auto-load.c (auto_load_objfile_script_1): Con= vert drive part > >=C2=A0=C2=A0=C2=A0=C2=A0 of debugfile path on Windows. > > --- > >=C2=A0 gdb/auto-load.c | 7 +++++++ > >=C2=A0 1 file changed, 7 insertions(+) > > > > diff --git a/gdb/auto-load.c b/gdb/auto-load.c > > index 99bd96b971..88221d9f3d 100644 > > --- a/gdb/auto-load.c > > +++ b/gdb/auto-load.c > > @@ -784,6 +784,13 @@ auto_load_objfile_script_1 (struct objfile *objfil= e, const char *realname, > >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "scripts= -directory' path \"%s\".\n"), > >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 auto_load_dir); > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* Convert Windows debugfile path from = c:/dir/file to /c/dir/file.=C2=A0 */ > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (HAS_DRIVE_SPEC (debugfile)) > > +=C2=A0=C2=A0=C2=A0 { > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 debugfile_holder =3D STRIP_DRIVE_SPEC (= debugfile); > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 filename =3D std::string("/") + debugfi= le[0] + debugfile_holder; > > > Is this kind of path transformation msys(2) specific? Yes, MSYS2 uses /c/foo paths, but that's not what this is used for. I think this is basically the same question of Christian I just answered: > > How does this work? I thought /c/foo was not supported by either > > cygwin or mingw? > > Yes, but in this case we need a path that can be appended to the various > entries of 'set auto-load scripts-directory'. > c:/foo can't be appended, but /c/foo can. > So you would get something like c:/script/directory/c/foo. Hannes