[PATCH] opcodes/i386-dis.c, print_insn, null ptr.

[msnyder@sonic.net]

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

If we come to this point via the default case in the switch
statement above, we will not have updated 'dp' and dp->name
will still be null.  Then putop will dereference it.


[-- Attachment #2: 19b.txt --]
[-- Type: text/plain, Size: 1092 bytes --]

2007-08-01  Michael Snyder  <msnyder@access-company.com>

	* i386-dis.c (print_insn): Guard against NULL.

Index: i386-dis.c
===================================================================
RCS file: /cvs/src/src/opcodes/i386-dis.c,v
retrieving revision 1.131
diff -p -6 -r1.131 i386-dis.c
*** i386-dis.c	29 Jul 2007 19:43:36 -0000	1.131
--- i386-dis.c	1 Aug 2007 21:11:02 -0000
*************** print_insn (bfd_vma pc, disassemble_info
*** 3779,3791 ****
  	    default:
  	      oappend (INTERNAL_DISASSEMBLER_ERROR);
  	      break;
  	    }
  	}
  
!       if (putop (dp->name, sizeflag) == 0)
          {
  	  for (i = 0; i < MAX_OPERANDS; ++i)
  	    {
  	      obufp = op_out[i];
  	      op_ad = MAX_OPERANDS - 1 - i;
  	      if (dp->op[i].rtn)
--- 3779,3791 ----
  	    default:
  	      oappend (INTERNAL_DISASSEMBLER_ERROR);
  	      break;
  	    }
  	}
  
!       if (dp->name != NULL && putop (dp->name, sizeflag) == 0)
          {
  	  for (i = 0; i < MAX_OPERANDS; ++i)
  	    {
  	      obufp = op_out[i];
  	      op_ad = MAX_OPERANDS - 1 - i;
  	      if (dp->op[i].rtn)