On 9/24/21 4:10 PM, Pedro Alves wrote:
> On 2021-09-17 11:49 p.m., Tom de Vries via Gdb-patches wrote:
>> diff --git a/gdb/testsuite/gdb.trace/qtro.exp b/gdb/testsuite/gdb.trace/qtro.exp
>> index 91a6612fb10..8b538e8c249 100644
>> --- a/gdb/testsuite/gdb.trace/qtro.exp
>> +++ b/gdb/testsuite/gdb.trace/qtro.exp
>> @@ -22,7 +22,7 @@ load_lib trace-support.exp
>>  
>>  standard_testfile
>>  
>> -if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug nopie}]} {
>> +if {[build_executable "failed to prepare" $testfile $srcfile {debug nopie}]} {
>>      return -1
>>  }
>>  clean_restart $testfile
> 
> Well, cases like the above would be better handled by removing the clean_restart call.
> 

Indeed.

I did one more pass over it and retested.

I'll commit tomorrow unless there are further comments.

Thanks,
- Tom