Re: [RFA] Type cleanups

Daniel Jacobowitz
2002-05-13T03:40:35Z

On Sun, May 12, 2002 at 11:18:25PM -0400, Andrew Cagney wrote:
> >In order to fix gdb/277, I needed to move a lot of members of 'struct
> >type'. This patch flushes out all (that I could find) direct accesses of
> >these
> >members instead of through the proper macros. It's possible that I missed
> >some; if so, the next patch will cause whichever files I missed to stop
> >compiling. I'm pretty sure I got them all, though. I also clean up the
> >only remaining references to 'sizeof (struct type)': dstread.c had a clone
> >of alloc_type, and hpread.c needed to call replace_type like the other
> >readers.
> >
> >This patch should have no effect. On i386-linux, I get byte-for-byte
> >identical GDB binaries (all 5591185 bytes of it, debugging information
> >and all; no -g3 here).
> >
> >OK to commit?
>
> Did you check all the cross targets build per MAINTAINERS? From memory
> sh-hms[bfd] and avr[need to look] don't build at present (well as of
> ~2002-05-12-gmt).
>
> If that has been checked, then yes ``obviously''.

I'll do that. Sigh, takes forever... least there are scripts for it.

BTW, the fragment of awk in MAINTAINERS only works with GNU awk.

> Does this mean that ``struct type *'' is becoming opaque? Looking at
> the next patch, no, sigh.

No. It's accessed so frequently that switching from macros to accessor
functions would be a ridiculous performance hit, I think.

--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer