From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88729 invoked by alias); 31 May 2016 14:23:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 88710 invoked by uid 89); 31 May 2016 14:23:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Notice X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 31 May 2016 14:23:05 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F27B05C6; Tue, 31 May 2016 14:23:03 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u4VEN2KT018059; Tue, 31 May 2016 10:23:03 -0400 Subject: Re: [PATCH v3][PR gdb/19893] Fix handling of synthetic C++ references To: Martin Galvan , gdb-patches@sourceware.org References: <20160530194057.13511-1-martin.galvan@tallertechnologies.com> From: Pedro Alves Message-ID: <67dc8b18-2006-4309-4b18-4c8080e89250@redhat.com> Date: Tue, 31 May 2016 14:23:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-05/txt/msg00554.txt.bz2 On 05/31/2016 03:13 PM, Pedro Alves wrote: > Otherwise OK. Please push. Actually, I take that back, sorry. I forgot something: >> + Notice that for references to TYPE_CODE_STRUCT, 'set print object on' will >> + cause original_value to be a not_lval instead of an lval_computed, >> + which will make value_bits_synthetic_pointer return false. I still think it'd be very good to have this covered with a test. I think it should be a matter of wrapping the printing part of new tests (maybe only implref-struct.exp, not sure), with: foreach_with_prefix print-object {"off" "off"} { gdb_test_no_output "set print object ${print-object}" ... ref printing tests ... } Could you do that please? Thanks, Pedro Alves