From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 7ipoJk7rcmZtuz4AWB0awg (envelope-from ) for ; Wed, 19 Jun 2024 10:29:34 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=z3gMat8J; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8ABCA1E0C1; Wed, 19 Jun 2024 10:29:34 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4698D1E030 for ; Wed, 19 Jun 2024 10:29:32 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 94AEE388456D for ; Wed, 19 Jun 2024 14:29:31 +0000 (GMT) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2062d.outbound.protection.outlook.com [IPv6:2a01:111:f403:2418::62d]) by sourceware.org (Postfix) with ESMTPS id 46EC8388456D for ; Wed, 19 Jun 2024 14:29:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 46EC8388456D Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 46EC8388456D Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:2418::62d ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1718807355; cv=pass; b=fhc68yH+EbQokeeCtYE2ruqgfM77RTzrPMr7kicRzoILKZ4aCIhyr54LkRWdHUVjbWoM5Lq4gnClOJq3TCFjFYGm23turb9o1G/+ZAHV0UxQKwK1dgczH1O3wB6Wv1tLyImw8rX5pjQrJ7JY/SktNQ1AaxiqAz4FRYDsJkqZFzk= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1718807355; c=relaxed/simple; bh=wkl/MpZhBVBeD/efgbaO6X56ysQj/3vAWukmEsXnjrk=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=jj+/O3NPK5hPyjBnXKr0OUvjv8QgS5ugEIIQJlnO6AKCQMUTmpBz5FgMwRTPfoRNHFge2xjbBXioDrnL4VFui3zCOHvC4+1NSKmZceFcqNGkMgPlRVbntjDUzHwosgINiyIp0XZ10uWlfx0gCJrZiHQexDBQich5abviUdMfj3s= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YS2OC6Zat7H1y3bLRm6v3oTs95Hkg3NSm9NM6gj82Jg9BtYh7zBveh/Q16oWsEDql5BZCQ9W/EJSdpOZE3WYjQ+08xH8shqps/Uc9xOXTeVR9RORA4kjfCu5iUqaq+BqrgyS9Y2ifk3B9cRHX0U9lrOoy9PPbWxA42C5VX2RLURMPyf8da4jBhrsiHzKGH9PLG8tH2BISM3YhwQiuDnX5kT/IS+9kBg+RAPi43DNy2VwDEIhBXUnFNpUHDRYud16POeGqfLpXu7lheJXQHAvkbeMQmgtXMnKZHYhIYKMBhm0IYcO3KLssIdN8udlmC0PHJxZU2GyO+Pzi3mWlym8rQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PI4jX8KnRQGSsLumMhegIpJ9jaNrbFfpwiDKcWW4bQ0=; b=CtjtAlhP8ozfWeysEym0sE2vRviipT7AfKlXg7LhMpwQUQFOHLS/lBs/+ZxeudwewUXsB6/QVSLB48N43U2+f2wMCFuztuG3uR/bFDIl9LSHtVIO+c+8XfIQ6I7uHz0KzVDzSZb8sUgSpxEWeEL8Q7eahZ3MyHrHf/3cfLvc+OboRd+0XXhkJBKFWcRvNajT6u5mvZYfoErY6YDsEeG6LS/676JNEj3HgqloT2vUrkHermWGN3jMjzPiFA5EMEswqHMR3RDsEyfGBgtH0EIlt+IJ1FuyiUzBv+3SlhoUj7rcaXyMaozdLT8WiO8lCqwunVuvnVZDIYqrsBz4VszOOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PI4jX8KnRQGSsLumMhegIpJ9jaNrbFfpwiDKcWW4bQ0=; b=z3gMat8JpLbDdms72GdMUdTia4lD4KldPseVTR5YX9wdG5n80lGrbOyabLgv8F7p6BzwR08xftCRdt92rE3AjCVIgEfLatTjSr1MioiR3lyrKePDhxnH8eoytY2XC+6JJ054fjuMGAtSn+scee+N10Jptvr82AKLZ7JetCqc7ho= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) by SJ2PR12MB8111.namprd12.prod.outlook.com (2603:10b6:a03:4fe::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.30; Wed, 19 Jun 2024 14:29:11 +0000 Received: from CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::8c67:8cec:7c4a:ccaa]) by CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::8c67:8cec:7c4a:ccaa%5]) with mapi id 15.20.7698.017; Wed, 19 Jun 2024 14:29:11 +0000 Message-ID: <67cd552f-3dfb-4a91-81ab-ed5b158de67b@amd.com> Date: Wed, 19 Jun 2024 15:29:08 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/python/python-internal.h: avoid uninitialized constexpr To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20240618090952.537478-1-lancelot.six@amd.com> <8734pacjju.fsf@tromey.com> <2317caf4-6fdb-46d1-b2aa-caffed3faffe@amd.com> <87wmmmxcat.fsf@tromey.com> <72ea54a7-b6de-42b3-8889-f8921c0d2074@amd.com> <87sexax8tb.fsf@tromey.com> <87jzilyeo6.fsf@tromey.com> <6c29a247-3b9c-4562-a4ff-1a0f502f647a@amd.com> <87frt9xd6d.fsf@tromey.com> Content-Language: en-US From: Lancelot SIX In-Reply-To: <87frt9xd6d.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR5P281CA0014.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:f2::7) To CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR12MB9079:EE_|SJ2PR12MB8111:EE_ X-MS-Office365-Filtering-Correlation-Id: 001e8834-4cce-48a5-92f4-08dc906c2fb2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|366013|376011|1800799021; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Ty9xZy9lQ0tLb2RuSWNmOXF3MkMyaEs2ZHFCVXpqOWJOV2RLTmVGNWRhZDdr?= =?utf-8?B?c0pHR1RFVTBNZHNrbVdFbm9qU2tFSWhRSXdDczU3ektNRk9ody95V2pOVVIr?= =?utf-8?B?ckJKK0htN1h1dEFzTjhCMGNSQllrSDBINVRsZEIvZlZ5M0FTVEVjVzh1L0tw?= =?utf-8?B?ZlI1L0MyaS96ZENpZ3dvOG50dVJxWkhXakFzSWd5OGI1azJIcEE0YWkyVHNL?= =?utf-8?B?TEpxK2cvNld1Q2greTluZTA3eE9Fbnp4c0N2U1pkNWkwREZ2a0g0M2g5Qlcy?= =?utf-8?B?Tit0Z2ZUVERTekdDM3dQeG94KzBwSEFEWkl6ak0yRndoSG5UMkx6SjhhRXV0?= =?utf-8?B?bG15NXNFMUFzRFRNVFlzeGRhbTdJUFNyYWtGQ0RERkNnY1RCV1RQdmJpMVFO?= =?utf-8?B?d2JJNjJzWXhYeFdyUkQ2Y2pLcFhvRGpjZEVkKzJrNVFQazZFSVMrYS9hdGNj?= =?utf-8?B?QjZEcHpSelAvZHA1cmRSUDhwNVpUMEJsTUlEbnUzLzhxZXJIcDM4VkNOd3FV?= =?utf-8?B?d2x0WWtlY1lDMkxWNGtNZnZ3NXFrdkpKSWVzOVdJMlZicW4zRHVGbGE0VW1S?= =?utf-8?B?azBrNmpBVGtmeDIyV2Jza2JrWnhLYlhscU13MnlLOC9aUjByWWs5d3o1UmNt?= =?utf-8?B?aHkyam93Z1dLSldWaFlWenBxRzhtcnhhR1NBRDZERTZCQXdYUks2NmZtVEpU?= =?utf-8?B?Y0wzTzMweGV5NiszQmJWSU5XTHQ2WjdWZUVhZXZYNyt5NXI0ZWRBeUhjMmM4?= =?utf-8?B?ZUhpUzVWTzBJQmxQVUkzcFdiYzg4WlVmOUFVVUFkOXhuM2xzUGlkdnpIRnY3?= =?utf-8?B?R0dmMGE5TENFNmlZdUtQN0JGc0FQUGRPcnFuUnJDTDZBeUdteHFWZm91Tjha?= =?utf-8?B?VXRLUHVySTh1NndxcTc0anhRdHRoY1RwYkVvcU9ZNEVCQWw0TXNnMml5dS94?= =?utf-8?B?TmhHSGdZTVZ2YnpJMi84YmZ3aEI4Y05SYndFTjBodE80WkFtMXJvOVV6cCt3?= =?utf-8?B?NzJnUG8xei8wbk85VUQxdTdwR1JqdDdZUHBEdlBpMUVBeW9IQ1JJQkgzeFBq?= =?utf-8?B?OTIzSEdWQVdOS3NkL2VQR0xQMmd2YjJaYXpPdkFBM1lEMzZHcWYrQUhZN3F2?= =?utf-8?B?VlNWVlJRd1ZEeFhpSjhya0RCb2Q0elpRZkhYYisxV29nL3VuSHNwRTNjaHVR?= =?utf-8?B?VmcxUnlFTk5pNWhCRFZDa2o3MERmdHhNYnZyYytkSUdlQldmaDNBaC9sZXV4?= =?utf-8?B?dVViQTBTbHp4blpXc2pQbU5uOWtjUlBwZ2hzK21kTWU0Mm9SaHBSUzlCSkdI?= =?utf-8?B?Y0t6bUNnWE5NV2lsbEowRFh0TDlEU251amoyZXZSOVFQOVFmYXM3RjFKSTQz?= =?utf-8?B?MCtlWVI2WDRTZVN3TkEvZkV5a0RHU3U1Zk5waVF6ODdWM29XeURkb0dxY3dw?= =?utf-8?B?T2p1UjBvZnBvOGl1VzYyek11SVh3clpOdXNTRVBwREczM29pa3l6aWdRYU85?= =?utf-8?B?SDE1U2s2dmpBS0I5VEJDZEtFU25CTi9Oc2dZSDFQSW5PRzRHY200ZGNmbW5w?= =?utf-8?B?OGN4Ui9pNkJYMnI5eWd1SnNEWjMxb1h1RElPOXNHYlViNGxZcFluaXFWUTNN?= =?utf-8?B?L3drTTliQXlvV3Y0RUZoZ0xxUUtJeXhsQi9CS0V6VzhKMVMwamhJbGhJK0tw?= =?utf-8?B?R2N0b21NR1hCQ0t4YTBIbHQ5UVVUZFI3UFhPTnZrcHRkNGIrNWRiazRkd01i?= =?utf-8?Q?9J2JZHCOi9rRJEp2YJoi+yN7kaKqPdGo883J6h+?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB9079.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230037)(366013)(376011)(1800799021); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eHRlOHZyRzJVT3JwWFBjb1A0RDNYbUF2OGxuWjNnNTk1bXBKOUNLc1p5Q3R0?= =?utf-8?B?N0IzaEZQZW9peGpPbm9xejFoZnVSVzVPVmtvY0VvZnR2Nm4wY091QnVGRU93?= =?utf-8?B?OWozdlFLcnkyRVNBSGVuTlB4NzNoTmR6aDA4Um11QUZrRHRLSGJ0aUVKNkZ5?= =?utf-8?B?VEJQSXhWM0hFSEw1eGNLWW5VUnlYR2JQcTBIS29ienZFMVlyUU1kV1pkdVVD?= =?utf-8?B?WjMyTEVBNFJZV2FUN3dmZEU2SHJxa0w4cTRKQUlQSlE2R3Ayb0x2ZUlvdHZi?= =?utf-8?B?M1ZRWTcyemxZRWxaa3c4dy9NRkxoZTdpdUhNcENvOEJBcm92OXp1eXEwK2NU?= =?utf-8?B?VU5DOFdoV1RTVENjck1ycG1QT2NOcjdXaVA0Z0hMbk5IOFV2emlDU2p5T2JC?= =?utf-8?B?dFlta0dIUFY0eUNLdStVM2xmRmxtbUgxWVcxRHBJTTlHYTRkcGUwYVh2QndG?= =?utf-8?B?dGNna0d5SGVyQThpOTFTTTV6dmgyMmhCY2F4d05jSUN5MCtkSVFUaGU0SXBa?= =?utf-8?B?OU9od0Y5eWh0eTducGR4KzhPWFpGSU85WkJOMytaQkZ4ZEZRcGxXTnhLUHlo?= =?utf-8?B?MGRDbTcvUTBZR1gwaFFKU1FTKzUvRVkvSHhsZFVzMkxvL0d1czJ3bC9IRnQ3?= =?utf-8?B?UFprZGxJVHprVFdQNGxDSzBadmp3RmsyampGb3B1YnliVmpadWhkZEw0WUpJ?= =?utf-8?B?ZmZ6RHVTZmtyT2drZVAvb05GcThTN0ZIeU8zdkJFNUxSb1Jmd0xjK1dTb3N5?= =?utf-8?B?WHEzTWRKalpqMGNSc0N2RGMxQXpqUHNNOGZZL3NqZzJyVmFzbUljc3JuR3Br?= =?utf-8?B?MXZvSGtLelhXNkhsYlJqRERSS1pXREw1OXdXdkFEeE5TSFZnRDZUSWd6ZTRY?= =?utf-8?B?cEFocXZEbzllckxHUHlnbWMrODJIQUhSQ1FYS3N1eXdBdkEyVEltSWdVVEx1?= =?utf-8?B?Yy9udnF5ZHY2Snkydzk5b0tEL3lDOEY4LytOSTgrR1RMYnkvK2xWVnM1eThP?= =?utf-8?B?MUJ4WDFhS1M4VUhSUzE5cEZOMnowb3czU3NDQStuMkY3bkVzWHFLZDhMcXNH?= =?utf-8?B?cWFSbVRwK3FicDVodXBoZGZUWElnclo3UHR2VThUelZ5cXVKSDRsWkU5OTgw?= =?utf-8?B?YXVMYVNGbGszWkU2NVhuc0R4bmw1MEJ4S21vWmFuWWZRTURoR0IwVDlaQS9T?= =?utf-8?B?Ym1Qd1ZrWmgzdTAyQWJqM0R2aXQwSE1VZ0FvMnNyRmdueXU0azhkN0V0MXdk?= =?utf-8?B?U1h2RStFN0FLR1dSWFQ1RUNJelBMMEZtWnhTby9RS29FS29JMWJGcXdjUUln?= =?utf-8?B?b2NMY3FRSFBoMGdBNi90ZjllQWpZM0x5NDhYSUpWOWh5UGx4MWxJaytUdXFG?= =?utf-8?B?WFlIZXFQN2dDMHRVZWtiNUFzN0hldXgyckJLTmVDN0ozcldFTk5ubkJLbUV3?= =?utf-8?B?dDIxZkpOZ2svd1FtQ3RhaUZLVFlZSkNlNFR5ZUtrWG93TGloUXNuWjB3WUR6?= =?utf-8?B?VFZybDRQVGl0WUpaZi9nbFgrUDJUM3lpMVVKL0FHdXFDWHRlZDk2cy9uYVRy?= =?utf-8?B?S0k1RDdmb2xFSit5cHhMZzE1Y3FhTHZvK3ZiTVdWaEIvZnRNVGFCQTEzRmMx?= =?utf-8?B?akNCdDBaejRkay9wRjVlVmhad2xaME11WTdwSFdPcHg1MWVjbExPeDl5VXUv?= =?utf-8?B?NktJR2tKSEx5S2FLQmVqeFo4S3ZGUW1GbE82TnZWSW9aQmRlZ2NIT0xNZVda?= =?utf-8?B?TkpTaGJ2bUlHRGR0UWNDOEZyRko1WjdMMm9OZmE5Y2VidXoxcDN4SmFUSnRo?= =?utf-8?B?VElZK0FRWVFCd2htTVdReE5oOVZDY0l0R3F3a3dOUm1aUU4rczg0OEJrcWpt?= =?utf-8?B?WjNER3RGK2JuVFNuR1Z3bDZjNUN4Q3RrdjJQb20zaGkzU24ramtiUHFPaW14?= =?utf-8?B?TUZFalBtNkd0YXFZcytlTGdNTVA2TVVPbHN1Y3lCNldhVC96bVRrTWgweGdu?= =?utf-8?B?REhvcWFYL1M2UkppUnc0UkV0THZmOXgvakZBVGpGcUdkUUlUNFFpTVcwUVZR?= =?utf-8?B?MkdYZlpVVENUSWxZRG1scUpmak0ra2pPUk9JWWg4QzdHa0FZM1N4QjQ1ZmRR?= =?utf-8?Q?Idz/E2TuQThCRqIs7SgUnLWP6?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 001e8834-4cce-48a5-92f4-08dc906c2fb2 X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB9079.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2024 14:29:11.3687 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XO1Ka1QIPMFefqLkxh0OW35AikRwYWCg+gs9WnxS3ZYAXiSHLidCgG/nvkPlV1yxUiPclTQ3QvXwjPYHbd3Zvw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8111 X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FORGED_SPF_HELO, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org > > I'm satisfied now that there's an explanation. I personally think the > inline constexpr variable is more aesthetically pleasing but you can > push your original patch if you prefer. > > Tom Thanks, I have pushed this patch as ea4e03c0a9f5ed8574dcaa434cd979a6f92f5c1f. Best, Lancelot.