Re: [PATCH 16/28] Don't write to inferior_ptid in darwin-nat.c

Pedro Alves
2020-04-16T19:24:03Z

On 4/16/20 2:33 AM, Simon Marchi wrote:
> On 2020-04-14 1:54 p.m., Pedro Alves via Gdb-patches wrote:
>> Untested.
>>
>> gdb/ChangeLog:
>> yyyy-mm-dd Pedro Alves <palves@redhat.com>
>>
>> * darwin-nat.c (darwin_nat_target::decode_message): Don't write to
>> inferior_ptid.
>> (darwin_nat_target::stop_inferior, darwin_nat_target::kill): Avoid
>> inferior_ptid.
>> (darwin_attach_pid): Use switch_to_no_thread instead of writing to
>> inferior_ptid directly.
>> (darwin_nat_target::init_thread_list): Switch to thread, instead
>> of writing to inferior_ptid.
>> (darwin_nat_target::attach): Don't write to inferior_ptid.
>> (darwin_nat_target::get_ada_task_ptid): Avoid inferior_ptid.
>> ---
>> gdb/darwin-nat.c | 16 +++++++---------
>> 1 file changed, 7 insertions(+), 9 deletions(-)
>
> I tried to build it, here's a small patch to fix some typos. It would be good to
> check the other patches that you were not able to build for that pid_t/ptid_t typo.

Thanks, I merged that fix locally.

I diffed the whole series and didn't find any other case.

Pedro Alves