From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 83SOIuQfymD9EAAAWB0awg (envelope-from ) for ; Wed, 16 Jun 2021 11:59:32 -0400 Received: by simark.ca (Postfix, from userid 112) id 805011F163; Wed, 16 Jun 2021 11:59:32 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 466B41E54D for ; Wed, 16 Jun 2021 11:59:30 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9C03739551D7 for ; Wed, 16 Jun 2021 15:59:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9C03739551D7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1623859169; bh=huqjbOIJw7hlXMV/ippahdHOZsZyJ4JvQpKynUNs11A=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=fCMLbPAficAuMEtHz0rGl8FQTOyXToyDnKTl9TN3HS65pf/p0fVQxRmS8ZIEgCpQy SKp+vXy5LUNK7BgFDHXui5Af60KFFw84IJxzAA/gr+8JVcPLjRk4kA00Dp5NXUndP4 YzyK3qGEJZNWv9IE7SYb1k4jOQVb9N4IVpYQmH4I= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 11035393A439 for ; Wed, 16 Jun 2021 15:59:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 11035393A439 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 15GFx3TR022308 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 16 Jun 2021 11:59:08 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 15GFx3TR022308 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 9FAD21E54D for ; Wed, 16 Jun 2021 11:59:03 -0400 (EDT) Subject: Re: [PATCH/committed] sim: enable silent rules in common builds To: gdb-patches@sourceware.org References: <20210615000234.1211-1-vapier@gentoo.org> <0decd618-86e7-85db-5b95-db7454c07d61@polymtl.ca> Message-ID: <6750be05-09e1-e2d8-10be-e085071e540f@polymtl.ca> Date: Wed, 16 Jun 2021 11:59:03 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 16 Jun 2021 15:59:03 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-06-14 9:43 p.m., Mike Frysinger wrote: > On 14 Jun 2021 20:53, Simon Marchi via Gdb-patches wrote: >> On 2021-06-14 8:52 p.m., Mike Frysinger wrote: >>> On 14 Jun 2021 20:40, Simon Marchi wrote: >>>> On 2021-06-14 8:02 p.m., Mike Frysinger via Gdb-patches wrote: >>>>> We only do the common code as automake simplifies the logic. >>>> >>>> Are you interested in re-using what is done in GDB? I did this quickly >>>> to show how it works. It covers maybe 90% of the commands with very little >>>> effort. >>> >>> seems fine if you want to merge it ;) >> >> Ok, there's no issue in including the file directly from the gdb directory, >> the sim/ directory is never released without gdb? > > currently not > -mike > Ok, here's what I pushed. There are still a few non-silent rules, in particular I think we could say "GEN foo" instead of showing the big shell command that generates it. But I don't plan on doing it, the patch below already makes the output easier to follow. >From 7daf500de25c0e93bc70d593a7979657a2d4ceb5 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Wed, 16 Jun 2021 11:55:53 -0400 Subject: [PATCH] sim: make some rules silent by default in Make-common.in Use GDB's silent-rules.mk to make some rules silent by default. These rules cover most of what is built in sim/. gdb/ChangeLog: * silent-rules.mk (ECHO_CCLD, ECHO_AR, ECHO_RANLIB): New. sim/ChangeLog: * common/Make-common.in (COMPILE, libsim.a, run$(EXEEXT), gentmap.o, gentmap): Make rules silent. Change-Id: Idf9ba5beaee10c7c614859ace5fbdcd1de0287db --- gdb/ChangeLog | 4 ++++ gdb/silent-rules.mk | 3 +++ sim/ChangeLog | 5 +++++ sim/common/Make-common.in | 14 ++++++++------ 4 files changed, 20 insertions(+), 6 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index e841fdaab5e6..2444773bde93 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2021-06-16 Simon Marchi + + * silent-rules.mk (ECHO_CCLD, ECHO_AR, ECHO_RANLIB): New. + 2021-06-16 Tom de Vries PR symtab/26327 diff --git a/gdb/silent-rules.mk b/gdb/silent-rules.mk index 772bd6728be3..97d799bf2ae2 100644 --- a/gdb/silent-rules.mk +++ b/gdb/silent-rules.mk @@ -4,6 +4,7 @@ ifeq ($(V),0) ECHO_CXX = @echo " CXX $@"; ECHO_CC = @echo " CC $@"; ECHO_CXXLD = @echo " CXXLD $@"; +ECHO_CCLD = @echo " CCLD $@"; ECHO_REGDAT = @echo " REGDAT $@"; ECHO_GEN = @echo " GEN $@"; ECHO_GEN_XML_BUILTIN = \ @@ -14,5 +15,7 @@ ECHO_INIT_C = @echo " GEN init.c" ECHO_SIGN = @echo " SIGN gdb"; ECHO_YACC = @echo " YACC $@"; ECHO_LEX = @echo " LEX $@"; +ECHO_AR = @echo " AR $@"; +ECHO_RANLIB = @echo " RANLIB $@"; SILENCE = @ endif diff --git a/sim/ChangeLog b/sim/ChangeLog index 8896c4ca6ea7..109d5d8a9d25 100644 --- a/sim/ChangeLog +++ b/sim/ChangeLog @@ -1,3 +1,8 @@ +2021-06-16 Simon Marchi + + * common/Make-common.in (COMPILE, libsim.a, run$(EXEEXT), + gentmap.o, gentmap): Make rules silent. + 2021-06-16 Mike Frysinger * m4/sim_ac_common.m4: Delete AC_EXEEXT call. diff --git a/sim/common/Make-common.in b/sim/common/Make-common.in index 54ac7f40a9c0..0ab9e79e8fdf 100644 --- a/sim/common/Make-common.in +++ b/sim/common/Make-common.in @@ -40,6 +40,8 @@ srccom = $(srcdir)/../common srcroot = $(srcdir)/../.. srcsim = $(srcdir)/.. +include $(srcroot)/gdb/silent-rules.mk + # Helper code from gnulib. GNULIB_PARENT_DIR = ../.. include $(GNULIB_PARENT_DIR)/gnulib/Makefile.gnulib.inc @@ -111,7 +113,7 @@ depcomp = $(SHELL) $(srcroot)/depcomp # GNU make is used. The overrides implement dependency tracking. COMPILE.pre = $(CC) $(C_DIALECT) COMPILE.post = -c -o $@ -COMPILE = $(COMPILE.pre) $(ALL_CFLAGS) $(COMPILE.post) +COMPILE = $(ECHO_CC) $(COMPILE.pre) $(ALL_CFLAGS) $(COMPILE.post) POSTCOMPILE = @true # igen leaks memory, and therefore makes AddressSanitizer unhappy. Disable @@ -273,11 +275,11 @@ all: libsim.a run$(EXEEXT) .gdbinit libsim.a: $(LIB_OBJS) rm -f libsim.a - $(AR) $(AR_FLAGS) libsim.a $(LIB_OBJS) - $(RANLIB) libsim.a + $(ECHO_AR) $(AR) $(AR_FLAGS) libsim.a $(LIB_OBJS) + $(ECHO_RANLIB) $(RANLIB) libsim.a run$(EXEEXT): $(SIM_RUN_OBJS) libsim.a $(LIBDEPS) - $(CC) $(ALL_CFLAGS) $(LDFLAGS) -o run$(EXEEXT) \ + $(ECHO_CCLD) $(CC) $(ALL_CFLAGS) $(LDFLAGS) -o run$(EXEEXT) \ $(SIM_RUN_OBJS) libsim.a $(EXTRA_LIBS) # FIXME: Ideally, callback.o and friends live in a library outside of @@ -286,10 +288,10 @@ run$(EXEEXT): $(SIM_RUN_OBJS) libsim.a $(LIBDEPS) # a library). gentmap.o: Makefile $(srccom)/gentmap.c $(srccom)/nltvals.def - $(COMPILE_FOR_BUILD) -o $@ -c $(srccom)/gentmap.c $(NL_TARGET) + $(ECHO_CC) $(COMPILE_FOR_BUILD) -o $@ -c $(srccom)/gentmap.c $(NL_TARGET) gentmap: gentmap.o - $(LINK_FOR_BUILD) $< + $(ECHO_CC) $(LINK_FOR_BUILD) $< targ-vals.h targ-map.c: stamp-tvals stamp-tvals: gentmap -- 2.32.0