From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54970 invoked by alias); 15 Sep 2017 13:44:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 54682 invoked by uid 89); 15 Sep 2017 13:44:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 15 Sep 2017 13:43:59 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id v8FDhqYP007922 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 15 Sep 2017 09:43:57 -0400 Received: by simark.ca (Postfix, from userid 112) id A121F1ECF0; Fri, 15 Sep 2017 09:43:52 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 2839B1E5B9; Fri, 15 Sep 2017 09:43:52 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 15 Sep 2017 13:44:00 -0000 From: Simon Marchi To: Pedro Alves Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] gdbserver: Remove gdb_id_to_thread_id In-Reply-To: References: <1505074275-1662-1-git-send-email-simon.marchi@ericsson.com> <1505074275-1662-3-git-send-email-simon.marchi@ericsson.com> Message-ID: <674a4fa0df7fe6f7caee95a7f76fd27f@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 15 Sep 2017 13:43:52 +0000 X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00410.txt.bz2 On 2017-09-15 12:55, Pedro Alves wrote: >> >> - if (ptid_equal (gdb_id, null_ptid) >> - || ptid_equal (gdb_id, minus_one_ptid)) >> + if (thread_id == null_ptid || thread_id == minus_one_ptid) >> thread_id = null_ptid; > > This can be just: > > if (thread_id == minus_one_ptid) > thread_id = null_ptid; I thought that too at first, but actually if thread_id == null_ptid, execution will take the "else" branch and things will break after. Simon