From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id 477A1388A02D for ; Thu, 2 Apr 2020 14:03:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 477A1388A02D Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-103-UFp_B2N7N52-2wQKrcz2aA-1; Thu, 02 Apr 2020 10:03:11 -0400 X-MC-Unique: UFp_B2N7N52-2wQKrcz2aA-1 Received: by mail-ed1-f72.google.com with SMTP id w6so2809233edq.3 for ; Thu, 02 Apr 2020 07:03:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kjNW0L8UH4k5uLy5PU7dqHagYBX1ZnNIyZrKVRDYLv4=; b=DQQayqMQmNbCByB0BfRHFVncnjHbVy2YAIGKiT6saZwSReDlOIAJyJxFRHcX2d7RQV vylj/U6TpFy+In9nEgft/1JVmg3tb/T74pz7t+DQlFOeNazY7oYSwo39rw9UKvyffupS rdupgzOP/s7dNoSGw8PE+8yTq0HfD140vL+noIa7b4p+FmSbmwnc+pyOC3tFhUXD5d+Y 6SVoIoOw9lDQhNoa+1DG8eqHC8ruFU86AueZnqPDzBXhrnxonjsaymGlhM7Hj7xEDkGx wXUI1Qqms7/aYiZY6MZO7Pa2s1GHkir/KpAaACmkOBF2kxDfXppeyxMbQGtBacB5ijKb 38wQ== X-Gm-Message-State: AGi0PuZVKHHNh3l/VhqE6Z8VsQICHrwu/Rrop3HF0uNRxrc/wMwDP7NQ v35aT6rm8sva2dWasaXMPudyP9NJrP806OAKqnXvXc8l4D3DriSYLVMyKXE9CS7q8Hu/OJSYXzu g8T7iBKT+u9OaawoisxbJ+Q== X-Received: by 2002:a05:6402:b0d:: with SMTP id bm13mr2983551edb.298.1585836190310; Thu, 02 Apr 2020 07:03:10 -0700 (PDT) X-Google-Smtp-Source: APiQypJEQQXvBiMxqnYsd/ZuLjquIoQzzvL0YKoD1bKz0UuMjPi+bKAdbdLVW5+9PNhH6MT7+9MW/g== X-Received: by 2002:a05:6402:b0d:: with SMTP id bm13mr2983523edb.298.1585836190036; Thu, 02 Apr 2020 07:03:10 -0700 (PDT) Received: from ?IPv6:2001:8a0:f909:7b00:56ee:75ff:fe8d:232b? ([2001:8a0:f909:7b00:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id dj1sm969877edb.70.2020.04.02.07.03.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Apr 2020 07:03:09 -0700 (PDT) Subject: Re: [PATCH 6/7] gdb: select "Cygwin" OS ABI for Cygwin binaries To: Simon Marchi , Simon Marchi , gdb-patches@sourceware.org References: <20200316170845.184386-1-simon.marchi@polymtl.ca> <20200316170845.184386-7-simon.marchi@polymtl.ca> <0b76517a-f6dd-0aa8-17fb-ce5a9accbf42@redhat.com> <9e593882-37cd-c730-9cde-75af5df820c4@efficios.com> Cc: Jon Turney From: Pedro Alves Message-ID: <673bf7c4-4ff2-fb63-f37a-4da961edac68@redhat.com> Date: Thu, 2 Apr 2020 15:03:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <9e593882-37cd-c730-9cde-75af5df820c4@efficios.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Apr 2020 14:03:14 -0000 On 4/2/20 3:01 PM, Simon Marchi wrote: > On 2020-04-02 9:56 a.m., Pedro Alves wrote: >> On 4/1/20 10:53 PM, Simon Marchi via Gdb-patches wrote: >>> However, when BFD maps the file/section data in memory for GDB to read, is that mapping >>> guaranteed to be sufficiently aligned as well? >> >> I think so. If bfd heap allocates, then memory will be aligned to the word size at >> least. If bfd mmaps, then memory will be aligned to page size. And then if the >> data structures are aligned, we should be good. > > Following this message from Tom [1], I'm going to change the code to use > bfd_get_full_section_contents and store the data into a pre-allocated gdb::byte_vector. > Does that change anything? I don't think it does. Thanks, Pedro Alves