Re: [PATCH 1/3] gdb: Update type of lower bound in value_subscripted_rvalue

Tom Tromey
2019-05-06T13:57:33Z

>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:

Andrew> The dynamic lower (and upper) bounds of ranges are stored as type
Andrew> LONGEST (see union dynamic_prop_data in gdbtypes.h). In most places
Andrew> that range bounds are handled they are held in a LONGEST, however in
Andrew> value_subscripted_rvalue the bound is placed into an int.

Andrew> This commit changes value_subscripted_rvalue to use LONGEST, there
Andrew> should be no user visible changes after this commit.

Andrew> gdb/ChangeLog:

Andrew> * valarith.c (value_subscripted_rvalue): Change lowerbound
Andrew> parameter type from int to LONGEST.
Andrew> * value.h (value_subscripted_rvalue): Likewise in declaration.

Thanks, this looks good to me.

Tom