From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2665 invoked by alias); 7 Aug 2019 14:29:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2654 invoked by uid 89); 7 Aug 2019 14:29:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=H*RU:209.85.221.66, HX-Spam-Relays-External:209.85.221.66 X-HELO: mail-wr1-f66.google.com Received: from mail-wr1-f66.google.com (HELO mail-wr1-f66.google.com) (209.85.221.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 07 Aug 2019 14:29:09 +0000 Received: by mail-wr1-f66.google.com with SMTP id g17so91594698wrr.5 for ; Wed, 07 Aug 2019 07:29:09 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id c1sm206216484wrh.1.2019.08.07.07.29.06 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Wed, 07 Aug 2019 07:29:07 -0700 (PDT) Subject: Re: [PATCH 7/8] Remove readline hack from gdb_select To: Tom Tromey , gdb-patches@sourceware.org References: <20190806204334.13441-1-tom@tromey.com> <20190806204334.13441-8-tom@tromey.com> From: Pedro Alves Message-ID: <671c7581-6fd8-7ef5-160b-a583e97ba5fe@redhat.com> Date: Wed, 07 Aug 2019 14:29:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190806204334.13441-8-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-08/txt/msg00175.txt.bz2 On 8/6/19 9:43 PM, Tom Tromey wrote: > As discussed on gdb-patches, this removes the readline hack from the > mingw-hdep.c version of gdb_select. It's believed that this is not > needed any more. I may be hard to find the discussion later on. Please add a link to the discussion to the commit log pointing here: https://sourceware.org/ml/gdb-patches/2019-03/msg00465.html Thanks, Pedro Alves > > 2019-08-04 Tom Tromey > > * mingw-hdep.c (gdb_select): Remove readline hack. > --- > gdb/ChangeLog | 4 ++++ > gdb/mingw-hdep.c | 9 --------- > 2 files changed, 4 insertions(+), 9 deletions(-) > > diff --git a/gdb/mingw-hdep.c b/gdb/mingw-hdep.c > index 8ed4b44ddce..44fb22e9a16 100644 > --- a/gdb/mingw-hdep.c > +++ b/gdb/mingw-hdep.c > @@ -23,7 +23,6 @@ > #include "event-loop.h" > > #include "gdb_select.h" > -#include "readline/readline.h" > > #include > > @@ -167,14 +166,6 @@ gdb_select (int n, fd_set *readfds, fd_set *writefds, fd_set *exceptfds, > } > } > > - /* With multi-threaded SIGINT handling, there is a race between the > - readline signal handler and GDB. It may still be in > - rl_prep_terminal in another thread. Do not return until it is > - done; we can check the state here because we never longjmp from > - signal handlers on Windows. */ > - while (RL_ISSTATE (RL_STATE_SIGHANDLER)) > - Sleep (1); > - > return num_ready; > } > >