From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Se+WIg6tsWmeASQAWB0awg (envelope-from ) for ; Wed, 11 Mar 2026 13:57:34 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=pCI+SL9+; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=pCI+SL9+; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 868031E0DD; Wed, 11 Mar 2026 13:57:34 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C0C291E089 for ; Wed, 11 Mar 2026 13:57:33 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 636594BB3B80 for ; Wed, 11 Mar 2026 17:57:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 636594BB3B80 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=pCI+SL9+; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=pCI+SL9+ Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazlp170120005.outbound.protection.outlook.com [IPv6:2a01:111:f403:c200::5]) by sourceware.org (Postfix) with ESMTPS id 76D294BB3B80 for ; Wed, 11 Mar 2026 17:56:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 76D294BB3B80 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 76D294BB3B80 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c200::5 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1773251818; cv=pass; b=Aj7vy1YxKOSeQ/6P9ICVyYm2vKKyiZTSv4kIQWM2D/RyMudGJFm3ftyeHPziGORFQdUw5WtkhrbsqGqEPnIyPgkLcIBhlRjRSfLNNzQ5jSFiAzzu6fW6jb+VelA9DgauO00H0BbOPYE/6R/TcKXujJXYK0SgXkG3KrJ3wG/9hFY= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1773251818; c=relaxed/simple; bh=0D2JJBa+s+WlVz2mjD/8bsYQvLmLjXmuYonz7SohW74=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=KeUNr8L6iLugXwBb0gjLrq0Ei2NWJCaqF4PsiUa3VYFj80QpkrmlIq+X7oiDITik1m+48V7E4V/d2m5A7oGbIgd4PUJZ9ihw67Q8I4r49qXP8f1vC20ggUpjbk+uwML53HGsxmm7uFsWg72bHBdaj1bJtXFtyzpC3ypoEuNekM8= ARC-Authentication-Results: i=3; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 76D294BB3B80 ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=vSr2xFbEIJVYiSp7RTyvxzMrzz+sJ77xhxZJEshYgnIk8dkVOHFFO3ty73iGSENDz3ZV26cU1sfAHCO4jZk2TiKLfXzVawZ4L2pzrfDscL+ve+PHtZaTIs1wweMUJh21UoMN3NAlBN5ePnkLMmvIJEimaxWXIvPlWNKb8xtYbhU1GKsxPPkt4RlaU7S+E9TafgFDmStUzmerj/DdOn7/MdYaCdutw+V9Yig/P5AU5ALpgAkVFZjXU5fPXm6FY54sAsOHIxb/jjBOcCT5cn+4e84UGNmVnH0p081NYQWU7rF7NMJ54q4wMd2WfUXBCypWxyFEvrZLWg5u0WnWVFmWrQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g2TJRjGEZi0P6tJ8/HYiQ1hvIqD+mlMHGJiqFowZUtU=; b=tlLOr6bW8eF/q9T41bReZSVmPjdiVgC9BkYYBgGi0s4EkE088Piak3hU/4quOKHt2xLyr3XNpvibHurBG5vyy8GADr+d/gKCz1uZAYhkFSADn/s0hTjERQ2x/aFL3AhZVr2w0ZHO2U1Ey6PYnKjErNzLdMU4pBRhlvE2pPfsjGGKkU7wtGaMY0cVXPn8TpFQBvPRWxaMQTZFQTgGJ4UCDULwrOaYU152OytiwWr9o30NLcTjAGAsAY+6HZSfke5qirJzKMIyQo1yInBpvrGFk2TGy8j7TxhwkZjYU73wOM9yWJQDQVdjMMmnfHLri5fwq7c43zP1DyR7ugKr8i5FrQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=simark.ca smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g2TJRjGEZi0P6tJ8/HYiQ1hvIqD+mlMHGJiqFowZUtU=; b=pCI+SL9+SKfkvPp+qj8oMuuJIyH4QQxVFu8/qbX5CEzU1nXDF9x/piSjrZHTky0BNBREPuR9Bad8Ab4v7Wcxalb3Gz27biQ2tfQ6jKAKJVUnKObTpjugmA3/53RJxU8bVqiZP2hrlkxHRTTgQ1YUcYwqUHmpXTb12EKRPHRLoEE= Received: from DUZPR01CA0024.eurprd01.prod.exchangelabs.com (2603:10a6:10:46b::11) by PAWPR08MB11329.eurprd08.prod.outlook.com (2603:10a6:102:50a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9700.12; Wed, 11 Mar 2026 17:56:54 +0000 Received: from DB1PEPF0003922F.eurprd03.prod.outlook.com (2603:10a6:10:46b:cafe::ce) by DUZPR01CA0024.outlook.office365.com (2603:10a6:10:46b::11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9678.26 via Frontend Transport; Wed, 11 Mar 2026 17:56:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by DB1PEPF0003922F.mail.protection.outlook.com (10.167.8.102) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9654.16 via Frontend Transport; Wed, 11 Mar 2026 17:56:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ceqjD2Ld/zA63QRdnjowMp+pEJxj0NQyQCMpkS0xtPEa7KaTzS+BnEmPSJQWfuLlsHjMfMLNm1AHZoRSCvP4LjO/isYprA6vjZmJY6HJWySz40YV5Z6xlNzWcCs7x5Y2piFtXQEiFl6ypydsgF8LlkdV1vMeq+d0lQP9Kw7BZTsz01aS2Rw/yheAR9nbZKpJSaCQUfPc4h9Uu+6fAoS3h/1ZxJcmXQY9k45hmzSq5vbq1/eREwSexXWJm0Xc0f3oAWZWNZCUpTRAtn0ewFZ0lGJfE+bXxEaOnYIf8jJJbPbC6hc55SqsWDkWJAB5QTSnVjgL6xPiUMyssdVK2tEJGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g2TJRjGEZi0P6tJ8/HYiQ1hvIqD+mlMHGJiqFowZUtU=; b=t1b8xxKQ4blL5fg6fmSXUaO7IZ+zsAl/GGPn0bfDG6toFlJnqYDY6b8XIhSNhGPg0nz4Z20D0G5B8Uahcd4YgetpEqEXZ7GnahLhMWzMCp8m5E0K+z002mQbHrJR5I4vSLvV1EIMBNneMo+GTTqhkJhKNHNWzIraSMzFlHuj0DIrkEfOYbbDYGkH+HRoI0ebfqDdLA6F1sAeU+RLzssdzYhs2lFAnlSD8gsctWrza6W+cHF9o5ZBk4Gi43W6R4n6hSu0tuiWMftGhrnxm/6ZWR9IzB++E3hHMLSodAG8PboF8ewSIDWlGY4gmYkZ2xB/PORh3nT1zbO/yP7dCwrPIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g2TJRjGEZi0P6tJ8/HYiQ1hvIqD+mlMHGJiqFowZUtU=; b=pCI+SL9+SKfkvPp+qj8oMuuJIyH4QQxVFu8/qbX5CEzU1nXDF9x/piSjrZHTky0BNBREPuR9Bad8Ab4v7Wcxalb3Gz27biQ2tfQ6jKAKJVUnKObTpjugmA3/53RJxU8bVqiZP2hrlkxHRTTgQ1YUcYwqUHmpXTb12EKRPHRLoEE= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DU0PR08MB8663.eurprd08.prod.outlook.com (2603:10a6:10:401::6) by DU5PR08MB10415.eurprd08.prod.outlook.com (2603:10a6:10:519::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9700.12; Wed, 11 Mar 2026 17:55:51 +0000 Received: from DU0PR08MB8663.eurprd08.prod.outlook.com ([fe80::f957:cec9:ec8d:7968]) by DU0PR08MB8663.eurprd08.prod.outlook.com ([fe80::f957:cec9:ec8d:7968%6]) with mapi id 15.20.9700.010; Wed, 11 Mar 2026 17:55:51 +0000 Message-ID: <6709ef98-2ff2-47d7-b292-9c6b02f5fc05@arm.com> Date: Wed, 11 Mar 2026 17:55:50 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/7] gdb: introduce rgb_color type to simplify existing code To: Simon Marchi , Tom Tromey Cc: gdb-patches@sourceware.org References: <20260309175624.236491-1-matthieu.longo@arm.com> <20260309175624.236491-2-matthieu.longo@arm.com> <87eclsx0xn.fsf@tromey.com> <0762aa68-ad5c-4edc-b1ad-72109e613301@simark.ca> Content-Language: en-US From: Matthieu Longo In-Reply-To: <0762aa68-ad5c-4edc-b1ad-72109e613301@simark.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: PR1P264CA0071.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:2cc::8) To DU0PR08MB8663.eurprd08.prod.outlook.com (2603:10a6:10:401::6) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DU0PR08MB8663:EE_|DU5PR08MB10415:EE_|DB1PEPF0003922F:EE_|PAWPR08MB11329:EE_ X-MS-Office365-Filtering-Correlation-Id: 385bdcce-a324-42e5-b4be-08de7f979439 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; ARA:13230040|366016|1800799024|376014|56012099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info-Original: 5cmSvQjrURGT6ZbxyMjOdYvpjsICICaKx1ZCMBXuKPCH6+ouNRHjPPYIPMeXQ54s29aIJIPuNB70oCsV7FjWYVt41LLUV9vI2Gmo0aNfP5jFdgm7/ugJoYam53sNd0EUF/2Dts+5T+bkYiSpP7BQr/8X3SbMD//XWWhDor4COWWLlir6W+hkohwPuar8PrN/6pqMxClIw/0s2uDZ1r4MWmlpC6u5MM4L3JtNY52ugdahlR0Dbg6Gz+4tE/Z4WSw5ypxmmpRZ3fe3QvMBWKvQEpT3nESPT++Zg6oRMw0vsGSez6bOVpmbacVqTfd7stImdskMEYshIMC7TzDED294q3wMg+U4GhPGL+/lKepJ0pqdu3zhsAOemeLSYghQnMA1cvwLmE5Qz/GNNDrk8pHKAuKInK7Qw1ln/BtUMUfURlXuhQc30Z7UVL54tHeC9wJfeGd09Ac3HA2xxAn9mHQrXKo1eAFdUc51WMtaM6r7K5LdnMuQwKzW+eHahALWT3QLnOERXcXznI7MT+qxQedqPD1i/hU5ptZKBXxShUhZcwJPdl1LxJ3Be7Jl4b+yvdyZWRH63HbreFdThp08DHXv4gvxbfK9gVZkZNtBRlFs838LgO7KZyQIrxpOHnL0oC9P07meR09i/Hbhnc0FR93NAAT6YLiFZJFe+0/mBPa+PXyBVvVh6fOI+78+4HBkT5RU X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR08MB8663.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(56012099003)(18002099003)(22082099003); DIR:OUT; SFP:1101; X-Exchange-RoutingPolicyChecked: qmKsTPA7DBSPMFQsx5SBt7hGoMtyHB0TlmXWqVi6+sWkaPY6KQo4mv8fnjXsE8EcGE5HsvhQ9BTwvFJgFWYkYYXJHxg/IYNGlgW4WfAKMBMLa7WtudUI9UvlMd8K69GkYwesfpu0uoMF+7+ZvykRbpvc0rfvZlOlwLiBBduGicGZimbmY/1YCGlSNqZTXrVsNTT9pN6exU3PvcKjCjQ9TyZEV/6LCqtMNRtKqCSdI6Q7Jrif0qCyJ6oTZX4kU8sfSwIJ7NNWaT2DKa+o+9r3JpX4Sda3w7zDQIZ9Bcb+qlSHVR9Rklg9km8ERKoJVmN//8pr6mWrhOE1bzAnZvoK0Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU5PR08MB10415 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB1PEPF0003922F.eurprd03.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 28d8adc3-0cf6-490d-3226-08de7f976ec8 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|36860700016|376014|14060799003|82310400026|35042699022|13003099007|56012099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: YY5gtOLCKdzepPpWMTfMyO5SOe5sBqdnm9B3KWocZ9jHIQMz9u+58Ft2XVCEucu9vLm128N6dF3v72RGf0SBvVWvUpgMWoRjqJAKhp69pvoa1raJ7ZWglQ4EACXPEpwX0t5CwpKVQrt89FrKzymj/Kq90Jmw+6qW9k+oMhLo99iUDxl+OT1/6c4ipvl0HuTBrkP5cUr1KMSQiy7TM4/CtNTjI7u0ahnoBpW0fTzBROs+rIqfFSgILIkopM8X7w14hadQzo2/2JXI+oy/hKfH6+qJ8klrqsZwAx+XAz8FZUfO4Tt9s/ky10PQiz7fHeGfeTwbFA5m0RaQVAH53AD865zhkInLedjkwu6Yy2tmyPkcJEfdqw70Hgkch1WNiz1MCAEzq4YIMm8yFp3CqfpmdreY0pnMoV0kdgYOuiPxlDQlNkvmGx8tWNk64vRQIvc2JxhZFaCyc6rGXhfMjU+K+0YOkRGm26t1tLR3122W7jJZM/dozjCVjp+qM2tg7EAVsZMTAd+UwEVAyjEqEf7K3FOENW6y63T7UzT3UNKkzmpyaTHVhClz3GkwpxwFmnF/NItTHT89HTCvIIo2qEVYcjd0Rx+xCXVtr7wKfQPvPdx4fNUU5OsjjjuJNu+4VaLmU8OwvHtUTIzrJv5hyAsKrRvZHuqgLKAF4N33s5Brlz5dtuRF3ehMFaThXPKceP4p7AoZSsgo3CBEiDUbqMZjVOF1LTB9ZAyoItZBqs6oaX8= X-Forefront-Antispam-Report: CIP:4.158.2.129; CTRY:GB; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:outbound-uk1.az.dlp.m.darktrace.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(1800799024)(36860700016)(376014)(14060799003)(82310400026)(35042699022)(13003099007)(56012099003)(18002099003)(22082099003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: RN3nPYzRL2wILZ5x1ETPtbyVx7Rst0InzzRsq/jwJo5g24dR7znkKCvouqB0ukB+kLqzrvu7x0dXuWXBz37pV6ocNQSButw41br+Ti2RJcaq6m2J3yNdUao9mw4h/o0vr+RggmzEfQkCdoQZOVT4a7mfZMTANs4TpwPXKjRbrGadpPps+Is8sZ6OxiBUX34GhO3EJsQQ14bSk25C3WsyGu+9gHRSkqUGGedOQ2io7WdJF4uWh3rvEQDklMLWzU5zzvtm5IrnoLPQ7UF+6wfQXINCYTO66FD1kmoIvVIgGGFCAoH0nDfPlm0pMSvKoCUAUMXTtDUeTm2JtaJ1QK8/GDpJWx3dXSl/Fux7mqExyLrcVeBoTghnXmniqg+CBDWvU1xoWjDKtp/IbHocm/XyLB/yts6DpGEAxR5pouhiE+AxWlgDbss6K3CZFop7jxr9 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2026 17:56:53.5807 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 385bdcce-a324-42e5-b4be-08de7f979439 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[4.158.2.129]; Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF0003922F.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB11329 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 11/03/2026 15:03, Simon Marchi wrote: > On 3/9/26 3:22 PM, Tom Tromey wrote: >>>>>>> Matthieu Longo writes: >> >>> This patch replaces the raw uint8[3] buffer used to represent RGB values >>> with a more convenient wrapper, rgb_color, around std::array. >>> It also changes the return type of ui_file_style::color::get_rgb to >>> rgb_color instead of filling a caller-provided buffer, and updates all >>> callers accordingly. >> >> One tiny nit. >> >>> if (target_space == color_space::RGB_24BIT) >>> { >>> - uint8_t rgb[3]; >>> - get_rgb (rgb); >>> - return color (rgb[0], rgb[1], rgb[2]); >>> + return color (get_rgb ()); >>> } >> >> Since there's only one statement now, the braces should be removed. >> >> This is ok with this change. >> Approved-By: Tom Tromey >> >> Tom > > This appears to have caused a build failure on armhf: > > https://builder.sourceware.org/buildbot/#/builders/72/builds/7402/steps/4/logs/stdio > > Sample: > > ../../binutils-gdb/gdb/tui/tui-io.c: In function ‘bool get_color(const ui_file_style::color&, int*)’: > ../../binutils-gdb/gdb/tui/tui-io.c:260:38: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second: [-Werror] > 260 | if (init_color (next, rgb[0] * 1000 / 255, rgb[1] * 1000 / 255, > | ^ > In file included from ./../../binutils-gdb/gdb/ui-file.h:23, > from ./../../binutils-gdb/gdb/defs.h:60, > from : > ./../../binutils-gdb/gdb/ui-style.h:78:22: note: candidate 1: ‘constexpr uint8_t& rgb_color::operator[](std::size_t)’ > 78 | constexpr uint8_t &operator[] (std::size_t idx) noexcept > | ^~~~~~~~ > ../../binutils-gdb/gdb/tui/tui-io.c:260:38: note: candidate 2: ‘operator[](uint8_t* {aka unsigned char*}, int)’ (built-in) > 260 | if (init_color (next, rgb[0] * 1000 / 255, rgb[1] * 1000 / 255, > | ^ > > It seems to be because an rgb_color can be implicitly converted to a > `uint8_t *`, which can be subscripted, but also has an operator[]. > > Not sure why the uint8_t* operator is needed, It was originally required for this line when passing rgb to memcpy(). memcpy (rgb, palette_8colors[m_value], rgb.bytes_size ()); But was later replaced by this assignment: rgb = palette_8colors[m_value]; > but it compiles fine here if I remove it. If really needed, I think that an explicit method > (`.data()`) would be preferable, to avoid unwanted conversions. > > Simon I locally tested the removal of this uint8_t* operator, and the code compiles fine. diff --git a/gdb/ui-style.h b/gdb/ui-style.h index a1d656cd39c..fc40b93709d 100644 --- a/gdb/ui-style.h +++ b/gdb/ui-style.h @@ -72,7 +72,6 @@ struct rgb_color constexpr uint8_t g () const noexcept { return m_data[1]; } constexpr uint8_t b () const noexcept { return m_data[2]; } - constexpr operator uint8_t *() noexcept { return m_data.data (); } constexpr size_t size () const noexcept { return m_data.size (); } constexpr uint8_t &operator[] (std::size_t idx) noexcept Do you want me to publish a patch for this ? Or will you fix it ? Matthieu