From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id DEmpHZwhXWlkRi8AWB0awg (envelope-from ) for ; Tue, 06 Jan 2026 09:52:12 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=i599EOdi; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=gmCfaLvW; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=i599EOdi; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=gmCfaLvW; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 62D771E0B6; Tue, 06 Jan 2026 09:52:12 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 23C331E048 for ; Tue, 06 Jan 2026 09:52:11 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 86D534BA2E2B for ; Tue, 6 Jan 2026 14:52:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 86D534BA2E2B Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=i599EOdi; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=gmCfaLvW; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=i599EOdi; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=gmCfaLvW Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 651B14BA2E04 for ; Tue, 6 Jan 2026 14:51:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 651B14BA2E04 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 651B14BA2E04 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1767711102; cv=none; b=M8R8aEMZHYGuHyoH+BnS17SxLblBYd1x4+9sAwPX3KSQcoBTOTB01Iq0OEKTLsv9lZDU4kQGWo+kSZk5kcvL5PNclk2j3YRi34CEl8kdTvjNHS1IW/Sp5t3p+y7deqsYyLxz0NwWanrTM83d0sjHcebYO63w5HTgd1OlTyXNzsU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1767711102; c=relaxed/simple; bh=etsk2UhEWADQOH3MpehVK0OnIFDoXTZIBHm0PVMFWS4=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=ckdvFlSy1mr0ENpkQKiARGFGxUEYJO7Z1JxNss3MFnEYp6fgFP6ZdlPb/ZgUbaeANfBvJCmrqKwsNzgDKs27E3BOWg67RhHDyH4XM35VaW3OZpdFivIZXdcKBUPUriCm7wHmHbaP4jquBgme/wbWad2hun/AYDt1KTkA7fPEwdE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 651B14BA2E04 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3D96F5BCC5; Tue, 6 Jan 2026 14:51:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1767711101; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O1O6u+xc4irb28kC92LKE+onbyp3rcYS887UBJ8ctOw=; b=i599EOdiZKj+knTB/2Zr5KX4mo4Czi91Wwxt14LNo96xo1zH3wv+qrLHAUrgIZDuKj9LOJ 8mA1OgwQhpsBqdbGMvPVy3zQQXOzeQqB+uc2gr/OIiPx5s9KCArTsfJoRtTSFH/uygLZSR XVPj8zpxiq4L6ayn3Wx00n+krO63D8g= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1767711101; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O1O6u+xc4irb28kC92LKE+onbyp3rcYS887UBJ8ctOw=; b=gmCfaLvW2xiVAmBQp8Jw7wt2eNMS2S2ccoDa+eGi6b/5ZR6lH4ESaKJRiA89Xrr9i3zJMS /rdF+QI5kBIk14CA== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=i599EOdi; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=gmCfaLvW DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1767711101; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O1O6u+xc4irb28kC92LKE+onbyp3rcYS887UBJ8ctOw=; b=i599EOdiZKj+knTB/2Zr5KX4mo4Czi91Wwxt14LNo96xo1zH3wv+qrLHAUrgIZDuKj9LOJ 8mA1OgwQhpsBqdbGMvPVy3zQQXOzeQqB+uc2gr/OIiPx5s9KCArTsfJoRtTSFH/uygLZSR XVPj8zpxiq4L6ayn3Wx00n+krO63D8g= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1767711101; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O1O6u+xc4irb28kC92LKE+onbyp3rcYS887UBJ8ctOw=; b=gmCfaLvW2xiVAmBQp8Jw7wt2eNMS2S2ccoDa+eGi6b/5ZR6lH4ESaKJRiA89Xrr9i3zJMS /rdF+QI5kBIk14CA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 289AE3EA63; Tue, 6 Jan 2026 14:51:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id bYKiCH0hXWlICQAAD6G6ig (envelope-from ); Tue, 06 Jan 2026 14:51:41 +0000 Message-ID: <66de7dbf-d8d4-489f-b2e6-16ed252ffedc@suse.de> Date: Tue, 6 Jan 2026 15:51:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb] Fix heap-buffer-overflow in args_complete_p To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260103145559.2722584-1-tdevries@suse.de> <87jyxwxbdo.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87jyxwxbdo.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_TLS_ALL(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; DWL_DNSWL_BLOCKED(0.00)[suse.de:dkim]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:dkim,suse.de:mid]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received,2a07:de40:b281:104:10:150:64:97:from]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 3D96F5BCC5 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 1/5/26 5:38 PM, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> + auto at = [&] (const char *s) > Tom> + { > Tom> + return s > end ? '\0' : *s; > Tom> + }; > > I think it would better to avoid stepping off the end at the points > where the pointer is incremented. > > Tom> + while (at (input) != '\0') > > Like this could be > > for (input = skip_spaces (input); *input != '\0'; input = skip_spaces (input)) > > and then there's like one or two spots to check in the loop. I've submitted a v2 ( https://sourceware.org/pipermail/gdb-patches/2026-January/223715.html ). I didn't do the transformation you suggested here, I tried to do something minimal. I could submit a follow-up patch to do some refactoring in this function, though I'd likely do something like: ... while (true) { input = skip_spaces (input); if (*input == '\0') break; ... instead of the for loop you're suggesting. Thanks, - Tom