From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 7UWZGh+7G2FfNQAAWB0awg (envelope-from ) for ; Tue, 17 Aug 2021 09:35:27 -0400 Received: by simark.ca (Postfix, from userid 112) id 5DB081EDFB; Tue, 17 Aug 2021 09:35:27 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B971B1EA7E for ; Tue, 17 Aug 2021 09:35:26 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 446E938930D0 for ; Tue, 17 Aug 2021 13:35:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 446E938930D0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1629207326; bh=4zog5yBVwv+Lb+CL38eOAU9G3W1k1VTUPLkacX8heq4=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=sIQv8yenLmQKoEtMAtYT5ciphflgtiseBy2vyEDW48WzkKLZC+wk6FX0E116H60vK 6Wfy3EgfImBRdv0gWPuK3oanbN1e9vGWzIzUQWnEBvAlDuB6GDOGgQpaRBMEftcyTM wGDhjhbU7rNHTzQDsC/9lhpL+kn/jdJ9qe9lzKQ4= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 1111F382CC18 for ; Tue, 17 Aug 2021 13:29:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1111F382CC18 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 17HDSqcP009617 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 Aug 2021 09:28:57 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 17HDSqcP009617 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 8E73D1EA7E; Tue, 17 Aug 2021 09:28:52 -0400 (EDT) Subject: Re: [PATCH 1/3] gdb/solib: Refactor scan_dyntag To: Aaron Merey , gdb-patches@sourceware.org, tom@tromey.com References: <20210812042406.75637-1-amerey@redhat.com> <20210812042406.75637-2-amerey@redhat.com> Message-ID: <6695ada0-2820-56ff-cec3-d185d3f5e966@polymtl.ca> Date: Tue, 17 Aug 2021 09:28:52 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210812042406.75637-2-amerey@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 17 Aug 2021 13:28:52 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-08-12 12:24 a.m., Aaron Merey wrote: > scan_dyntag is unnecessarily duplicated in solib-svr4.c and solib-dsbt.c. > > Move this function to solib.c and rename it to gdb_bfd_scan_elf_dyntag. > Also add it to solib.h so it is included in both solib-svr4 and solib-dsbt. Thanks, this is OK, and I think it can be merged on its own. Simon