Re: [PATCH v3] Implement debugging of WOW64 processes

["Hannes Domani via gdb-patches" <gdb-patches@sourceware.org>]

 Am Mittwoch, 4. März 2020, 20:32:52 MEZ hat Simon Marchi <simark@simark.ca> Folgendes geschrieben:

> On 2020-03-04 2:16 p.m., Hannes Domani via gdb-patches wrote:
> > @@ -99,7 +99,5 @@ void _initialize_amd64_windows_nat ();
> >  void
> >  _initialize_amd64_windows_nat ()
> >  {
> > -  windows_set_context_register_offsets (mappings);
> > -  windows_set_segment_register_p (amd64_windows_segment_register_p);
> >    x86_set_debug_register_length (8);
> >  }
>
> Does x86_set_debug_register_length need to be adjusted based on the type of the
> process?  With the current code, it will be set to 8 even if debugging a WOW64
> process, is that what we want?

I don't really know what this is for, but I haven't had any problem so far like this.

Besides, there is this comment in x86-nat.c:

void
x86_set_debug_register_length (int len)
{
  /* This function should be called only once for each native target.  */
  gdb_assert (x86_dr_low.debug_register_length == 0);
...


Regards
Hannes Domani