Re: [PATCH] Fix indentation (and clang warning) in c-lang.c

Pedro Alves
2019-12-17T19:24:51Z

On 12/16/19 11:50 PM, Simon Marchi wrote:
> On 2019-12-16 6:36 p.m., Simon Marchi wrote:
>> I see this warning when building with clang:
>
> I meant to add the clang version to the commit message, but forgot, I'll
> add it locally. The version is (daily build from apt.llvm.org):
>
> $ clang++-10 --version
> clang version 10.0.0-+20191211091425+f99297176cd-1~exp1~20191211082036.1372

Curious. Are you saying that that changed recently in clang? I wonder
whether clang's warning catches this case on purpose, or whether it's
a regression. I asked David Malcolm, who added that warning to GCC, and he
said that GCC's implementation respects tab stops, so small numbers of
leading spaces before a tab are effectively ignored.

Thanks,
Pedro Alves