From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110413 invoked by alias); 5 Mar 2020 10:21:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 110101 invoked by uid 89); 5 Mar 2020 10:21:35 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-12.1 required=5.0 tests=AWL,BAYES_00,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mail-qk1-f194.google.com Received: from mail-qk1-f194.google.com (HELO mail-qk1-f194.google.com) (209.85.222.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Mar 2020 10:21:34 +0000 Received: by mail-qk1-f194.google.com with SMTP id p62so4729151qkb.0 for ; Thu, 05 Mar 2020 02:21:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=FQCw6J0Sq/4/pWUuzH8Xouw1MFPh8z99DvFyDip5b5w=; b=Immrq7mv9EQiBQOMq+HAG47NxtatosXKT3QN1D7gOyr38XtJtWomSBFRgTjC5/prBZ /Exit1yuuvdC8d81GgaG8G4LiGOiJUr0YVqQUbbUyDOqYVuCk9YoVjTzet0/g8b23tvo cYsGADmokHOIPvzOG0pGB8rCE7/Kx67hMoXjBp36trWxoMSaCdKd7j2lzhATpnGe4DDS 9m8yAgWFbdfRjPY4DF7kOdYTGumVQHZFFpE0twSltK9oc7To5pJVt4O0OFpa+Wt2W9wN inHuJZmLSG4vGVkNym8jp8K3ISW5DCtHircZWoVs9HV6LcjDbGgkeC/wpr9kOhwsJbcp WV0g== Return-Path: Received: from [192.168.0.185] ([191.251.165.48]) by smtp.gmail.com with ESMTPSA id i28sm16276876qtc.57.2020.03.05.02.21.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Mar 2020 02:21:31 -0800 (PST) Subject: Re: [PATCH] Find tailcall frames before inline frames To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20200220155820.22809-1-tromey@adacore.com> <87sgip6rk9.fsf@tromey.com> From: Luis Machado Message-ID: <665eda59-ae52-42f4-b3b2-e3a070036ca8@linaro.org> Date: Thu, 05 Mar 2020 10:21:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <87sgip6rk9.fsf@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2020-03/txt/msg00113.txt Hi Tom, On 3/3/20 6:45 PM, Tom Tromey wrote: > Tom> gdb/ChangeLog > Tom> 2020-02-20 Tom Tromey > > Tom> * dwarf2/frame.c (struct dwarf2_frame_cache) > Tom> Tom> entry_cfa_sp_offset_p> : Remove members. > Tom> (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first. > Tom> (dwarf2_frame_prev_register): Don't call > Tom> dwarf2_tailcall_sniffer_first. > Tom> (dwarf2_append_unwinders): Don't append tailcall unwinder. > Tom> * frame-unwind.c (add_unwinder): New fuction. > Tom> (frame_unwind_init): Use it. Add tailcall unwinder. > > I'm going to check this in now. > > Tom > This has caused quite a few failures in the following tests for aarch64-linux: gdb.opt/inline-break.exp gdb.opt/inline-cmds.exp gdb.python/py-frame-inline.exp gdb.reverse/insn-reverse.exp I see the following: info frame^M ../../../repos/binutils-gdb/gdb/frame.c:579: internal-error: frame_id get_frame_id(frame_info*): Assertion `fi->level == 0' failed.^M A problem internal to GDB has been detected,^M further debugging may prove unreliable.^M Quit this debugging session? (y or n) FAIL: gdb.python/py-frame-inline.exp: info frame (GDB internal error) Resyncing due to internal error. n^M ^M This is a bug, please report it. For instructions, see:^M .^M (gdb) up^M ../../../repos/binutils-gdb/gdb/inline-frame.c:172: internal-error: void inline_frame_this_id(frame_info*, void**, frame_id*): Assertion `frame_id_p (*this_id)' failed.^M A problem internal to GDB has been detected,^M further debugging may prove unreliable.^M Quit this debugging session? (y or n) FAIL: gdb.python/py-frame-inline.exp: up (GDB internal error) Resyncing due to internal error. n^M ^M This is a bug, please report it. For instructions, see:^M .^M I can help get more information on it if you need.