From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30173 invoked by alias); 6 Jul 2009 07:00:35 -0000 Received: (qmail 30154 invoked by uid 22791); 6 Jul 2009 07:00:34 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_93 X-Spam-Check-By: sourceware.org Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (212.99.106.210) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 06 Jul 2009 07:00:28 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 065A129003C; Mon, 6 Jul 2009 09:00:26 +0200 (CEST) Received: from mel.act-europe.fr ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cGnbAF5VWrdC; Mon, 6 Jul 2009 09:00:25 +0200 (CEST) Received: from province.act-europe.fr (province.act-europe.fr [10.10.0.214]) by mel.act-europe.fr (Postfix) with ESMTP id 466F3290019; Mon, 6 Jul 2009 09:00:25 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by filtered-province.act-europe.fr (Postfix) with ESMTP id 22A6F166529; Mon, 6 Jul 2009 09:00:25 +0200 (CEST) Received: from province.act-europe.fr ([127.0.0.1]) by localhost (province.act-europe.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Hy1lF+g0GOXx; Mon, 6 Jul 2009 09:00:24 +0200 (CEST) Received: from [IPv6:::1] (province.act-europe.fr [10.10.0.214]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by province.act-europe.fr (Postfix) with ESMTPSA id 91793166528; Mon, 6 Jul 2009 09:00:24 +0200 (CEST) Cc: gdb-patches@sourceware.org Message-Id: <66568D6F-02DA-426F-8FA5-538F20931289@adacore.com> From: Tristan Gingold To: Joseph S. Myers In-Reply-To: Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v935.3) Subject: Re: [RFA Darwin]: Add push_dummy_call for i386 Date: Mon, 06 Jul 2009 07:00:00 -0000 References: <20090703155152.GA76089@ulanbator.act-europe.fr> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00126.txt.bz2 On Jul 3, 2009, at 6:55 PM, Joseph S. Myers wrote: > On Fri, 3 Jul 2009, Tristan Gingold wrote: > >> Hi, >> >> Darwin i386 ABI is slightly different from the SVR4 one. In >> particular >> stack alignment is 16. As a consquence, i386 Darwin can't use the >> standard >> i386-tdeo.c push_dummy_call and this patch provides a Darwin >> version of this >> call. > > Are there tests in the testsuite (of GDB knowing how SSE vector > arguments > and function returns are handled) that this fixes? (There are such > tests > for AltiVec and e500 vectors, for example.) This example fixes many tests in callfuncs.exp. If gdb calls malloc() (eg to allocate a string) with a wrong stack alignment, the inferior will crash (as it looks like malloc or one of its callees uses sse). That's said, I haven't seen tests for SSE vector arguments/return. Tristan.