From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24721 invoked by alias); 16 Oct 2003 15:45:34 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24708 invoked from network); 16 Oct 2003 15:45:33 -0000 Received: from unknown (HELO gollum.inter.net.il) (192.114.186.22) by sources.redhat.com with SMTP; 16 Oct 2003 15:45:33 -0000 Received: from zaretski ([80.230.156.210]) by gollum.inter.net.il (Mirapoint Messaging Server MOS 3.3.7-GR) with ESMTP id BQE69419; Thu, 16 Oct 2003 17:44:45 +0200 (IST) Date: Thu, 16 Oct 2003 15:45:00 -0000 From: "Eli Zaretskii" To: Daniel Jacobowitz Message-Id: <6654-Thu16Oct2003174019+0200-eliz@elta.co.il> CC: gdb-patches@sources.redhat.com In-reply-to: <20031016131144.GA14202@nevyn.them.org> (message from Daniel Jacobowitz on Thu, 16 Oct 2003 09:11:44 -0400) Subject: Re: RFA: Breakpoint infrastructure cleanups [0/8] Reply-to: Eli Zaretskii References: <3F846B04.2070801@redhat.com> <3F85B4AC.7000000@redhat.com> <20031014013831.GB6118@nevyn.them.org> <3F8C18DD.3020508@redhat.com> <20031014155126.GA10669@nevyn.them.org> <3F8C605E.1060604@redhat.com> <3F8D6181.6070409@redhat.com> <3F8D8FEB.8020305@redhat.com> <16269.39677.813094.890124@localhost.redhat.com> <2719-Thu16Oct2003085405+0200-eliz@elta.co.il> <20031016131144.GA14202@nevyn.them.org> X-SW-Source: 2003-10/txt/msg00543.txt.bz2 > Date: Thu, 16 Oct 2003 09:11:44 -0400 > From: Daniel Jacobowitz > > Show the address always, or for breakpoints which either are in the > middle of a line or in multiple locations? I don't see any problem with this logic. Do you? > I actually think that we do need numbers for them. > > My hypothetical use case is something like this: > (gdb) break inline_foo > Breakpoint 5 set at inline_foo, which has multiple locations. > Say "info breakpoint 5" for more details. > (gdb) info break 5 > Num Type Enb Address What > 1 sw breakpoint y 0x8040222 inlined into foo > 2 sw breakpoint y 0x8040822 inlined into bar > 3 sw breakpoint y 0x8040852 inlined into boring_loop > (gdb) disable 5.3 It's possible to use 5.3, although I'd then expect that number to appear in "info break 5", like this: (gdb) info break 5 Num Type Enb Address What 5.1 sw breakpoint y 0x8040222 inlined into foo 5.2 sw breakpoint y 0x8040822 inlined into bar 5.3 sw breakpoint y 0x8040852 inlined into boring_loop However, I'm also uneasy about "delete 5.3", and in addition I'm afraid that having two sets of breakpoint numbers will mess up things in the long run. So how about the following? (gdb) info break 5 Num Type Enb Address What 5 sw breakpoint y 0x8040222 inlined into foo 5 sw breakpoint y 0x8040822 inlined into bar 5 sw breakpoint y 0x8040852 inlined into boring_loop (gdb) disable 5 *0x8040852 In other words, let's allow the user to specify an optional location in addition to the breakpoint number. We could even use "disable *0x8040852".