From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25492 invoked by alias); 7 May 2004 08:23:15 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25464 invoked from network); 7 May 2004 08:23:10 -0000 Received: from unknown (HELO aragorn.inter.net.il) (192.114.186.23) by sources.redhat.com with SMTP; 7 May 2004 08:23:10 -0000 Received: from zaretski ([80.230.142.26]) by aragorn.inter.net.il (MOS 3.4.6-GR) with ESMTP id CVL24762; Fri, 7 May 2004 11:07:16 +0300 (IDT) Date: Fri, 07 May 2004 08:23:00 -0000 From: "Eli Zaretskii" To: Ulrich Weigand Message-Id: <6654-Fri07May2004110644+0300-eliz@gnu.org> CC: orjan.friberg@axis.com, kettenis@chello.nl, gdb-patches@sources.redhat.com, drow@false.org In-reply-to: <200405062134.XAA05759@faui1d.informatik.uni-erlangen.de> (message from Ulrich Weigand on Thu, 6 May 2004 23:34:10 +0200 (CEST)) Subject: Re: Display of read/access watchpoints when HAVE_NONSTEPPABLE_WATCHPOINT Reply-to: Eli Zaretskii References: <200405062134.XAA05759@faui1d.informatik.uni-erlangen.de> X-SW-Source: 2004-05/txt/msg00186.txt.bz2 > From: Ulrich Weigand > Date: Thu, 6 May 2004 23:34:10 +0200 (CEST) > > Well, the current behaviour of GDB is correct on targets like s390 > that cannot implement target_stopped_data_address, while your suggested > change would break such targets. May I suggest that your change be > implemented conditionally on whether the target supports it? > > > So right now, target_stopped_data_address is almost an alias for > > STOPPED_BY_WATCHPOINT, but it is IMHO wrong to continue this illusion > > into the future. Therefore, I like your patch better than the > > alternative which would modify target_stopped_data_address. > > Actually I didn't suggest modifying target_stopped_data_address. Someone, perhaps not you, posted a patch that uses STOPPED_BY_WATCHPOINT. That was the patch I liked better; I understand that it would work for s390 as well.