From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-137597-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 21902 invoked by alias); 14 Mar 2017 17:13:57 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 21885 invoked by uid 89); 14 Mar 2017 17:13:56 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Mar 2017 17:13:55 +0000
Received: from smtp.corp.redhat.com (int-mx16.intmail.prod.int.phx2.redhat.com [10.5.11.28])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 0410480462;	Tue, 14 Mar 2017 17:13:56 +0000 (UTC)
Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4])	by smtp.corp.redhat.com (Postfix) with ESMTP id 1C6B82D5C1;	Tue, 14 Mar 2017 17:13:54 +0000 (UTC)
Subject: Re: [PATCH v2] inf-ptrace: Do not stop memory transfers after a single word
To: Andreas Arnez <arnez@linux.vnet.ibm.com>, gdb-patches@sourceware.org
References: <m3bmt3eucs.fsf@oc1027705133.ibm.com>
Cc: Simon Marchi <simon.marchi@ericsson.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <6640b187-bad5-a584-73b0-4e151a85fc3c@redhat.com>
Date: Tue, 14 Mar 2017 17:13:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <m3bmt3eucs.fsf@oc1027705133.ibm.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2017-03/txt/msg00241.txt.bz2

On 03/14/2017 03:44 PM, Andreas Arnez wrote:
> Version 1 is here:
> 
>   https://sourceware.org/ml/gdb-patches/2017-03/msg00043.html
> 
> Changes from version 1:
> 
> * "unsigned" -> "unsigned int"
> 
> * Compare pointers with NULL explicitly.

Pedantically, it should be "if (errno != 0)" and
"*xfered_len != 0 ? ...."  as well.

> 
> * Move the ptrace peek/poke loop to a separate routine for better
>   readability.
> 
> OK to apply?

LGTM.

Thanks,
Pedro Alves