Re: [PATCH v2 3/3] gdb/amdgpu: add precise-memory support

Simon Marchi via Gdb-patches
2023-09-14T16:44:29Z

On 9/14/23 12:39, Eli Zaretskii via Gdb-patches wrote:
>> Cc: Simon Marchi <simon.marchi@efficios.com>
>> Date: Thu, 14 Sep 2023 12:14:19 -0400
>> From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
>>
>> gdb/amd-dbgapi-target.c | 173 +++++++++++++++++-
>> gdb/doc/gdb.texinfo | 43 +++++
>> gdb/testsuite/gdb.rocm/precise-memory-exec.c | 44 +++++
>> .../gdb.rocm/precise-memory-exec.exp | 58 ++++++
>> gdb/testsuite/gdb.rocm/precise-memory-fork.c | 41 +++++
>> .../gdb.rocm/precise-memory-fork.exp | 50 +++++
>> .../precise-memory-multi-inferiors.exp | 87 +++++++++
>> .../precise-memory-warning-sigsegv.cpp | 33 ++++
>> .../precise-memory-warning-sigsegv.exp | 45 +++++
>> gdb/testsuite/gdb.rocm/precise-memory.cpp | 32 ++++
>> gdb/testsuite/gdb.rocm/precise-memory.exp | 57 ++++++
>> gdb/testsuite/lib/rocm.exp | 19 ++
>> 12 files changed, 677 insertions(+), 5 deletions(-)
>> create mode 100644 gdb/testsuite/gdb.rocm/precise-memory-exec.c
>> create mode 100644 gdb/testsuite/gdb.rocm/precise-memory-exec.exp
>> create mode 100644 gdb/testsuite/gdb.rocm/precise-memory-fork.c
>> create mode 100644 gdb/testsuite/gdb.rocm/precise-memory-fork.exp
>> create mode 100644 gdb/testsuite/gdb.rocm/precise-memory-multi-inferiors.exp
>> create mode 100644 gdb/testsuite/gdb.rocm/precise-memory-warning-sigsegv.cpp
>> create mode 100644 gdb/testsuite/gdb.rocm/precise-memory-warning-sigsegv.exp
>> create mode 100644 gdb/testsuite/gdb.rocm/precise-memory.cpp
>> create mode 100644 gdb/testsuite/gdb.rocm/precise-memory.exp
>
> Thanks.
>
>> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
>> index 9b7e06f31566..aa3c67788871 100644
>> --- a/gdb/doc/gdb.texinfo
>> +++ b/gdb/doc/gdb.texinfo
>
> This part is OK.
>
> Reviewed-By: Eli Zaretskii <eliz@gnu.org>

Thanks,

Simon