From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id B743F385782F for ; Tue, 1 Sep 2020 14:28:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B743F385782F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 4AD8C1E055; Tue, 1 Sep 2020 10:28:18 -0400 (EDT) Subject: Re: [PATCH] Have partial symbol tables own psymbol vectors To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20200828193304.17475-1-tom@tromey.com> <871rjo7xic.fsf@tromey.com> <87sgc27nez.fsf@tromey.com> <87k0xd7f04.fsf@tromey.com> From: Simon Marchi Message-ID: <6617d4e8-ecc6-976b-56aa-9002372e76ec@simark.ca> Date: Tue, 1 Sep 2020 10:28:17 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <87k0xd7f04.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Sep 2020 14:28:19 -0000 On 2020-09-01 10:23 a.m., Tom Tromey wrote: > Simon> I think it would be a good time to get rid of the objfile > Simon> parameter in the add_psymbol methods. This parameter shouldn't > Simon> be there if the partial symtabs are really objfile-independent. > > Yeah. I have another patch to remove it from end_psymtab_common, but I > didn't look at removing it from the add_psymbol methods. > > I think it's a good idea, but it might be a pain to pipe the object > everywhere it is needed. So I'd prefer to do this as a separate patch. I have toyed with it and I agree. It's more of a long term goal and there are a few little annoying dependencies to remove. So, not for this patch indeed. > Simon> The other use of objfile in partial_symtab::add_psymbol is for > Simon> stats. I think that could be easily implemented some other way > Simon> that doesn't require passing the objfile. > > I feel like the stats are not very useful and could just be removed. I > have never once used them; the bcache already tracks its own efficiency; > and gdb already knows how many psymbols actually exist. I agree. Simon