From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46299 invoked by alias); 28 Apr 2018 21:13:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 46284 invoked by uid 89); 28 Apr 2018 21:13:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=*c, U*$, yacc, o X-HELO: bitwagon.com Received: from bitwagon.com (HELO bitwagon.com) (74.82.39.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 28 Apr 2018 21:13:30 +0000 Received: from f25e64.domain ([67.5.142.41]) by bitwagon.com for ; Sat, 28 Apr 2018 14:13:28 -0700 To: gdb-patches@sourceware.org From: John Reiser Subject: [PATCH] fix race when building ada-lex.c Message-ID: <6612c052-f77e-8650-bdbc-d985f1f10f85@bitwagon.com> Date: Sat, 28 Apr 2018 21:13:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------DC4A33C24F2380E5D7D8A2EC" X-SW-Source: 2018-04/txt/msg00598.txt.bz2 This is a multi-part message in MIME format. --------------DC4A33C24F2380E5D7D8A2EC Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-length: 384 PR build/22873 Prevent a race when building ada-lex.c, and any target of rules .c:.l or .c:.y. The target should be written only at the last step, else SIGINT (^C) can leave an inconsistent state. Being .PRECIOUS makes it even worse. gdb/ChangeLog: * gdb/Makefile.in: (.c:.l, .c:.y): Write the target only in the last step, and do it atomically. [patch attached] --------------DC4A33C24F2380E5D7D8A2EC Content-Type: text/x-patch; name="0001-Fix-race-when-building-ada-lex.c.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Fix-race-when-building-ada-lex.c.patch" Content-length: 2175 >From 66e71c48037729d3239d2fd30dbb92f31281763b Mon Sep 17 00:00:00 2001 From: John Reiser Date: Sat, 28 Apr 2018 13:38:56 -0700 Subject: [PATCH] Fix race when building ada-lex.c PR build/22873 Prevent a race when building ada-lex.c, and any target of rules .c:.l or .c:.y. The target should be written only at the last step, else SIGINT (^C) can leave an inconsistent state. Being .PRECIOUS makes it even worse. gdb/ChangeLog: * gdb/Makefile.in: (.c:.l, .c:.y): Write the target only in the last step, and do it atomically. --- gdb/Makefile.in | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/gdb/Makefile.in b/gdb/Makefile.in index 648f66d..be76928 100644 --- a/gdb/Makefile.in +++ b/gdb/Makefile.in @@ -2483,9 +2483,8 @@ po/$(PACKAGE).pot: force # Makefile.in, but that was a pretty big annoyance. %.c: %.y - rm -f $@ $@.tmp - $(SHELL) $(YLWRAP) $< y.tab.c $@ -- $(YACC) $(YFLAGS) && mv $@ $@.tmp \ - || (rm -f $@; false) + $(SHELL) $(YLWRAP) $< y.tab.c $@.tmp -- $(YACC) $(YFLAGS) \ + || (rm -f $@.tmp; false) sed -e '/extern.*malloc/d' \ -e '/extern.*realloc/d' \ -e '/extern.*free/d' \ @@ -2496,13 +2495,13 @@ po/$(PACKAGE).pot: force -e 's/\([ \t;,(]\)free$$/\1xfree/g' \ -e '/^#line.*y.tab.c/d' \ -e 's/YY_NULL/YY_NULLPTR/g' \ - < $@.tmp > $@ - rm -f $@.tmp + < $@.tmp > $@.new && \ + rm -f $@.tmp && \ + mv $@.new $@ %.c: %.l if [ "$(FLEX)" ] && $(FLEX) --version >/dev/null 2>&1; then \ - $(FLEX) -o$@ $< && \ - rm -f $@.new && \ - sed -e '/extern.*malloc/d' \ + $(FLEX) --stdout $< \ + | sed -e '/extern.*malloc/d' \ -e '/extern.*realloc/d' \ -e '/extern.*free/d' \ -e '/include.*malloc.h/d' \ @@ -2511,8 +2510,7 @@ po/$(PACKAGE).pot: force -e 's/\([ \t;,(]\)free\([ \t]*[&(),]\)/\1xfree\2/g' \ -e 's/\([ \t;,(]\)free$$/\1xfree/g' \ -e 's/yy_flex_xrealloc/yyxrealloc/g' \ - < $@ > $@.new && \ - rm -f $@ && \ + > $@.new && \ mv $@.new $@; \ elif [ -f $@ ]; then \ echo "Warning: $*.c older than $*.l and flex not available."; \ -- 2.9.5 --------------DC4A33C24F2380E5D7D8A2EC--