From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11633 invoked by alias); 14 Jul 2014 10:28:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11281 invoked by uid 89); 14 Jul 2014 10:28:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.1 required=5.0 tests=AWL,BAYES_50,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,RCVD_IN_SEMBACKSCATTER,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2 X-HELO: na01-bn1-obe.outbound.protection.outlook.com Received: from mail-bn1blp0186.outbound.protection.outlook.com (HELO na01-bn1-obe.outbound.protection.outlook.com) (207.46.163.186) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 14 Jul 2014 10:27:58 +0000 Received: from BN1AFFO11FD047.protection.gbl (10.58.52.33) by BN1AFFO11HUB040.protection.gbl (10.58.52.151) with Microsoft SMTP Server (TLS) id 15.0.980.11; Mon, 14 Jul 2014 10:27:54 +0000 Received: from xsj-pvapsmtpgw01 (149.199.60.83) by BN1AFFO11FD047.mail.protection.outlook.com (10.58.53.62) with Microsoft SMTP Server (TLS) id 15.0.980.11 via Frontend Transport; Mon, 14 Jul 2014 10:27:54 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-smtp1) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from ) id 1X6dTg-0005Sy-QP; Mon, 14 Jul 2014 03:27:24 -0700 From: Ajit Kumar Agarwal To: Michael Eager , Joel Brobecker CC: "gdb-patches@sourceware.org" , Pedro Alves , Vinod Kathail , Vidhumouli Hunsigida , Nagaraju Mekala Subject: RE: [Patch, microblaze]: Add support of microblaze software single stepping Date: Mon, 14 Jul 2014 11:42:00 -0000 References: <20140707145634.GF6038@adacore.com> <35bccb81-cae6-4581-b5fd-16dea7171d28@BN1AFFO11FD012.protection.gbl> <20140711135114.GA4888@adacore.com> <53C041BD.4060303@eagercon.com> In-Reply-To: <53C041BD.4060303@eagercon.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-RCIS-Action: ALLOW Message-ID: <65f50a75-1a6c-4c32-8139-296b64e7fe99@BN1AFFO11FD047.protection.gbl> X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:149.199.60.83;CTRY:US;IPV:NLI;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(6009001)(438002)(199002)(189002)(51704005)(24454002)(377454003)(479174003)(77982001)(106116001)(50466002)(76482001)(106466001)(93886003)(1496007)(53416004)(85306003)(99396002)(50986999)(104016003)(77096002)(76176999)(95666004)(33646001)(107046002)(74316001)(54356999)(87936001)(80022001)(86362001)(83072002)(4396001)(74662001)(74502001)(85852003)(31966008)(2656002)(92726001)(92566001)(70736001)(23676002)(20776003)(19580405001)(83322001)(64706001)(79102001)(19580395003)(47776003)(21056001)(81542001)(6806004)(44976005)(46102001)(81342001)(107986001);DIR:OUT;SFP:;SCL:1;SRVR:BN1AFFO11HUB040;H:xsj-pvapsmtpgw01;FPR:;MLV:sfv;PTR:unknown-60-83.xilinx.com;A:1;MX:3;LANG:en; X-OriginatorOrg: xilinx.onmicrosoft.com X-Microsoft-Antispam: BCL:0;PCL:0;RULEID: X-Forefront-PRVS: 02723F29C4 Received-SPF: Pass (: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=ajit.kumar.agarwal@xilinx.com; X-SW-Source: 2014-07/txt/msg00318.txt.bz2 SGVyZSBhcmUgdGhlIGR1bXAgb2YgdGhlIGRpc2Fzc2VtYmx5IGFuZCB0aGUg b3V0cHV0IG9mIHNpbmdsZSBzdGVwIGNvbW1hbmQgZm9yIGJyYW5jaCB3aXRo IGRlbGF5IHNsb3QgYW5kIGltbSBpbnN0cnVjdGlvbnMuDQoNCj4+UGxlYXNl IHByb3ZpZGUgYSBkaXNhc3NlbWJseSBvZiB0aGUgdGVzdCBjYXNlIGFuZCBh IGxvZyBvZiB0aGUgY29tbWFuZHMgdG8gZ2RiIGFuZCBnZGIncyBvdXRwdXQs IHNob3dpbmcgc3RlcHBpbmcgb3ZlciBpbW0gYW5kIGRlbGF5IHNsb3QgaW5z dHJ1Y3Rpb25zDQoNCkJSQU5DSCBXSVRIIERFTEFZIFNMT1QNCg0KQnJlYWtw b2ludCAxLCBtYWluICgpIGF0IC4uL3NyYy9oZWxsb3dvcmxkLmM6MjgNCjI4 CSAgICBpbml0X3BsYXRmb3JtKCk7DQooZ2RiKSBkaXNwbGF5IC9pICRwYw0K MTogeC9pICRwYw0KPT4gMHhjMDAwMDFiMCA8bWFpbisxNj46CWJybGlkCXIx NSwgMTcyCS8vIDB4YzAwMDAyNWMNCihnZGIpIHNpDQppbml0X3BsYXRmb3Jt ICgpIGF0IC4uL3NyYy9wbGF0Zm9ybS5jOjUzDQo1Mwl7DQoxOiB4L2kgJHBj DQo9PiAweGMwMDAwMjVjIDxpbml0X3BsYXRmb3JtPjoJYWRkaWsJcjEsIHIx LCAtMzINCg0KRGlzYXNzZW1ibHkgb2YgbWFpbiA6DQoNCihnZGIpIGRpc2Fz c2VtIG1haW4NCkR1bXAgb2YgYXNzZW1ibGVyIGNvZGUgZm9yIGZ1bmN0aW9u IG1haW46DQogICAweGMwMDAwMWEwIDwrMD46CWFkZGlrCXIxLCByMSwgLTMy DQogICAweGMwMDAwMWE0IDwrND46CXN3aQlyMTUsIHIxLCAwDQogICAweGMw MDAwMWE4IDwrOD46CXN3aQlyMTksIHIxLCAyOA0KICAgMHhjMDAwMDFhYyA8 KzEyPjoJYWRkawlyMTksIHIxLCByMA0KICAgMHhjMDAwMDFiMCA8KzE2PjoJ YnJsaWQJcjE1LCAxNzIJLy8gMHhjMDAwMDI1Yw0KICAgMHhjMDAwMDFiNCA8 KzIwPjoJb3IJcjAsIHIwLCByMA0KICAgMHhjMDAwMDFiOCA8KzI0PjoJaW1t CS0xNjM4NA0KICAgMHhjMDAwMDFiYyA8KzI4PjoJYWRkaWsJcjUsIHIwLCAy NTQ4DQogICAweGMwMDAwMWMwIDwrMzI+OglicmxpZAlyMTUsIDI1MgkvLyAw eGMwMDAwMmJjDQogICAweGMwMDAwMWM0IDwrMzY+OglvcglyMCwgcjAsIHIw DQogICAweGMwMDAwMWM4IDwrNDA+OglicmxpZAlyMTUsIDE5NgkvLyAweGMw MDAwMjhjDQogICAweGMwMDAwMWNjIDwrNDQ+OglvcglyMCwgcjAsIHIwDQog ICAweGMwMDAwMWQwIDwrNDg+OglhZGRrCXIzLCByMCwgcjANCiAgIDB4YzAw MDAxZDQgPCs1Mj46CWx3aQlyMTUsIHIxLCAwDQogICAweGMwMDAwMWQ4IDwr NTY+OglhZGRrCXIxLCByMTksIHIwDQogICAweGMwMDAwMWRjIDwrNjA+Ogls d2kJcjE5LCByMSwgMjgNCiAgIDB4YzAwMDAxZTAgPCs2ND46CWFkZGlrCXIx LCByMSwgMzINCiAgIDB4YzAwMDAxZTQgPCs2OD46CXJ0c2QJcjE1LCA4DQog ICAweGMwMDAwMWU4IDwrNzI+OglvcglyMCwgcjAsIHIwDQoNCldJVEggSU1N IElOU1RSVUNUSU9OOg0KDQooZ2RiKSBzaQ0KbWFpbiAoKSBhdCAuLi9zcmMv aGVsbG93b3JsZC5jOjMwDQozMAkgICAgcHJpbnQoIkhlbGxvIFdvcmxkXG5c ciIpOw0KMjogeC9pICRwYw0KPT4gMHhjMDAwMDFiOCA8bWFpbisyND46CWlt bQktMTYzODQNCjE6IHgvaSAkcGMNCj0+IDB4YzAwMDAxYjggPG1haW4rMjQ+ OglpbW0JLTE2Mzg0DQogKGdkYikgc2kNCjB4YzAwMDAxYzAJMzAJICAgIHBy aW50KCJIZWxsbyBXb3JsZFxuXHIiKTsNCjI6IHgvaSAkcGMNCj0+IDB4YzAw MDAxYzAgPG1haW4rMzI+OglicmxpZAlyMTUsIDI1MgkvLyAweGMwMDAwMmJj DQoxOiB4L2kgJHBjDQo9PiAweGMwMDAwMWMwIDxtYWluKzMyPjoJYnJsaWQJ cjE1LCAyNTIJLy8gMHhjMDAwMDJiYw0KDQo+PklzIHRoZXJlIGEgdGVzdCBj YXNlIHdoaWNoIHNob3dzIHNpbmdsZSBzdGVwcGluZyBmYWlsaW5nIHdpdGhv dXQgdGhlIHBhdGNoPw0KDQpUaGUgc2FtZSBkaXNhc3NlbWJseSB3aXRoIDxt YWluPiBmdW5jdGlvbiBnaXZlbiBhYm92ZSANCldpdGhvdXQgU2luZ2xlIFN0 ZXBwaW5nIGltcGxlbWVudGF0aW9uIHRoZXJlIGlzIGEgd2FybmluZyB3aXRo IHRoZSAid2FybmluZzogUmVtb3RlIGZhaWx1cmUgcmVwbHk6IEUwMSIgIHdp dGggYnJhbmNoIHdpdGggZGVsYXkgc2xvdC4NCg0KKGdkYikgZGlzcGxheSAv aSAkcGMNCjE6IHgvaSAkcGMNCj0+IDB4YzAwMDAxYjAgPG1haW4rMTY+Ogli cmxpZAlyMTUsIDE3MgkvLyAweGMwMDAwMjVjDQooZ2RiKSBzaQ0Kd2Fybmlu ZzogUmVtb3RlIGZhaWx1cmUgcmVwbHk6IEUwMQ0KDQpbVGhyZWFkIDxtYWlu Pl0gIzEgc3RvcHBlZC4NCmluaXRfcGxhdGZvcm0gKCkgYXQgLi4vc3JjL3Bs YXRmb3JtLmM6NTMNCjUzCXsNCjE6IHgvaSAkcGMNCj0+IDB4YzAwMDAyNWMg PGluaXRfcGxhdGZvcm0+OglhZGRpawlyMSwgcjEsIC0zMg0KDQpXSVRIIElN TSBpbnN0cnVjdGlvbiA6IFRoZXJlIGlzIGEgc2FtZSB3YXJuaW5nIHdpdGhv dXQgdGhlIHNpbmdsZSBzdGVwcGluZyBwYXRjaCAgIndhcm5pbmc6UmVtb3Rl IGZhaWx1cmUgcmVwbHkgOiBFMDEiLg0KIA0KDQpbVGhyZWFkIDxtYWluPl0g IzEgc3RvcHBlZC4NCm1haW4gKCkgYXQgLi4vc3JjL2hlbGxvd29ybGQuYzoz MA0KMzAJICAgIHByaW50KCJIZWxsbyBXb3JsZFxuXHIiKTsNCjE6IHgvaSAk cGMNCj0+IDB4YzAwMDAxYjggPG1haW4rMjQ+OglpbW0JLTE2Mzg0DQooZ2Ri KSANCndhcm5pbmc6IFJlbW90ZSBmYWlsdXJlIHJlcGx5OiBFMDENCg0KW1Ro cmVhZCA8bWFpbj5dICMxIHN0b3BwZWQuDQoweGMwMDAwMWMwIGluIG1haW4g KCkgYXQgLi4vc3JjL2hlbGxvd29ybGQuYzozMA0KMzAJICAgIHByaW50KCJI ZWxsbyBXb3JsZFxuXHIiKTsNCg0KVGhhbmtzICYgUmVnYXJkcw0KQWppdA0K LS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCkZyb206IE1pY2hhZWwgRWFn ZXIgW21haWx0bzplYWdlckBlYWdlcmNvbi5jb21dIA0KU2VudDogU2F0dXJk YXksIEp1bHkgMTIsIDIwMTQgMToyOCBBTQ0KVG86IEFqaXQgS3VtYXIgQWdh cndhbDsgSm9lbCBCcm9iZWNrZXINCkNjOiBnZGItcGF0Y2hlc0Bzb3VyY2V3 YXJlLm9yZzsgUGVkcm8gQWx2ZXM7IFZpbm9kIEthdGhhaWw7IFZpZGh1bW91 bGkgSHVuc2lnaWRhOyBOYWdhcmFqdSBNZWthbGENClN1YmplY3Q6IFJlOiBb UGF0Y2gsIG1pY3JvYmxhemVdOiBBZGQgc3VwcG9ydCBvZiBtaWNyb2JsYXpl IHNvZnR3YXJlIHNpbmdsZSBzdGVwcGluZw0KDQpPbiAwNy8xMS8xNCAxMjoz NCwgQWppdCBLdW1hciBBZ2Fyd2FsIHdyb3RlOg0KDQo+DQo+Pj4gUGxlYXNl IGFsc28gZXhwbGFpbiBob3cgdGhpcyBwYXRjaCB3YXMgdGVzdGVkLg0KPg0K PiBUaGUgY2hhbmdlcyB3ZXJlIHRlc3RlZCB3aXRoIHRoZSBhcHBsaWNhdGlv biBmb3IgYmFyZW1hdGVsIHdpdGggcmVtb3RlIGRlYnVnIHdpdGggWE1EIGRl YnVnZ2VyKCBpbnRlcm5hbCB0byBYaWxpbngpd2hpY2ggY29ubmVjdHMgdG8g dGhlIHRhcmdldCBhbmQgb3BlbnMgdGhlIGdkYnNlcnZlciBjb25uZWN0aW9u LiBTaW5nbGUgc3RlcHBpbmcgY29tbWFuZCB3ZXJlIHVzZWQgZm9yIG5leHRf cGMgaW4gc3RyYWlnaHQgbGluZSBjb2RlLCB3aXRoIGltbSBpbnN0cnVjdGlv biBhbmQgdGhlIGJyYW5jaCB3aXRoIGRlbGF5IFNsb3QuDQoNCllvdXIgdGVy bWlub2xvZ3kgbWF5IGJlIGEgYml0IGNvbmZ1c2luZy4gIEdkYnNlcnZlciBp cyBhIHByb2dyYW0gKHBhcnQgb2YgR0RCKSB3aGljaCBydW5zIG9uIGEgcGxh dGZvcm0gKGUuZy4NCkxpbnV4KSwgYW5kIHdoaWNoIGltcGxlbWVudHMgdGhl IEdEQiBSZW1vdGUgU2VyaWFsIFByb3RvY29sLg0KWE1EIGRvZXMgbm90IHJ1 biBnZGJzZXJ2ZXIuICBJdCBoYXMgYW4gaW5kZXBlbmRlbnQgaW1wbGVtZW50 YXRpb24gb2YgdGhlIEdEQiBSZW1vdGUgU2VyaWFsIFByb3RvY29sLiAgSXQg d291bGQgYmUgYmV0dGVyIHRvIHNheSB0aGF0IFhNRCBpcyBhIHJlbW90ZSBz dHViLg0KDQpQbGVhc2UgcHJvdmlkZSBhIGRpc2Fzc2VtYmx5IG9mIHRoZSB0 ZXN0IGNhc2UgYW5kIGEgbG9nIG9mIHRoZSBjb21tYW5kcyB0byBnZGIgYW5k IGdkYidzIG91dHB1dCwgc2hvd2luZyBzdGVwcGluZyBvdmVyIGltbSBhbmQg ZGVsYXkgc2xvdCBpbnN0cnVjdGlvbnMuDQoNCklzIHRoZXJlIGEgdGVzdCBj YXNlIHdoaWNoIHNob3dzIHNpbmdsZSBzdGVwcGluZyBmYWlsaW5nIHdpdGhv dXQgdGhlIHBhdGNoPw0KDQpFdmVuIGJldHRlciB3b3VsZCBiZSB0byB1cGRh dGUgdGhlIGdkYiByZWdyZXNzaW9uIHRlc3Qgc3VpdGUgd2l0aCB0aGUgdGVz dCBjYXNlLg0KDQotLSANCk1pY2hhZWwgRWFnZXIJIGVhZ2VyQGVhZ2VyY29u LmNvbQ0KMTk2MCBQYXJrIEJsdmQuLCBQYWxvIEFsdG8sIENBIDk0MzA2ICA2 NTAtMzI1LTgwNzcNCg== >From gdb-patches-return-114214-listarch-gdb-patches=sources.redhat.com@sourceware.org Mon Jul 14 11:42:59 2014 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 11899 invoked by alias); 14 Jul 2014 11:42:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 11873 invoked by uid 89); 14 Jul 2014 11:42:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 14 Jul 2014 11:42:57 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6EBgiMC000986 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 14 Jul 2014 07:42:44 -0400 Received: from blade.nx (ovpn-116-93.ams2.redhat.com [10.36.116.93]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s6EBggNO030695; Mon, 14 Jul 2014 07:42:43 -0400 Received: by blade.nx (Postfix, from userid 1000) id 005D22640C7; Mon, 14 Jul 2014 12:42:41 +0100 (BST) Date: Mon, 14 Jul 2014 12:03:00 -0000 From: Gary Benson To: Andreas Schwab Cc: Pierre Muller , gdb-patches@sourceware.org, "'Andrew Burgess'" , "'Doug Evans'" , "'Eli Zaretskii'" , "'Florian Weimer'" , "'Mark Kettenis'" , "'Pedro Alves'" , "'Tom Tromey'" , "'Corinna Vinschen'" Subject: Re: Cygwin build failure following [PATCH 3/3 v5] Demangler crash handler Message-ID: <20140714114241.GA31867@blade.nx> References: <20140609152229.GA27494@blade.nx> <20140609152434.GD27494@blade.nx> <000901cf9eb5$16841da0$438c58e0$@muller@ics-cnrs.unistra.fr> <20140714085154.GA27730@blade.nx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00319.txt.bz2 Content-length: 1217 Andreas Schwab wrote: > Gary Benson writes: > > diff --git a/gdb/cp-support.c b/gdb/cp-support.c > > index a8ea6fc..6a09b46 100644 > > --- a/gdb/cp-support.c > > +++ b/gdb/cp-support.c > > @@ -1557,7 +1557,9 @@ gdb_demangle (const char *name, int options) > > #if defined (HAVE_SIGACTION) && defined (SA_RESTART) > > sa.sa_handler = gdb_demangle_signal_handler; > > sigemptyset (&sa.sa_mask); > > +#ifdef HAVE_SIGALTSTACK > > sa.sa_flags = SA_ONSTACK; > > +#endif > > You probably need to initialize sa.sa_flags in any case. Good spot, thanks Andreas. Pierre, I've inlined an updated patch below. Thanks, Gary -- diff --git a/gdb/cp-support.c b/gdb/cp-support.c index a8ea6fc..5464117 100644 --- a/gdb/cp-support.c +++ b/gdb/cp-support.c @@ -1557,7 +1557,11 @@ gdb_demangle (const char *name, int options) #if defined (HAVE_SIGACTION) && defined (SA_RESTART) sa.sa_handler = gdb_demangle_signal_handler; sigemptyset (&sa.sa_mask); +#ifdef HAVE_SIGALTSTACK sa.sa_flags = SA_ONSTACK; +#else + sa.sa_flags = 0; +#endif sigaction (SIGSEGV, &sa, &old_sa); #else ofunc = (void (*)()) signal (SIGSEGV, gdb_demangle_signal_handler);