From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id kPJQJQAadmTW4hgAWB0awg (envelope-from ) for ; Tue, 30 May 2023 11:45:04 -0400 Received: by simark.ca (Postfix, from userid 112) id 898C51E11E; Tue, 30 May 2023 11:45:04 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=HPRLgDN6; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_HI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 906571E0D6 for ; Tue, 30 May 2023 11:45:02 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E1B3B3856965 for ; Tue, 30 May 2023 15:45:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E1B3B3856965 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1685461501; bh=3s70IFY6bjm0fZ89N8hMhofPt+K1Ash8xIA8yfLQEUk=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=HPRLgDN6PBVU2hBSA8doeveJRiQf7aCzpzuUZK09vMrn7AKrsSSAQx1OoQyqfHBHJ /gYDZ8w0bZL2PQRgZLj78AWx7ma5gsXqz0GAoZCqpaFQq59O/+pOFSkkooKDYN6ty8 UIi40DbHDA7INUkPUUL5qhcQQFRmQ0Jtupym3sf8= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 660F03858C00 for ; Tue, 30 May 2023 15:43:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 660F03858C00 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 34UFhbY3018910 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 30 May 2023 11:43:41 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 34UFhbY3018910 Received: from [10.0.0.170] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id C5ECB1E0D6; Tue, 30 May 2023 11:43:36 -0400 (EDT) Message-ID: <65e6cebc-11f2-f531-00c1-8112f6d02704@polymtl.ca> Date: Tue, 30 May 2023 11:43:36 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH] [gdb] Mention --with/without-system-readline for --configuration Content-Language: fr To: Tom de Vries , gdb-patches@sourceware.org References: <20230530093344.12517-1-tdevries@suse.de> <92070c95-9c75-a89b-70ae-695c3a1de219@suse.de> In-Reply-To: <92070c95-9c75-a89b-70ae-695c3a1de219@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 30 May 2023 15:43:37 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 5/30/23 11:41, Tom de Vries wrote: > On 5/30/23 15:36, Simon Marchi wrote: >> On 5/30/23 05:33, Tom de Vries wrote: >>> Simon reported that the new test-case gdb.tui/pr30056.exp fails with system >>> readline. >>> >>> This is because the test-case requires a fix in readline that's present in our >>> in-repo copy of readline, but most likely not in any system readline yet. >>> >>> Fix this by: >>> - mentioning --with-system-readline or --without-system-readline in the >>> configuration string. >>> - adding a new proc with_system_readline that makes this information available >>> in the testsuite. >>> - using this in test-case gdb.tui/pr30056.exp to declare it unsupported for >>> --with-system-readline. >>> >>> Tested on x86_64-linux. >>> >>> Reported-By: Simon Marchi >> >> I confirm this makes the test skipped on my machine. >> >> Once the fix is merged and in a readline release, could we make the skip >> conditional on the readline version? We could have a maintenance >> command or something like that that outputs RL_READLINE_VERSION, and >> skip only for old readline versions. > > We could do that, that sounds useful. > > I also considered printing the readline version string after --with/without-system-readline, but it looked a bit too different to all the other lines. > > Do you want have this implemented before, or are ok with the fix as is? I'm fine with the fix as is: Approved-By: Simon Marchi We just need to remember to do this when the next readline comes out :) Simon