From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55608 invoked by alias); 20 Jun 2017 10:53:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 55593 invoked by uid 89); 20 Jun 2017 10:53:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=H*UA:6.3, H*u:6.3, H*RU:HELO, Hx-spam-relays-external:HELO X-HELO: mga04.intel.com Received: from mga04.intel.com (HELO mga04.intel.com) (192.55.52.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Jun 2017 10:53:48 +0000 Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jun 2017 03:53:46 -0700 X-ExtLoop1: 1 Received: from wtedesch-mobl.ger.corp.intel.com (HELO [10.62.146.24]) ([10.62.146.24]) by FMSMGA003.fm.intel.com with ESMTP; 20 Jun 2017 03:53:44 -0700 Subject: Re: [PATCH 5/5] Add support for Intel PKRU register to GDB and GDBserver. To: Yao Qi References: <1485954205-18536-1-git-send-email-michael.sturm@intel.com> <1485954205-18536-6-git-send-email-michael.sturm@intel.com> <86a85355wz.fsf@gmail.com> Cc: Simon Marchi , "Sturm, Michael" , "mark.kettenis@xs4all.nl" , "palves@redhat.com" , "eliz@gnu.org" , "gdb-patches@sourceware.org" From: "Tedeschi, Walfred" Message-ID: <65548273-a6dc-5b74-f1b2-81d0a92c3a91@intel.com> Date: Tue, 20 Jun 2017 10:53:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <86a85355wz.fsf@gmail.com> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: base64 X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00560.txt.bz2 CgpBbSA2LzIwLzIwMTcgdW0gMTE6MDcgQU0gc2NocmllYiBZYW8gUWk6Cj4g IlRlZGVzY2hpLCBXYWxmcmVkIiA8d2FsZnJlZC50ZWRlc2NoaUBpbnRlbC5j b20+IHdyaXRlczoKPgo+PiBIaSBTaW1vbiwKPj4KPj4gTWljaGFlbCBJIGFt IHRha2luZyBvdmVyIE1pY2hhZWxzIGFjdGl2aXRpZXMuIE1heSBJIHByZXBh cmUgYXMgYW4gb2J2aW91cyBwYXRjaD8KPiBGV0lXLCBUaGlzIHBhdGNoIHNl cmllcyAoYmVpbmcgcmV2aWV3ZWQpCj4KPiAgIFtQQVRDSCAwMC8yNSBWMl0g TWFrZSBHREIgYnVpbHRpbiB0YXJnZXQgZGVzY3JpcHRpb25zIG1vcmUgZmxl eGlibGUKPiAgIGh0dHBzOi8vc291cmNld2FyZS5vcmcvbWwvZ2RiLXBhdGNo ZXMvMjAxNy0wNi9tc2cwMDI5My5odG1sCj4KPiBkZWZpbml0ZWx5IGhlbHBz IHJlZHVjaW5nIHRoZSBudW1iZXIgb2YgeG1sIGZpbGVzIGFuZCBjIGZpbGVz IGFkZGVkIGluCj4geW91ciBwYXRjaC4KPgoKSGkgWWFvLAoKTWF5IGkgYXNr IHlvdSB0byBjcmVhdGUgYSB0ZW1wb3JhcnkgYnJhbmNoIGZvciB0aGlzIHBh dGNoIHNlcmllcy4KTXkgaW50ZW50aW9uIGlzIHRvIGFwcGx5IGFuZCB0ZXN0 IGFyb3VuZCBpbiBzb21lIGNvbmZpZ3VyYXRpb25zIHdlIGhhdmUuCgpUaGFu a3MgYW5kIHJlZ2FyZHMsCi9GcmVkCkludGVsIERldXRzY2hsYW5kIEdtYkgK UmVnaXN0ZXJlZCBBZGRyZXNzOiBBbSBDYW1wZW9uIDEwLTEyLCA4NTU3OSBO ZXViaWJlcmcsIEdlcm1hbnkKVGVsOiArNDkgODkgOTkgODg1My0wLCB3d3cu aW50ZWwuZGUKTWFuYWdpbmcgRGlyZWN0b3JzOiBDaHJpc3RpbiBFaXNlbnNj aG1pZCwgQ2hyaXN0aWFuIExhbXByZWNodGVyCkNoYWlycGVyc29uIG9mIHRo ZSBTdXBlcnZpc29yeSBCb2FyZDogTmljb2xlIExhdQpSZWdpc3RlcmVkIE9m ZmljZTogTXVuaWNoCkNvbW1lcmNpYWwgUmVnaXN0ZXI6IEFtdHNnZXJpY2h0 IE11ZW5jaGVuIEhSQiAxODY5MjgK >From gdb-patches-return-139941-listarch-gdb-patches=sources.redhat.com@sourceware.org Tue Jun 20 10:59:53 2017 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 24477 invoked by alias); 20 Jun 2017 10:59:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 21667 invoked by uid 89); 20 Jun 2017 10:59:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=SYSTEM, UD:dtd, DOCTYPE, doctype X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Jun 2017 10:59:49 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C221B19D37D; Tue, 20 Jun 2017 10:59:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C221B19D37D Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com C221B19D37D Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 29E5C600C2; Tue, 20 Jun 2017 10:59:46 +0000 (UTC) Subject: Re: [PATCH 06/25] Generate c for feature instead of tdesc To: Yao Qi , gdb-patches@sourceware.org References: <1497256916-4958-1-git-send-email-yao.qi@linaro.org> <1497256916-4958-7-git-send-email-yao.qi@linaro.org> From: Pedro Alves Message-ID: Date: Tue, 20 Jun 2017 10:59:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1497256916-4958-7-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00561.txt.bz2 Content-length: 1497 (this is not a full review) On 06/12/2017 09:41 AM, Yao Qi wrote: > +$(FEATURE_CFILES): %.c: %.xml.tmp > + $(GDB) -nx -q -batch \ > + -ex 'maint print c-tdesc $<' > $@.tmp > + sh ../../move-if-change $@.tmp $@ > + rm $< > + > +%.xml.tmp: %.xml > + echo "" > $@ > + echo "" >> $@ > + echo "" >> $@ > + echo " " >> $@ > + if test $(findstring i386/32bit-,$@); then echo "i386" >> $@ ; fi; > + echo " " >> $@ > + echo " " >> $@ > + echo "" >> $@ > + Don't we need move-if-change here? The findstring bits warrants a comment. > +/* THIS FILE IS GENERATED. -*- buffer-read-only: t -*- vi:set ro: > + Original: 32bit-avx512.xml.tmp */ I don't think we should be pointing "Original" at a temporary file that does not exist in the repo? On 06/12/2017 09:41 AM, Yao Qi wrote: > - print_c_tdesc v (filename_after_features); > + if (strncmp (filename_after_features.c_str(), "i386/32bit-", 11) == 0) startswith But again, this looks like needs at least a comment. I'd like to see an expanded rationale for this. It's not immediately obvious why/what's this special casing for. > + { > + print_c_feature v (filename_after_features); > + > + tdesc->accept (v); > + } > + else > + { > + print_c_tdesc v (filename_after_features); > > - tdesc->accept (v); > + tdesc->accept (v); > + } Thanks, Pedro Alves