Re: [PATCH 1/2] Eliminate target_have_continuable_watchpoint

Pedro Alves
2018-08-31T15:40:32Z

On 08/31/2018 04:32 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> target_have_continuable_watchpoint isn't used anywhere so remove it.
> Pedro> The property isn't necessary because checking for "continuable" is the
> Pedro> same as checking for "!steppable && !non-steppable".
>
> Pedro> /* If the *_hw_beakpoint functions have not been defined
> Pedro> diff --git a/gdb/x86-nat.h b/gdb/x86-nat.h
> Pedro> index cc27fa43b4d..f6d8a26baf9 100644
> Pedro> --- a/gdb/x86-nat.h
> Pedro> +++ b/gdb/x86-nat.h
> Pedro> @@ -76,8 +76,6 @@ struct x86_nat_target : public BaseTarget
> Pedro> the one that caused the trap. Therefore we don't need to step
> Pedro> over it. But we do need to reset the status register to avoid
> Pedro> another trap. */
> Pedro> - bool have_continuable_watchpoint () override
> Pedro> - { return true; }
>
> I think the comment just before this function should also be removed.

I thought it was still useful as is. It's describing x86 watchpoints
generically enough before a set of functions implementing watchpoints
support that I thought that it's still positioned in a good place as
is. WDYT?

Thanks,
Pedro Alves