Re: [PATCH 1/2] Eliminate target_have_continuable_watchpoint

Pedro Alves
2018-08-31T17:52:10Z

On 08/31/2018 04:43 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
>>> I think the comment just before this function should also be removed.
>
> Pedro> I thought it was still useful as is. It's describing x86 watchpoints
> Pedro> generically enough before a set of functions implementing watchpoints
> Pedro> support that I thought that it's still positioned in a good place as
> Pedro> is. WDYT?
>
> I looked at that but I didn't understand how the comment related to the
> nearby code; like I didn't see anything else in that file about the
> status register. However I think it's a minor point and if it makes
> sense to you it is fine.

Ah, I was looking more at the bit explaining that the watchpoints
are continuable, so don't need to override target_has_steppable_watchpoint.

I won't miss it myself, so if it isn't helping others, might as well
remove it.

I've done that before pushing the patch in.

Thanks,
Pedro Alves