From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72768 invoked by alias); 11 Dec 2017 13:20:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71342 invoked by uid 89); 11 Dec 2017 13:20:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 11 Dec 2017 13:20:53 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 22C0B25C25; Mon, 11 Dec 2017 13:20:52 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7702E4DC3D; Mon, 11 Dec 2017 13:20:48 +0000 (UTC) Subject: Re: [PATCH v3 3/5] Code cleanup: dwarf2_initialize_objfile return value To: Yao Qi References: <149790572259.20186.14601775821404892582.stgit@host1.jankratochvil.net> <149790575186.20186.4091613230201630619.stgit@host1.jankratochvil.net> <83d5d4a6-a137-b680-1af0-33b895bd817d@redhat.com> Cc: Jan Kratochvil , GDB Patches , Victor Leschuk From: Pedro Alves Message-ID: <653fdb35-4d09-283f-a2a2-cb6b0fb6d000@redhat.com> Date: Mon, 11 Dec 2017 13:20:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-12/txt/msg00230.txt.bz2 On 12/11/2017 01:03 PM, Yao Qi wrote: > This breaks the arm-wince-pe build, > > dwarf2read.o: In function `dwarf2_initialize_objfile(objfile*)': > /home/yao.qi/SourceCode/gnu/binutils-gdb/gdb/dwarf2read.c:6486: > undefined reference to `elf_sym_fns_gdb_index' > /home/yao.qi/SourceCode/gnu/binutils-gdb/gdb/dwarf2read.c:6490: > undefined reference to `elf_sym_fns_debug_names' > /home/yao.qi/SourceCode/gnu/binutils-gdb/gdb/dwarf2read.c:6495: > undefined reference to `elf_sym_fns_lazy_psyms' > collect2: error: ld returned 1 exit status > Makefile:1920: recipe for target 'gdb' failed > > https://ci.linaro.org/job/tcwg-binutils/4395/ > Eh, looks like the bridge was closer than I realized... I forgot the non-elf ports don't include elfread.c in the build. So we really need to do something else here. Maybe an enum instead of the original boolean. Thanks, Pedro Alves