From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108298 invoked by alias); 3 Oct 2017 16:44:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 108285 invoked by uid 89); 3 Oct 2017 16:44:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1564 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Oct 2017 16:44:15 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7632A914F4; Tue, 3 Oct 2017 16:44:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7632A914F4 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id DD1315D9CB; Tue, 3 Oct 2017 16:44:11 +0000 (UTC) Subject: Re: [PATCH v5 2/3] Implement "set cwd" command on GDB To: Sergio Durigan Junior References: <20170912042325.14927-1-sergiodj@redhat.com> <20170929225852.21872-1-sergiodj@redhat.com> <20170929225852.21872-3-sergiodj@redhat.com> <874lrg5goz.fsf@redhat.com> Cc: GDB Patches , Eli Zaretskii From: Pedro Alves Message-ID: <6520ea6a-6be7-db93-1d3e-1b156bc95564@redhat.com> Date: Tue, 03 Oct 2017 16:44:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <874lrg5goz.fsf@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-10/txt/msg00056.txt.bz2 On 10/03/2017 05:39 PM, Sergio Durigan Junior wrote: >> But what if inferior_cwd _is_ NULL, when ... >> >> >>> memset (&si, 0, sizeof (si)); >>> si.cb = sizeof (si); >>> >>> @@ -2514,6 +2527,10 @@ windows_create_inferior (struct target_ops *ops, const char *exec_file, >>> flags |= DEBUG_PROCESS; >>> } >>> >>> + if (cygwin_conv_path (CCP_POSIX_TO_WIN_W, inferior_cwd, >>> + infcwd, strlen (inferior_cwd)) < 0) >>> + error (_("Error converting inferior cwd: %d"), errno); >> >> ... we get here? It looks to me like this conversion should >> skipped here then, and ... > > You're right, this should be skipped. > >>> + >>> #ifdef __USEWIDE >>> args = (cygwin_buf_t *) alloca ((wcslen (toexec) + wcslen (cygallargs) + 2) >>> * sizeof (wchar_t)); >>> @@ -2574,7 +2591,7 @@ windows_create_inferior (struct target_ops *ops, const char *exec_file, >>> TRUE, /* inherit handles */ >>> flags, /* start flags */ >>> w32_env, /* environment */ >>> - NULL, /* current directory */ >>> + infcwd, /* current directory */ >> >> ... here still pass NULL. > > Here we pass NULL because that was the old behaviour when we did not > care about the inferior's cwd. This is the same approach that we use on > fork_inferior: if the user hasn't provided any paths via "set cwd", then > we don't do anything. Exactly, I'm saying that you _should_ pass NULL iff inferior_cwd is NULL. That's what msdn's documentation of CreateProcess says you should pass in order to have the process inherit its parent's cwd. Thanks, Pedro Alves