From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id rTVqJ1HRAmH6RQAAWB0awg (envelope-from ) for ; Thu, 29 Jul 2021 12:03:29 -0400 Received: by simark.ca (Postfix, from userid 112) id 8FE181EDFB; Thu, 29 Jul 2021 12:03:29 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D5EE81E4A3 for ; Thu, 29 Jul 2021 12:03:27 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 23B3B39CE1EA for ; Thu, 29 Jul 2021 16:03:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 23B3B39CE1EA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1627574607; bh=NyRvpiFXIbLva6KHu69IM9hxqMIlDuHNEKehbe56vbs=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=bLtfbj4CBqcr5wydqTWzOzlh8oB6Mxey4lxGvVkoEMZXgDCHR7O3z1gDgkdfEpgoF hmkt97sCxMIOohKvqR5FdUTMycaQQM7JbJCoFNghqpdspiYUNK94PMw9pvvC0dFXoq IddY+VgEB2upozd2l6CjIw8g8t+Svn5AQzG9xFeU= Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by sourceware.org (Postfix) with ESMTPS id 1AA1F3865C2A for ; Thu, 29 Jul 2021 16:03:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1AA1F3865C2A Received: by mail-pj1-x102d.google.com with SMTP id j1so10955220pjv.3 for ; Thu, 29 Jul 2021 09:03:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=NyRvpiFXIbLva6KHu69IM9hxqMIlDuHNEKehbe56vbs=; b=rek6Xjg5gu7+9WAaKqEfyUkhDJOCx7d1cyYnM/KByphNF3g/P+w/comvm9sN714UOb zdfPTKngHZAzaRswTS2fsRRlG0KnIi6vCRSXHBLsxi1eaVS5i6HbVzybFYokA16nfKo2 SnTV/t+QkL2CJNfu2v5QM1OMv1lY738+jDFbce82xkW4aOPc4EEC8OIY6L/bkMmo7739 AfMCyNdBdTVIZHv7V5tTnKNzLBpIrEmqJh6bU+xCF3Apb5LmIazFt7EUeG6gaLj/4YU7 YgQ+jrUCnuK7Ku3AndcriW/5CRWtsug/LkqEZYBtDpbbt+eu6M5yKtNYwChGnm2ML4E7 Te6w== X-Gm-Message-State: AOAM532Vy0GeWP6Cjzts1oI/wQON6lSQYsa0sAvFXUtgsSkVcE/KCAz8 f7p8+wXFArhuiznf0T44/TVMKY4ik37SXg== X-Google-Smtp-Source: ABdhPJzdqIGs+ztXOsXC3aad061aVjz1uKSyYZpov41o5SBc0UnN6zX20jHgJqnQ3G+U2XkADeo/IQ== X-Received: by 2002:a17:90a:e647:: with SMTP id ep7mr15906521pjb.145.1627574584557; Thu, 29 Jul 2021 09:03:04 -0700 (PDT) Received: from ?IPv6:2804:7f0:4841:25bc:8cfb:b520:11df:be05? ([2804:7f0:4841:25bc:8cfb:b520:11df:be05]) by smtp.gmail.com with ESMTPSA id i13sm4125742pfr.79.2021.07.29.09.03.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jul 2021 09:03:03 -0700 (PDT) Subject: Re: [PATCH 2/2] gdb: Enable finish command and inferior calls for _Float16 on amd64 and i386. To: Felix Willgerodt , gdb-patches@sourceware.org References: <20210729083833.2483704-1-felix.willgerodt@intel.com> <20210729083833.2483704-3-felix.willgerodt@intel.com> Message-ID: <64bffa82-0520-d0aa-786b-4d81142b977f@linaro.org> Date: Thu, 29 Jul 2021 13:03:00 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210729083833.2483704-3-felix.willgerodt@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Luis Machado via Gdb-patches Reply-To: Luis Machado Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Hi, On 7/29/21 5:38 AM, Felix Willgerodt via Gdb-patches wrote: > Values of type _Float16 and _Float16 _Complex can now be used on CPUs with > AVX512-FP16 support. Return values of those types are located in XMM0. > Compiler support for gcc and clang is in progress, see e.g.: > https://gcc.gnu.org/pipermail/gcc-patches/2021-July/574117.html Is _Float16 equivalent to fp16? If so, the presence of yet another name for a fp16 type is a bit unfortunate. > > gdb/ChangeLog: > 2021-07-21 Felix Willgerodt > > * amd64-tdep.c (amd64_classify): Classify _Float16 and > _Float16 _Complex as AMD64_SSE. > * i386-tdep.c (i386_extract_return_value): Read _Float16 and > _Float16 _Complex from xmm0. > > gdb/testsuite/ChangeLog: > 2021-07-21 Felix Willgerodt > > * gdb.arch/x86-avx512fp16-abi.c: New file. > * gdb.arch/x86-avx512fp16-abi.exp: New file. > --- > gdb/amd64-tdep.c | 12 ++-- > gdb/i386-tdep.c | 9 ++- > gdb/testsuite/gdb.arch/x86-avx512fp16-abi.c | 38 +++++++++++ > gdb/testsuite/gdb.arch/x86-avx512fp16-abi.exp | 63 +++++++++++++++++++ > 4 files changed, 115 insertions(+), 7 deletions(-) > create mode 100644 gdb/testsuite/gdb.arch/x86-avx512fp16-abi.c > create mode 100644 gdb/testsuite/gdb.arch/x86-avx512fp16-abi.exp > > diff --git a/gdb/amd64-tdep.c b/gdb/amd64-tdep.c > index c028e1bd0f6..129f07e598d 100644 > --- a/gdb/amd64-tdep.c > +++ b/gdb/amd64-tdep.c > @@ -728,10 +728,10 @@ amd64_classify (struct type *type, enum amd64_reg_class theclass[2]) > && (len == 1 || len == 2 || len == 4 || len == 8)) > theclass[0] = AMD64_INTEGER; > > - /* Arguments of types float, double, _Decimal32, _Decimal64 and __m64 > - are in class SSE. */ > + /* Arguments of types _Float16, float, double, _Decimal32, _Decimal64 and > + __m64 are in class SSE. */ > else if ((code == TYPE_CODE_FLT || code == TYPE_CODE_DECFLOAT) > - && (len == 4 || len == 8)) > + && (len == 2 || len == 4 || len == 8)) > /* FIXME: __m64 . */ > theclass[0] = AMD64_SSE; > > @@ -749,8 +749,8 @@ amd64_classify (struct type *type, enum amd64_reg_class theclass[2]) > /* Class X87 and X87UP. */ > theclass[0] = AMD64_X87, theclass[1] = AMD64_X87UP; > > - /* Arguments of complex T where T is one of the types float or > - double get treated as if they are implemented as: > + /* Arguments of complex T - where T is one of the types _Float16, float or > + double - get treated as if they are implemented as: > > struct complexT { > T real; > @@ -758,7 +758,7 @@ amd64_classify (struct type *type, enum amd64_reg_class theclass[2]) > }; > > */ > - else if (code == TYPE_CODE_COMPLEX && len == 8) > + else if (code == TYPE_CODE_COMPLEX && (len == 8 || len == 4)) > theclass[0] = AMD64_SSE; > else if (code == TYPE_CODE_COMPLEX && len == 16) > theclass[0] = theclass[1] = AMD64_SSE; > diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c > index c2835a2458d..6c7f7f7592d 100644 > --- a/gdb/i386-tdep.c > +++ b/gdb/i386-tdep.c > @@ -2818,7 +2818,14 @@ i386_extract_return_value (struct gdbarch *gdbarch, struct type *type, > int len = TYPE_LENGTH (type); > gdb_byte buf[I386_MAX_REGISTER_SIZE]; > > - if (type->code () == TYPE_CODE_FLT) > + /* _FLoat16 and _Float16 _Complex values are returned via xmm0. */ _Float16 > + if (((type->code () == TYPE_CODE_FLT) && len == 2) > + || ((type->code () == TYPE_CODE_COMPLEX) && len == 4)) > + { > + regcache->raw_read (I387_XMM0_REGNUM (tdep), valbuf); > + return; > + } > + else if (type->code () == TYPE_CODE_FLT) > { > if (tdep->st0_regnum < 0) > { > diff --git a/gdb/testsuite/gdb.arch/x86-avx512fp16-abi.c b/gdb/testsuite/gdb.arch/x86-avx512fp16-abi.c > new file mode 100644 > index 00000000000..c5b188ea546 > --- /dev/null > +++ b/gdb/testsuite/gdb.arch/x86-avx512fp16-abi.c > @@ -0,0 +1,38 @@ > +/* Test program for bfloat16 of AVX 512 registers. float16 and not bfloat16, right? > + > + Copyright 2021 Free Software Foundation, Inc. > + > + This file is part of GDB. > + > + This program is free software; you can redistribute it and/or modify > + it under the terms of the GNU General Public License as published by > + the Free Software Foundation; either version 3 of the License, or > + (at your option) any later version. > + > + This program is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + GNU General Public License for more details. > + > + You should have received a copy of the GNU General Public License > + along with this program. If not, see . */ > +#include > + > +_Float16 > +square (_Float16 num) { > + return num * num; /* BP1. */ > +} > + > +_Float16 _Complex > +plus (_Float16 _Complex num) { > + return num + (2.5 + 0.5I); /* BP2. */ > +} > + > +int > +main () > +{ > + _Float16 a = square (1.25); > + _Float16 _Complex b = 6.25 + I; > + _Float16 _Complex ret = plus (b); /* BP3. */ > + return 0; > +} > diff --git a/gdb/testsuite/gdb.arch/x86-avx512fp16-abi.exp b/gdb/testsuite/gdb.arch/x86-avx512fp16-abi.exp > new file mode 100644 > index 00000000000..61cd189a3dd > --- /dev/null > +++ b/gdb/testsuite/gdb.arch/x86-avx512fp16-abi.exp > @@ -0,0 +1,63 @@ > +# Copyright 2021 Free Software Foundation, Inc. > + > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 3 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program. If not, see . > + > +# Test support for _Float16 parameters and return values. > + > +if { [skip_avx512fp16_tests] } { > + unsupported "target does not support AVX512fp16" > + return -1 > +} > + > +standard_testfile > + > +if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} \ > + {debug additional_flags="-mavx512fp16"}] } { > + return -1 > +} > + > +if { ![runto_main] } { > + unsupported "could not run to main" > + return -1 > +} > + > +gdb_test "p square(2.2)" "= 4\\.8359" > + > +set line1 [gdb_get_line_number "BP1"] > +set line2 [gdb_get_line_number "BP2"] > +set line3 [gdb_get_line_number "BP3"] > +gdb_breakpoint $line1 > +gdb_breakpoint $line3 > + > +gdb_continue_to_breakpoint "line1" ".*$srcfile:$line1.*" > + > +with_test_prefix "real" { > + gdb_test "p num" "= 1\\.25" > + gdb_test "ptype num" "type = _Float16" > + gdb_test "finish" "Value returned is.*= 1\\.5625" > +} > + > +gdb_continue_to_breakpoint "line3" ".*$srcfile:$line3.*" > +gdb_test "p plus(b)" "= 8\\.75 \\+ 1\\.5i" > + > +gdb_breakpoint $line2 > +gdb_continue_to_breakpoint "line2" ".*$srcfile:$line2.*" > + > +with_test_prefix "complex" { > + gdb_test "p num" "= 6\\.25 \\+ 1i" > + gdb_test "ptype num" "type = complex _Float16" > + gdb_test "finish" "Value returned is.*= 8\\.75 \\+ 1\\.5i" > +} > + > +gdb_continue_to_end >