From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87083 invoked by alias); 21 Nov 2017 17:22:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 87071 invoked by uid 89); 21 Nov 2017 17:22:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=alright X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 Nov 2017 17:22:18 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9C10B7E380; Tue, 21 Nov 2017 17:22:17 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 401EC5C883; Tue, 21 Nov 2017 17:22:14 +0000 (UTC) Subject: Re: [PATCH 2/2] Don't lose language determined from the "main" name (fix gdb.ada/minsyms.exp) To: Sergio Durigan Junior References: <1511280661-14725-1-git-send-email-palves@redhat.com> <1511280661-14725-3-git-send-email-palves@redhat.com> <87a7zfob1w.fsf@redhat.com> <687c9d8c-25e5-63e0-c506-dfb1ce79f2f9@redhat.com> <87o9nvmu38.fsf@redhat.com> Cc: gdb-patches@sourceware.org, Joel Brobecker From: Pedro Alves Message-ID: <649b534e-2ec2-f89c-f04c-f045580d2bc0@redhat.com> Date: Tue, 21 Nov 2017 17:22:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <87o9nvmu38.fsf@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-11/txt/msg00453.txt.bz2 n 11/21/2017 05:15 PM, Sergio Durigan Junior wrote: > On Tuesday, November 21 2017, Pedro Alves wrote: > >> On 11/21/2017 04:42 PM, Pedro Alves wrote: >>> On 11/21/2017 04:23 PM, Sergio Durigan Junior wrote: >> >>>> Since this is guaranteed to be an stap probe, WDYT about moving this >>>> scoped_restore_current_language to >>>> stap-probe.c:stap_evaluate_probe_argument? This way we won't be bit by >>>> this problem in other parts that also evaluate arguments of probes. >>>> >>>> Arguably, this should be set for every probe type IMHO, but it's fine if >>>> we just do it for stap probes for now. >>> >>> That sounds like a good idea. But we could do it in >>> evaluate_probe_argument then, which handles all probe types? >>> >>> [In your probe C++ification, that translates to evaluate_probe_argument >>> becoming a non-virtual method of probe, which then calls into a >>> protected virtual method that is overridden by the actual probe >>> implementation (see e.g., the do_xxx methods of class ui_out).] >> >> Hmm, maybe what we need instead is to make expression evaluation >> never set the selected frame (and thus language as side effect) >> if it wasn't selected/set already. Like below. This fixes >> the testcase too. I'll run the full testsuite now. WDYT? > > That does look better, indeed. I was trying to think if we'd encounter > any situation where setting the language is on of the desired effects, > but couldn't think of any. Alright, I've sent a v2 now. Thanks, Pedro Alves