From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2610:1c1:1:606c::19:2]) by sourceware.org (Postfix) with ESMTPS id 5892B385E006 for ; Wed, 25 Mar 2020 20:42:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5892B385E006 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=jhb@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 76A9575476; Wed, 25 Mar 2020 20:42:54 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48ng6h140vz49kS; Wed, 25 Mar 2020 20:42:51 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-8.local (unknown [IPv6:2601:648:8881:1e90:715b:27b3:a9e:258d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 8507218039; Wed, 25 Mar 2020 20:42:42 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: [PATCH] Implement nbsd_nat_target::thread_alive To: Kamil Rytarowski , gdb-patches@sourceware.org References: <20200325193646.29248-1-n54@gmx.com> From: John Baldwin Autocrypt: addr=jhb@FreeBSD.org; keydata= mQGiBETQ+XcRBADMFybiq69u+fJRy/0wzqTNS8jFfWaBTs5/OfcV7wWezVmf9sgwn8TW0Dk0 c9MBl0pz+H01dA2ZSGZ5fXlmFIsee1WEzqeJzpiwd/pejPgSzXB9ijbLHZ2/E0jhGBcVy5Yo /Tw5+U/+laeYKu2xb0XPvM0zMNls1ah5OnP9a6Ql6wCgupaoMySb7DXm2LHD1Z9jTsHcAQMD /1jzh2BoHriy/Q2s4KzzjVp/mQO5DSm2z14BvbQRcXU48oAosHA1u3Wrov6LfPY+0U1tG47X 1BGfnQH+rNAaH0livoSBQ0IPI/8WfIW7ub4qV6HYwWKVqkDkqwcpmGNDbz3gfaDht6nsie5Z pcuCcul4M9CW7Md6zzyvktjnbz61BADGDCopfZC4of0Z3Ka0u8Wik6UJOuqShBt1WcFS8ya1 oB4rc4tXfSHyMF63aPUBMxHR5DXeH+EO2edoSwViDMqWk1jTnYza51rbGY+pebLQOVOxAY7k do5Ordl3wklBPMVEPWoZ61SdbcjhHVwaC5zfiskcxj5wwXd2E9qYlBqRg7QeSm9obiBCYWxk d2luIDxqaGJARnJlZUJTRC5vcmc+iGAEExECACAFAkTQ+awCGwMGCwkIBwMCBBUCCAMEFgID AQIeAQIXgAAKCRBy3lIGd+N/BI6RAJ9S97fvbME+3hxzE3JUyUZ6vTewDACdE1stFuSfqMvM jomvZdYxIYyTUpC5Ag0ERND5ghAIAPwsO0B7BL+bz8sLlLoQktGxXwXQfS5cInvL17Dsgnr3 1AKa94j9EnXQyPEj7u0d+LmEe6CGEGDh1OcGFTMVrof2ZzkSy4+FkZwMKJpTiqeaShMh+Goj XlwIMDxyADYvBIg3eN5YdFKaPQpfgSqhT+7El7w+wSZZD8pPQuLAnie5iz9C8iKy4/cMSOrH YUK/tO+Nhw8Jjlw94Ik0T80iEhI2t+XBVjwdfjbq3HrJ0ehqdBwukyeJRYKmbn298KOFQVHO EVbHA4rF/37jzaMadK43FgJ0SAhPPF5l4l89z5oPu0b/+5e2inA3b8J3iGZxywjM+Csq1tqz hltEc7Q+E08AAwUIAL+15XH8bPbjNJdVyg2CMl10JNW2wWg2Q6qdljeaRqeR6zFus7EZTwtX sNzs5bP8y51PSUDJbeiy2RNCNKWFMndM22TZnk3GNG45nQd4OwYK0RZVrikalmJY5Q6m7Z16 4yrZgIXFdKj2t8F+x613/SJW1lIr9/bDp4U9tw0V1g3l2dFtD3p3ZrQ3hpoDtoK70ioIAjjH aIXIAcm3FGZFXy503DOA0KaTWwvOVdYCFLm3zWuSOmrX/GsEc7ovasOWwjPn878qVjbUKWwx Q4QkF4OhUV9zPtf9tDSAZ3x7QSwoKbCoRCZ/xbyTUPyQ1VvNy/mYrBcYlzHodsaqUDjHuW+I SQQYEQIACQUCRND5ggIbDAAKCRBy3lIGd+N/BCO8AJ9j1dWVQWxw/YdTbEyrRKOY8YZNwwCf afMAg8QvmOWnHx3wl8WslCaXaE8= Message-ID: <64888cf7-8aff-20df-db9e-72b911eebc99@FreeBSD.org> Date: Wed, 25 Mar 2020 13:42:40 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200325193646.29248-1-n54@gmx.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-21.5 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Mar 2020 20:42:58 -0000 On 3/25/20 12:36 PM, Kamil Rytarowski wrote: > gdb/ChangeLog: > > * nbsd-nat.h (nbsd_nat_target::thread_alive): Add. > * nbsd-nat.c (nbsd_nat_target::thread_alive): Add. > --- > gdb/ChangeLog | 5 +++++ > gdb/nbsd-nat.c | 30 ++++++++++++++++++++++++++++++ > gdb/nbsd-nat.h | 1 + > 3 files changed, 36 insertions(+) > > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > index 1ee58a541cb..d6789f4d7ca 100644 > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -1,3 +1,8 @@ > +2020-03-25 Kamil Rytarowski > + > + * nbsd-nat.h (nbsd_nat_target::thread_alive): Add. > + * nbsd-nat.c (nbsd_nat_target::thread_alive): Add. > + > 2020-03-25 Tom Tromey > > * compile/compile-object-load.c (get_out_value_type): Mention > diff --git a/gdb/nbsd-nat.c b/gdb/nbsd-nat.c > index 326bbe3aec3..aa0353309df 100644 > --- a/gdb/nbsd-nat.c > +++ b/gdb/nbsd-nat.c > @@ -39,3 +39,33 @@ nbsd_nat_target::pid_to_exec_file (int pid) > return NULL; > return buf; > } > + > +bool > +thread_alive (ptid_t ptid) > +{ > + pid_t pid = ptid.pid (); > + int lwp = ptid.lwp (); > + int mib[5] = {CTL_KERN, KERN_LWP, pid, sizeof (struct kinfo_lwp), 0}; > + size_t size; > + > + if (sysctl (mib, 5, NULL, &size, NULL, 0) == -1 || size == 0) > + perror_with_name (("sysctl")); > + > + mib[4] = size / sizeof (size_t); > + > + gdb::unique_xmalloc_ptr kl > + ((struct kinfo_lwp *) xcalloc (size, 1)); > + if (kl == NULL) > + perror_with_name (("calloc")); > + > + if (sysctl (mib, 5, kl.get (), &size, NULL, 0) == -1 || size == 0) > + perror_with_name (("sysctl")); > + > + for (size_t i = 0; i < size / sizeof (struct kinfo_lwp); i++) > + { > + if (kl.get ()[i].l_lid == lwp) > + return true; > + } > + > + return false; Given that you have nearly identical code both here and in the thread_name method in your other patch, perhaps it makes sense to have a single "gdb::unique_xmalloc_ptr fetch_kinfo_lwp(ptid_t ptid)" helper function that the other routines could share? Perhaps instead of just returning the pointer to the array of structures it could take a lamda function that is invoked on the matching 'kl' instance with the correct lwp? -- John Baldwin