From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22490 invoked by alias); 26 Mar 2010 14:47:36 -0000 Received: (qmail 22482 invoked by uid 22791); 26 Mar 2010 14:47:36 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40 X-Spam-Check-By: sourceware.org Received: from mail-ew0-f227.google.com (HELO mail-ew0-f227.google.com) (209.85.219.227) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 26 Mar 2010 14:47:31 +0000 Received: by ewy27 with SMTP id 27so164312ewy.10 for ; Fri, 26 Mar 2010 07:47:29 -0700 (PDT) MIME-Version: 1.0 Received: by 10.213.109.9 with HTTP; Fri, 26 Mar 2010 07:47:29 -0700 (PDT) In-Reply-To: <20100326141655.GA23473@caradoc.them.org> References: <647fe9b11003260354o53df5f0ayde8d1e3a03f1b694@mail.gmail.com> <20100326141655.GA23473@caradoc.them.org> Date: Fri, 26 Mar 2010 14:47:00 -0000 Received: by 10.213.109.91 with SMTP id i27mr684397ebp.3.1269614849076; Fri, 26 Mar 2010 07:47:29 -0700 (PDT) Message-ID: <647fe9b11003260747i3156003fp642e9ed6ae74d7b5@mail.gmail.com> Subject: Re: [PATCH] winsock include fixes From: Ozkan Sezer To: dan@codesourcery.com Cc: gdb-patches@sources.redhat.com, ktietz70@googlemail.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00890.txt.bz2 On Fri, Mar 26, 2010 at 4:17 PM, Daniel Jacobowitz w= rote: > On Fri, Mar 26, 2010 at 12:54:10PM +0200, Ozkan Sezer wrote: >> Hi: Here is a patch fixing the winsock include problem >> which appeared after the recent winsock header work in >> mingw-w64-headers. > > This patch isn't OK, because it fixes an inclusion order problem by > moving things around without a comment. =A0Everywhere else the > "gdb_XXX.h" headers are included in a group, last. =A0So someone's going > to clean up these files and reintroduce the problem. > > It sounds like part of the problem is the inclusion of winsock2.h in > gdb_select.h, and windows.h in serial.h. =A0Should we include both > headers in both files to avoid the problem? > > -- > Daniel Jacobowitz > CodeSourcery > That may be a solution, too: Inclusion of winsock2.h should be harmless in all cases when USE_WIN32API is defined. -- Ozkan