From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gWrQHx3sr2DsRQAAWB0awg (envelope-from ) for ; Thu, 27 May 2021 14:59:41 -0400 Received: by simark.ca (Postfix, from userid 112) id 72DA11F11C; Thu, 27 May 2021 14:59:41 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 829E51E783 for ; Thu, 27 May 2021 14:59:40 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D0DC03860C37; Thu, 27 May 2021 18:59:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D0DC03860C37 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1622141979; bh=LgPGNUeCm+4yrY+/gtLD6temTALc2vGIPi1mM9xBYKE=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=QkUc6jLNgzPjvQDRuzVsenvkan5expHw6cxttK+GenuBT97KQsm6nrqM3rhAXQHX/ PDWhlXA6S3ontb4JvC8a1d0fV8VxR/WGTY2YudlwghFjL2bxfbTAys4LL40vc9crc1 9fSnoI29o/ZQdn9yyCYD1Ojh2weIztgWzO5rtLDA= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id D1DB2395B818 for ; Thu, 27 May 2021 18:59:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D1DB2395B818 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 14RIxVFq015416 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 27 May 2021 14:59:36 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 14RIxVFq015416 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 38D2C1E783; Thu, 27 May 2021 14:59:31 -0400 (EDT) Subject: Re: [PATCH 0/9] Convert breakpoint iteration macros to ranges To: Tom Tromey , Simon Marchi via Gdb-patches References: <20210527153558.3016335-1-simon.marchi@polymtl.ca> <878s40t562.fsf@tromey.com> Message-ID: <646969a9-7e50-7173-f5d1-fbb3025072e1@polymtl.ca> Date: Thu, 27 May 2021 14:59:30 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <878s40t562.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 27 May 2021 18:59:31 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-05-27 2:14 p.m., Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi via Gdb-patches writes: > > Simon> This all started with me finding that the update_global_location_list > Simon> function was hard to read, notably because the breakpoint iteration > Simon> macros are a bit hard to read (require multiple local variables and > Simon> pointers to pointers). So this removes all breakpoint-related iteration > Simon> macros in favor of functions that return iterable ranges. > > This all looks good to me. I prefer external iteration like this when > possible, as I think it's easier to understand and write. Thank you. > > Tom > Thanks, pushed with the things you pointed out fixed. Simon