From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id /nAvHzYJp2mzoxIAWB0awg (envelope-from ) for ; Tue, 03 Mar 2026 11:15:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1772554550; bh=JvfLWqtzTJtMBq4XLjINpJiP2sZ9xXf3N+24U4r3cIw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=RL7zAfBZurM0JqCpaJXnV9NsdJEQjpZJY2CYmAP7UsAN/qz5943KivDuBigFJ6TCp i4BsmfHLsDCxHg92shW/HpGDBKq69O5ywKk+8K2xezTAJbbcWwQj0RZlJ16OzjyqoY tbl/ujyRTHldFLD4MwUiRLusBRW4C1WqrR2hP1Ik= Received: by simark.ca (Postfix, from userid 112) id 580041E0DD; Tue, 03 Mar 2026 11:15:50 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=sBUVlEd4; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5113A1E089 for ; Tue, 03 Mar 2026 11:15:49 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id E1E6B4BA23C9 for ; Tue, 3 Mar 2026 16:15:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E1E6B4BA23C9 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=sBUVlEd4 Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 9E3CA4BA2E17 for ; Tue, 3 Mar 2026 16:14:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9E3CA4BA2E17 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9E3CA4BA2E17 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772554451; cv=none; b=UCsEE+EG2FwdB1+ICj+npUlaz6QkMD8ZiAgrn+wRL3BVXv0u9e4xzbUhG4SWnljr7uv8IWvpiIbIBL5CbjiPSPd4mmdVJONAgkSCFyS/nTCGQXFMK5325wjKWlJuhmtfFGDZszhC1hLu+BjmE1J2HeqL9jg/63iWbeTS/r0h8mI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772554451; c=relaxed/simple; bh=JvfLWqtzTJtMBq4XLjINpJiP2sZ9xXf3N+24U4r3cIw=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=frsmPwnpKU0wP+zjnDLAU6Wo5wZnbbfCRg23VZSv8n13CNO5x3GLxdrC+sj6O0sNCsXHCacj0Eg96qQLb03o4505klKQLcUPExMVjJSx8MlcNnO+wsFws3Kl+tFszCziXrD8gzuVX5xFFnojXBwACRofxlQC4jbdAMLN/KQwBus= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9E3CA4BA2E17 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1772554450; bh=JvfLWqtzTJtMBq4XLjINpJiP2sZ9xXf3N+24U4r3cIw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=sBUVlEd4aBL35Dqzk6kDurLFD9Bkea5k/ImOwvJGhXf9YyBU1HD9LBEiSlbu24Eox fU7lPsHTaCURQRyhTUul0MCvXyH6qCBPiRCM1zg99uTH7n0nxpeIiPSBHHD6Sw6zg9 zQ2Dbex82O9xYxT6QyqCh5ospnl2RaaNZWoMNB7A= Received: by simark.ca (Postfix) id D35DC1E089; Tue, 03 Mar 2026 11:14:08 -0500 (EST) Message-ID: <643ff55e-b906-40e0-aef9-847b1af9a7c1@simark.ca> Date: Tue, 3 Mar 2026 11:14:08 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/6] GDB: aarch64-linux: Some header fixes To: Thiago Jung Bauermann , gdb-patches@sourceware.org Cc: Chris Packham , Luis , Tom Tromey , sunilkumar.dora@windriver.com References: <20260303050641.198127-1-thiago.bauermann@linaro.org> Content-Language: en-US From: Simon Marchi In-Reply-To: <20260303050641.198127-1-thiago.bauermann@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-03-03 00:06, Thiago Jung Bauermann wrote: > v4 adds two new patches, reorganizing MTE and SME definitions. > > With this series, I think the AArch64 definitions are correctly organized > between the headers in gdb/arch/ and gdb/nat/. > > if the series is approved I will propose a version of the last patch for > the GDB 17 branch which doesn't depend on the previous patches, so that the > build failure on aarch64-linux-musl can be fixed with minimal changes. > > I didn't include Luis' Approved-by to patches, since they have some changes > in them. > > I also build-tested this version on aarch64-freebsd14.3 in addition to > aarch64-linux-gnu and aarch64-linux-musl. > > Previous versions of the patches: > > v1: https://inbox.sourceware.org/gdb-patches/20260211045853.1436881-1-thiago.bauermann@linaro.org/ > v2: https://inbox.sourceware.org/gdb-patches/20260214045504.361392-1-thiago.bauermann@linaro.org/ > v3: https://inbox.sourceware.org/gdb-patches/20260217060106.1906312-1-thiago.bauermann@linaro.org/ I skimmed the code and read the commit messages, it looks good to me, but I will leave Luis give the approval. Thanks for the cleanup, I think things are organized in a systematic and predictable way now. Here are some things that copilot had to say, I checked and they seemed true: - gdb/nat/aarch64-pauth-linux.h: HWCAP_PACA is defined unconditionally, unlike every other HWCAP fallback in the series (HWCAP2_MTE, HWCAP2_FPMR, HWCAP2_SME, HWCAP_GCS) which all use #ifndef guards. On any modern aarch64 Linux system HWCAP_PACA is already defined by , so including this header after any header that pulls it in will cause a redefinition error. Wrap it in #ifndef HWCAP_PACA / #endif. (Simon: not sure it will necessarily be a error, I think it's possible to redefine macros if they have exactly the same value, but still it would be good to add the #ifndef.) - FPMR: the commit message appears to be a copy-paste of the pauth one that wasn't updated — it references AARCH64_HWCAP2_FPRM, HWCAP2_FPRM, and gdb/arch/aarch64-pauth-linux.h / gdb/nat/aarch64-pauth-linux.h, when all four should refer to the FPMR variants. (Simon: notice the FPRM -> FPMR typos in there) - GCS: the commit message says "create gdb/nat/aarch64-gcs-linux-ptrace.h" but the file actually created is gdb/nat/aarch64-gcs-linux.h. Simon