From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4F9lAnIFiGazihwAWB0awg (envelope-from ) for ; Fri, 05 Jul 2024 10:38:42 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=OowkCL/k; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id EBC411E0C3; Fri, 5 Jul 2024 10:38:41 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BF1141E030 for ; Fri, 5 Jul 2024 10:38:39 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1CFB63885C33 for ; Fri, 5 Jul 2024 14:38:39 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 187853886C40 for ; Fri, 5 Jul 2024 14:38:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 187853886C40 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 187853886C40 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1720190298; cv=none; b=bgccz3bTNL+Mmy6C5GOcEnCZtdcpOwKy+NHV7qV1oF1oMXwEdTQg5PXZf3kLfZ6oF7DO0z3amsSe/nyVej8Z3sisdaGqmlPKdBfGuISs3c3l28lC1SRMFk/CqoTjVi90jldqtGSK+nfIYP/3u18un7UjoLkuH6R2125KSv8NQjM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1720190298; c=relaxed/simple; bh=wbwXXTooyDiNM+Hx3VeQF2Wu77gqzYE9MC0dUDAU0fU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=vNS8UyVdmuP/CCUwfE035ylTtCWEkpSCjPA3AYSJfSFp39ZxZabfP/jXWtuja60xmHMRBCNbAlPyzqNxO9YwwhpM0Q10ouVYb6E6Wvm6R+5PGaFizEhUICW4Qri13NdRhF31JOi1W+PPKoFFf3AsRtUUqEoAtKjPKV8JnPsF1DM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720190296; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=odqOXZgXlpKs7LYI96StkmvHxphNOtn3ZcEa0kXLUJs=; b=OowkCL/kGHPBDs/V0Ze6eAaJLMn7V7U9zaAPIOwHF3oUVQ4Qxd5xJk/8Y9Zdd1IjtROPeK 7cqzY3DwRk+AI++EQaJFadxZyGRsn5E0np6STkNu6F++U3rm89C0veaU5BGTp4GtlH9GG4 WoLonAWEVcaLrZmiaHMDdcQfltNwOxc= Received: from mail-oa1-f71.google.com (mail-oa1-f71.google.com [209.85.160.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-513-8BaoCWO9N1ylcjnIbvHw-w-1; Fri, 05 Jul 2024 10:38:15 -0400 X-MC-Unique: 8BaoCWO9N1ylcjnIbvHw-w-1 Received: by mail-oa1-f71.google.com with SMTP id 586e51a60fabf-25e072af01aso1556920fac.1 for ; Fri, 05 Jul 2024 07:38:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720190295; x=1720795095; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=odqOXZgXlpKs7LYI96StkmvHxphNOtn3ZcEa0kXLUJs=; b=bBWTmROpO782l1n8KSJ6bHF3r1O+zn0wlHTZNEhYpSdjKWVzGqcUtNQxZ3L7JjEwB8 aEiNrBBiWa16qqE9nTHwVTWeYp5HBXVAFPDmtDcwQU4obpAq2jHolBaCrgx4FSnEFYql 3z4jJeFuM+a3ysBYW3t9F44L4YA4Hf6St1pKa1nfXiNruF6vrfdMnKv847511POhYCOw rQoct5VRd6gZdAzcp4XyE1BR3lbYsVZqxojS+apbejM7RdOsGXvKy+FmaFZgn6oS8tkD /FgXxdMGpeqoxoDreesZGdlOxjjKDA/TpwFFKr3Fs2Ijd7ehpfGHKe1YoYtshjCbcetO exEQ== X-Forwarded-Encrypted: i=1; AJvYcCV3CeS5c7EU903odXLK8PQUew4il7zniYK60CA6sTVRULNDkJ7T1QCjGiYTmCa6sTj0f6nuMWs70K0lOaNNFCK/qf51h+Qs7bViFQ== X-Gm-Message-State: AOJu0YzoH7o/D5H6dd1xBFi0Uws/W8hYD5Fai85Ie4cyshGGDNKQNOFX cwJdFwL6CTz+bl4SVEsBbn7x7hk9KjLrWtiMDj3f6yBtCr9sJiwMTyAIbdd1qKBDdhEjbuwLvcy 7p9B+MXnBEv/ONoIdng/YlUx8Ff7yqn7HINw7BPOlc8smLm1SBUfYaOVdpf4= X-Received: by 2002:a05:6871:891:b0:254:8908:4281 with SMTP id 586e51a60fabf-25e2beb1181mr3967562fac.44.1720190294696; Fri, 05 Jul 2024 07:38:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGrDcA9FOvci2s0eBK6As4EpfIUAuMDZzRJF1HK3vi4GTzcgZrQLAP2mUiN9J2v3nBRaHsFlA== X-Received: by 2002:a05:6871:891:b0:254:8908:4281 with SMTP id 586e51a60fabf-25e2beb1181mr3967555fac.44.1720190294301; Fri, 05 Jul 2024 07:38:14 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:92c5::1001? ([2804:14d:8084:92c5::1001]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70b0932343asm2182633b3a.141.2024.07.05.07.38.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Jul 2024 07:38:13 -0700 (PDT) Message-ID: <6436e55a-eedd-4c15-9ea1-693cf3680cee@redhat.com> Date: Fri, 5 Jul 2024 11:38:11 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] gdb: fix "frame function" failure to get frame when call is it's last instruction To: Sahil , gdb-patches@sourceware.org Cc: Sahil Siddiq , "Eli Zaretskii (eliz@gnu.org)" References: <20240704163348.67304-1-sahilcdq@proton.me> <4933009.GXAFRqVoOG@valdaarhun> From: Guinevere Larsen In-Reply-To: <4933009.GXAFRqVoOG@valdaarhun> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 7/5/24 11:23 AM, Sahil wrote: > Hi, > > Thank you for the review. > > On Friday, July 5, 2024 6:36:52 PM GMT+5:30 Guinevere Larsen wrote: >> [...] >> I have tested, it fixes the issue reported and adds no regressions! I >> have a minor nit inlined, but with that fixes, feel free to add my git >> trailer to the commit message: >> >> Reviewed-By: Guinevere Larsen >> >> I hope a maintainer approves this for pushing soon! >> >> [...] >>> diff --git a/gdb/testsuite/gdb.base/frame-selection.exp >>> b/gdb/testsuite/gdb.base/frame-selection.exp index e8d9c87c3a..4333f6a2d1 >>> 100644 >>> --- a/gdb/testsuite/gdb.base/frame-selection.exp >>> +++ b/gdb/testsuite/gdb.base/frame-selection.exp >>> @@ -63,7 +63,7 @@ proc check_frame { level address function } { >>> >>> set re [multi_line \ >>> >>> "Stack level ${level}, frame at ($address):" \ >>> >>> - ".* = $hex in ${function} \(\[^\r\n\]*\); saved .* = $hex" \ >>> + ".* = $hex in ${function}( \(\[^\r\n\]*\))*; saved .* = $hex" \ >> This looks like a spurious change. I removed the change and everything >> works. >> >> There's no need to send a new version for just this change though, just >> fix it locally and apply my review tag :) >> > Since this is my first time contributing to gdb, I am a little unsure > about what comes next. > > My understanding is that a maintainer will respond to this thread > with an "Approved-By" tag and then I'll be able to push this patch > to the repository with the "Reviewed-By" and "Approved-By" tags > appended in the commit message. Is this correct? > > Thanks, > Sahil > > If you have completed the copyright assignment process, yes that's exactly it. If you haven't, you'll need that finished before being allowed to push, since I think the changes to the testcase would be considered legally significant. I'm not sure if you should start the assignment process yet, since the patch hasn't been approved. Eli (CC'd because of this question), should Sahil start the assignment process already, or wait for someone to approve their patch first? -- Cheers, Guinevere Larsen She/Her/Hers