From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id cUMnGycX62mQWjgAWB0awg (envelope-from ) for ; Fri, 24 Apr 2026 03:09:27 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=NMdSmTrc; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 6541B1E0BA; Fri, 24 Apr 2026 03:09:27 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A74AA1E067 for ; Fri, 24 Apr 2026 03:09:22 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 422E34BB24D2 for ; Fri, 24 Apr 2026 07:09:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 422E34BB24D2 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=NMdSmTrc Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by sourceware.org (Postfix) with ESMTPS id 01DC14BA23C0 for ; Fri, 24 Apr 2026 07:08:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 01DC14BA23C0 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 01DC14BA23C0 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::433 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777014535; cv=none; b=rdcTaGJvIQNyLR/bD7SWZAZW0Xw9hOBUeSyTaleWDM61Ddm9SLbYwN1LO/ZdARemxVrXKdgnZCbR+lpTf95m3eeqWKcJNVHUkYJJIOwX1yve+8FDcL5sqCgCYaT1aVMQHULOjEmTBPc4BaXbXSwkhH7fo4VAki+TV9ar+m6FYjI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777014535; c=relaxed/simple; bh=pC7zjDW8F7KO1xzRKLIT6NXB5JMpvYZYiYqaKbLc/lo=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=IGE5n44TH3KNj31hNKk0T1LfM0LIRbrWlNeaeUwsrhkxlEyycducrADpiyIavsKEpRJGjXF85cFxvgdHvPy++DzM/6gA3CSggn61IQDSTTH5VQ8vHfqz4ZHmRj2EsrAp8OwHk1duPKoqDKQBLzcNWjiwH+1TAsY3pTIn7GHwHPs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 01DC14BA23C0 Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-43d7e23defbso4530913f8f.0 for ; Fri, 24 Apr 2026 00:08:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777014534; x=1777619334; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WGpve0y3OpUsJ0Scf98sIUVf1XoV/mEgw/9wVMBguHw=; b=NMdSmTrcOx2+vMv4FmzkxDillRYYe7Ce6U8YQ34brxKleYzNBl5Wc0Fr3n/kQ+xxiU U74bXWfIMiwV/y/iTdUMF0KW7q2mMZbcdSiSzPhbyHXO3cTiKg+SLfPBIOM7Mg7NiXsF ttaSMQStQBjO4UEW2MDfROtg2x3IsiFc4cQSDu05ojdrtpw5Pq/xFnK8yQVsYIr2dGkY uJey/OALC5Ikl9VgMarojrsD6Z7WZfhsMaVkW+RMf3rker1G4N8rimvRNRaL8Avarbod xMCR3cHqzNVUVcHltLmDkhGQuV/diTEFEQTiQi75yZQyZYLlgGO50y/bWoAjzzCUNp5t PdYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777014534; x=1777619334; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WGpve0y3OpUsJ0Scf98sIUVf1XoV/mEgw/9wVMBguHw=; b=pW2b4tvRR+SGPPnaXZwbQZXLOUTrZUDqU2rhPRy4ZZkiGwNEreSD9LHFa6Nw3a9LtU HMvNGkQaF+Oltq5pYqFjhez8mzRpQGv9xN2X9pP1uMfVB1z5Ulj0M+yPnQEUBjzbZfwI OsGd74H8FrxgrFGHezoN3rCAnu/GCaHJTpbdbvhSnHflBwXqs7dL30i72LoeC61HOUZe GVccLq/fI+MXyX0rPswK9dbzev0yITRxJgokXG1YQAI8kGGUe88/o20bEAi/Ea4avZSI 7CH/Ghja34YZM7MXb1LPfcZEkhRJAsxz8EYr1UMXShYboU1XCs8OumXdA/SDb1XoqwKl 4HjQ== X-Forwarded-Encrypted: i=1; AFNElJ+Zve96zFhhhG6idR/kqJGQaPSJES9PY0979bVlzLCNE5K7NfiGJfR6NZp2ohQacE6WLEjt3DEVai0ncw==@sourceware.org X-Gm-Message-State: AOJu0YzbIekH5qEN6GIawTQtVHt6FnZ++UK7H3we5BJ2Mne2tZpYeqvu ATxWswkJP7DouG3WTt+/z1MC1LNuoGFAY2GMzkVBqyR5xBTJCzBW/20Y X-Gm-Gg: AeBDieucS8wULXsWaS1Hq4Esn2+SdTw++bEBJEKmBi49iLG9FLrWXiipYcFBSqhYODP 65pFhQmYCpPtuUjI9FpsGA12lru2kpyvqPrFVcPBJr1FvormdxqwLuGAKYsQXxJ8GhsxSe0hWY6 XJYngtY/p3t0ppdefOBlu+sKiQ1sg38GiZXgeU6bgJwQbqlHCfHmn0pzU/lUP6vxLt9VfBzApdY EG5gsbjWAPboHU5gtJ1fyupj0hp7oJ98eNY9MPbfRLdyoWPOoz9PvqoYMpNlEBlTF1PQl8tQTJY KMZb8jNq97zwWx7pbuohZ8r59z7AkcxvvcC3L1F8F0I+5qXmJ6OrJWjmyRMN4n/mbcHfiHMaxdo /ClXt/KfF9O/PCZuvGZ6L3i2yaeQvpduuRg/e78e0fzAEOLtTSCIh+SrvFWvYdhyAQj56vCiz9u FDoM0f9vT84wuF0oBPiuNHLFOHBYbuEBiA0KwJlQ71eT4bblI= X-Received: by 2002:a05:6000:1788:b0:43e:b0dd:396b with SMTP id ffacd0b85a97d-43fe3dfd58bmr46014078f8f.25.1777014533545; Fri, 24 Apr 2026 00:08:53 -0700 (PDT) Received: from [192.168.0.38] ([86.12.216.189]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4cc375dsm52306657f8f.14.2026.04.24.00.08.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Apr 2026 00:08:53 -0700 (PDT) Message-ID: <642894a2-99ce-45c1-8acf-2fed8c285a44@gmail.com> Date: Fri, 24 Apr 2026 08:08:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] gdb/aarch64: record/replay support for RPRFM and PRFM (reg) Content-Language: en-US To: Ezra.Sitorus@arm.com, gdb-patches@sourceware.org Cc: thiago.bauermann@linaro.org References: <20260420215232.68675-1-Ezra.Sitorus@arm.com> <20260420215232.68675-4-Ezra.Sitorus@arm.com> From: Luis In-Reply-To: <20260420215232.68675-4-Ezra.Sitorus@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 20/04/2026 22:52, Ezra.Sitorus@arm.com wrote: > From: Ezra Sitorus > > The PRFM (register) instruction variant was unsupported. This is added > along with RPRFM. > > No testcase has been added as these are hint instructions which don't > modify registers/memory. I'm happy to add them in if you think these are > required. > > The full testsuite was done on aarch64-none-linux-gnu without RPRFM. > The gdb.arch and gdb.reverse tests were run on Shrinkwrap with RPRFM > support. I've observed unrelated regressions that appear to be due to > Shrinkwrap rather than my patch. > --- > gdb/aarch64-tdep.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c > index 81d4f160f8f..61c462979b3 100644 > --- a/gdb/aarch64-tdep.c > +++ b/gdb/aarch64-tdep.c > @@ -5914,6 +5914,11 @@ aarch64_record_load_store (aarch64_insn_decode_record *aarch64_insn_r) > else > if (size_bits != 0x03) > ld_flag = 0x01; > + else if (size_bits == 0x3 && vector_flag == 0x0 && opc == 0x2) > + { > + /* PRFM (register) or RPRFM */ > + return AARCH64_RECORD_SUCCESS; > + } > else > return AARCH64_RECORD_UNKNOWN; > Thanks. This is OK. Approved-By: Luis Machado