From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id t4IuE0zPc2LldgQAWB0awg (envelope-from ) for ; Thu, 05 May 2022 09:21:16 -0400 Received: by simark.ca (Postfix, from userid 112) id 421E51E086; Thu, 5 May 2022 09:21:16 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=QIDJLNI9; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9FB1D1E048 for ; Thu, 5 May 2022 09:21:15 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D9A5F384B0C9 for ; Thu, 5 May 2022 13:21:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D9A5F384B0C9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1651756874; bh=1qKTCcStXucaFJzTceCZybYDV/in/ZUbKGg5p69fPUk=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=QIDJLNI9HDHMWDviEHyezIBCYucnbjfwHN3Dea0MOT74x3/mKYugK9ENE9JBPUViv lMbHLgEZRVz/IllnjvSJ5wqP6w0NUvQMk/Hxi8/k7IEvJC+mXTtogS/Fq3XkOSKadK lGyxe+hfVxYa3Of65TU8HvRVGja7YPUeOpPG4NjU= Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 8E608385735C for ; Thu, 5 May 2022 13:20:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8E608385735C Received: from [172.16.0.95] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 8B9691E00D; Thu, 5 May 2022 09:20:53 -0400 (EDT) Message-ID: <6420bb1d-2660-ff8d-c1bd-b0392cb65295@simark.ca> Date: Thu, 5 May 2022 09:20:52 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH][gdb/tdep] Support catch syscall pipe2 for i386 Content-Language: tl To: Tom de Vries , gdb-patches@sourceware.org References: <20220503145732.GA26729@delia.home> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: Sergio Durigan Junior Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > [gdb/tdep] Support catch syscall pipe2 for i386 > > With test-case gdb.base/catch-syscall.exp and target board unix/-m32, we run > into: > ... > (gdb) catch syscall pipe2^M > Unknown syscall name 'pipe2'.^M > (gdb) FAIL: gdb.base/catch-syscall.exp: determine pipe syscall: catch syscall pipe2 > ... > > Fix this by: > - adding a pipe2 entry in gdb/syscalls/i386-linux.xml.in, and > - regenerating gdb/syscalls/i386-linux.xml using > "xsltproc --output i386-linux.xml apply-defaults.xsl i386-linux.xml.in". The patch LGTM, assuming this is the right number for pipe2 :). I suppose we are missing more syscalls than that, given that new syscalls are added regularly, e.g. rseq: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d7822b1e24f2 As long as rseq is not listed in this file, it means a user wouldn't be able to use "catch syscall rseq", I suppose? We would need a procedure to add new syscalls periodically. Could we add a simple Makefile (as a separate patch) that contains these xslt commands? I think you searched a little bit how those files were originally generated, so it would be nice to save the trouble in the future. Simon