Re: [RFA] Make test names unique in python.exp and guile.exp

[Pedro Alves <palves@redhat.com>]

On 6/23/20 10:56 PM, Simon Marchi wrote:
> On 2020-06-23 5:43 p.m., Pedro Alves wrote:
>> On 6/23/20 10:32 PM, Simon Marchi wrote:
>>> On 2020-06-23 4:51 p.m., Philippe Waroquiers via Gdb-patches wrote:
>>>> +	if {[gdb_test_multiple $input "$name - $input" {
>>>> +	    -re "\[\r\n\]*($result)\[\r\n\]+($gdb_prompt | *>)$" {
>>>> +		pass "$name - $input (input nr $inputnr)"
>>>
>>> The test name passed as the second argument of `gdb_test_multiple` and the test
>>> name passed to `pass` should match.  This is why the special variable $gdb_test_name
>>> was added, to avoid potential mismatches.  You can use "pass $gdb_test_name" inside
>>> the gdb_test_multiple body.
>>
>> Text within the "(xxx)" at the end is considered informational, not
>> part of the test name, though.  That's why we avoid trailing parens
>> in general.  So in this case they do match.  Just like these match:
>>
>>  PASS: foo
>>  FAIL: foo (timeout)
>>
>> Still a good idea to write:
>>
>>  pass "$gdb_test_name (input nr $inputnr)"
>>
>> though.
> 
> But here we want to use $inputnr to really differentiate the names of
> the tests, because $input is a command to execute.  So if two commands to
> execute are "end", we would end up with
> 
>   PASS: something - end (input nr 0)
>   PASS: something - end (input nr 1)
> 
> which would be wrongfully considered as the same test.  So I think we need
> inputnr to be part of the test name, not in parenthesis.  Maybe
> 
>   $name: input $inputnr: $input
Hmm, yeah.  I didn't realize that command issues a PASS for each of the
the lines.  That looks good to me.

Thanks,
Pedro Alves