From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120320 invoked by alias); 18 May 2018 21:04:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 120310 invoked by uid 89); 18 May 2018 21:04:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 spammy=Ie, stubs X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 May 2018 21:04:32 +0000 Received: from ESESSHC005.ericsson.se (Unknown_Domain [153.88.183.33]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id 68.E2.01293.EDF3FFA5; Fri, 18 May 2018 23:04:30 +0200 (CEST) Received: from ESESSMB503.ericsson.se (153.88.183.164) by ESESSHC005.ericsson.se (153.88.183.33) with Microsoft SMTP Server (TLS) id 14.3.382.0; Fri, 18 May 2018 23:03:35 +0200 Received: from ESESSMB503.ericsson.se (153.88.183.164) by ESESSMB503.ericsson.se (153.88.183.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Fri, 18 May 2018 23:03:35 +0200 Received: from NAM01-BN3-obe.outbound.protection.outlook.com (153.88.183.157) by ESESSMB503.ericsson.se (153.88.183.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Fri, 18 May 2018 23:03:35 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.48.114] (192.75.88.130) by DM6PR15MB2393.namprd15.prod.outlook.com (2603:10b6:5:8d::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.776.11; Fri, 18 May 2018 21:03:33 +0000 Subject: Re: [PATCH 04/10] remote: multiple remote_arch_state instances per arch To: Pedro Alves , References: <20180516141830.16859-1-palves@redhat.com> <20180516141830.16859-5-palves@redhat.com> From: Simon Marchi Message-ID: <63fa731e-35a6-700f-c544-220b92decd06@ericsson.com> Date: Fri, 18 May 2018 21:09:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180516141830.16859-5-palves@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SN4PR0501CA0141.namprd05.prod.outlook.com (2603:10b6:803:2c::19) To DM6PR15MB2393.namprd15.prod.outlook.com (2603:10b6:5:8d::27) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);SRVR:DM6PR15MB2393; X-Microsoft-Exchange-Diagnostics: 1;DM6PR15MB2393;3:rPfxTG8Q+WHiOuRXxAgwTN32fXiiPHTq+xqWrzoM9yeChfNL91fV3XiK87Br6yUg0WCbg4ShfmPyYXnJWxpO/vko6LgTmIE2yBiqfdP0aGzM72CA+gAdo/w3enJzddwZcqzztxGg5Z3RUsS1XQgX1ygOx05PETNJ+1pLhHq2buBMyeDgXeiUQbv1+umiDVWjQaqMLZWBtOc0gX7KX+JCvdVNO33O048DoJwXEx35gplx4sLHRlCMKXrA277vJgkj;25:3NuTt5nPN7AU+0gRIXrfDNy98Ox77pu6S4l5gwH9qumlDgDPDqlseLbW2G7cWexPlfayzqu5Jndsrh/zN45m4QoD+HpA0LIWaz7FIGYXE2P1XjOWTPVnE0mjwWvo+hPhXZD0DrwREWiYm8/CfQEyJpGsJjt95/QUuFLQo2pDsvGXXIadWeeiDPsQaM9wxpfBfj0iofvGqroBgUax4CakzG69gaWeNgqCUzdnG6tsWOGfWZioQ3ftJdNNlU8ISn7VpFNnMjkml0KsGmnZm/anrqdoXr2PzKj8Cd16yco3hJCPIToZ+hlFZc47xcGlXNlk9PzwCsWTB44y4uNq6yNnQg==;31:5NvtikokHMfDkmT60yNEi0RMG2Gpy9aaxwU2hrQpIPJ5Jx0blBes+ArW8ZI5FdN3b1flD0Yh4kf327+aY+zl0kQGBAK5SwOyn8lCJsKEYTJmjr9bK14MscuDB+O0NR0ApmXsc26aHpyu5nmUKVha0zu1PQiJZGNJWy1v5URpRLnz9vq5xuikrHwLk4J2Uee92ZunBNlXLsDLsTVaJrjLwlJ63v+BMh1OuU0gYGKpmx4= X-MS-TrafficTypeDiagnostic: DM6PR15MB2393: X-Microsoft-Exchange-Diagnostics: 1;DM6PR15MB2393;20:QVjvrlXrOBXK7iwTauQYawIg27Jze5W2+kSgl+ngTtMFJUIewXTld1pIVwL8IvFkrST11iaPdahYFpiw0vaf/p4xsUXbmNvDBYy6mwZNSv741bLKIh01gVPr6gR3EGCSVtFpT4cmjmM6jpQqJiqD2I66GqEJzAxN/qi9b4DphbHy4GNa7IUcJwRvrghLiGJu+oV7S+eOjDg6khugbOWyOhK1/bDEFWI7y1mc3CgfOvA+5JvmqHJZbHWuV2HgDVLWztM1txu3W1mCG70XPJksqNnxcJNA6xYWxwPFiEzRmYYL7IzlisUtt+NOfYCRT0SNXslGvq9ab6JR+rAcmktId7Z2uTzMb9Oim6V4gMNXhMz6WMbzu3dkmjsZDeixSwp8zK9xpXzV/dAZq1V2Nfrw5wkD/7cGKwzzXqAqAAkha5coSvnTZFaT8hDhez36HdqBd6Zc9MreM9WwxEBnk+yYWlFyY8rZM78fjXO1uCMfhxUFf0xArgLyK6v2qQmBpKoK;4:Fv7rjGxihV1bc/RXLcUgo8kaWrfoG38JjEZwii/BwgPL8pLgiZaML9izf57V8sEe3/bVMjViR4f7hjwLgFXmz1vtQ54ltC/DOliZmb2KEU/BqgLnmu2HgU7fdnPnlqCjP/TzYzIPxvdgWzZPIU49aaj64eE2aKHLGpCMU4u5hwvpgKbXSwPb2Vl/u+PiGrBFbVHNQKo868S7dGm5K8xe2JBbRPU2U0ftalcpn3XcVRpH/RJM5owwhVCvYCN1/6BjyYoE10QKg3/ckeNymnuyHw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231254)(944501410)(52105095)(149027)(150027)(6041310)(20161123560045)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011)(7699016);SRVR:DM6PR15MB2393;BCL:0;PCL:0;RULEID:;SRVR:DM6PR15MB2393; X-Forefront-PRVS: 0676F530A9 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(376002)(39860400002)(346002)(396003)(366004)(39380400002)(189003)(199004)(377424004)(86362001)(2906002)(58126008)(8936002)(446003)(31686004)(6666003)(81156014)(44832011)(11346002)(3846002)(8676002)(6116002)(81166006)(64126003)(53936002)(6486002)(478600001)(316002)(31696002)(16576012)(6246003)(229853002)(25786009)(5660300001)(65826007)(2616005)(68736007)(26005)(50466002)(97736004)(476003)(66066001)(65806001)(386003)(106356001)(486006)(105586002)(305945005)(956004)(16526019)(36756003)(47776003)(65956001)(186003)(2486003)(7736002)(49976009)(52146003)(230700001)(23676004)(76176011)(53546011)(52116002)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:DM6PR15MB2393;H:[142.133.48.114];FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTZQUjE1TUIyMzkzOzIzOnF3aW5RS3ZENlYzNDZ4cDhzdENwWTRGTi8v?= =?utf-8?B?ajZOU09wTFBWcDhlSjBqMHA1SGhsQ0dNNEZLN3ErTXRaVjhPNXY4c1pDMnVK?= =?utf-8?B?UEhGVUhnRHpKNnZCcUhFQ1FLRWxCbG5Nb0VCTTlVTVJLT1IvL1VUbktqM0Mz?= =?utf-8?B?WjloeE1nRmNuSnJISWZySjVSOWRFaVY3S0dTWm8ycEh1VjVIZTFLZGlpSDJy?= =?utf-8?B?d2dRU1lTOVZXdmN1ZE9BZjNVaTkxa0VGR3kzR2pYbElacXJVVVlwQzBXLzBF?= =?utf-8?B?RGpwOHR5eS9kVFdsOHZJWU14V2U4SXlkWnpMelpDQ1Z6d29XNWxhcytzNkw4?= =?utf-8?B?Q2o2Z3dva1N5WmdVTUFhVWJKd3FvZktTWW1ZTFBlU1pzVWFiWTQ4d3Vhdjg4?= =?utf-8?B?bENUeGNYZFp4YlZYS3pURWtDSFZCa2xVaXZpNVBjRXAwMU5RL05ITlUwWjZG?= =?utf-8?B?azkwS0tZV2orRnFJUWFwdjgvUWQyMUdHUTZyQ1FlcTJmZEF0UlpTT1F3WXdR?= =?utf-8?B?bkNqVEE4d2JZQWtJYjB6a3E1SUwvMGVSQXZXWjhmdEJGYS9INjM3L2YycEVP?= =?utf-8?B?YlpwVFljdEJ6TWVOcjh6ODRUeHA5Y25LamN1b0Z0QWxEVTFGN0MyZmxyYTl5?= =?utf-8?B?NFRJd2lNS2pJRm9sVkxBQ3phTW0rVWpNTGgvS3hxdFd6cWUyQ2VLR3p3cnQ4?= =?utf-8?B?SlZuMHQ3cmRpYUQ0OWd2b2tHYUNvZUl5R092aXhSemlHWlBJMi9vNFlNYjQr?= =?utf-8?B?VnN0MkZmdTYvbXFKV29tNWVhTDk1ZTdJbzlMYUNuck1aSnNIaVhadnpndzQr?= =?utf-8?B?eUpkVndJZW1uVnRiYUdCSGFhbVR0QVl4V0xzNkEyVHFHbXVzYmVtVGptWTdv?= =?utf-8?B?eW8xb3A0QXpTVFFBUkRwSm4wS091eFZDQVJCdXoyeXkwNUxnNEtNa0hsWFJO?= =?utf-8?B?OG1leFpzdlF0dC9oYnFFSklIRU5RL0hDNHovSCtlZFlkT1F2RW50TEZGcXZp?= =?utf-8?B?NGRYc2dTbVZqVStqVlFlTHdqWTB3OE5ROHlNVUJyc0dvMWZiL09paXhGMEF2?= =?utf-8?B?amRZeHNrVTBpVUQrODF2dXE0VVNnSlM2T3UrUUhFOElXVlg1YTY1cnZ3ZHRy?= =?utf-8?B?TDR4Ykh4aUNyZ3FNZmtLejFFRVNtalQ1U0FvY05Fd0pmeE1YQlRVem5MMlhH?= =?utf-8?B?TlpWUGhJUFVBcFVvQStZSkhjU09MTkpEbFN5VDRVc1JGUHc5TG95ZnVsQkdX?= =?utf-8?B?Qk5lb2xYcmtrZXBReWgrQTRpZXdTd05QNENLRE45V2h1L2lJWlJZVEVHblUz?= =?utf-8?B?N0hvV3RzK1ArOXIrVGRvQ2pibXBPVXYxblhEMXNJSHlOdjN1Ti90N0M4bGty?= =?utf-8?B?YXZtVXl1YUhlK05ZcXhXQnZML3NTK0VVeXprRXZIcWdPbUs2d2wxbzh5dzZv?= =?utf-8?B?R21UWkM1R2QyV0dXb1FhejljU3lRODBYQXlNTXpnSzc4YzFsTVFzcWFxZkZ5?= =?utf-8?B?NHlpOEcrMzh5WWFleVF2WDk2cXQ1cFV1YWtVV3Z4cC9makZyRVJFejh2NHQ4?= =?utf-8?B?dWZ1blZyRUdHZVNjcXdSbzFMSHVCZDVzTVJkYjN2cUFLYVpiY2dOMXVzTXQ2?= =?utf-8?B?a0xNZFpEMkpVbWtiSG5DcWFmYlZpUE02WUFqbDZpNjdEOXRCM1JXVXRqd0J3?= =?utf-8?B?NTdhZmtzOFNIdXZldWtGd0JBODRsdzZwTlR5eGpXUVp5VEJjQnBObE5rWldE?= =?utf-8?B?Q05pTjFLa1JHQ2ZRREdpUklUWFRYTW8zdHFTazhDc1MyS2hYN2FVT3lxUHRQ?= =?utf-8?B?WkJBL1J0MUplQXljTElHVTJxaFRsZy9WTHRidUE3VnlLWkNxNTlNRS8vZHpu?= =?utf-8?B?ZUIwNFZhaGRiNGpjQ0s2VUIrTEFtTnRGUTlCeVZpd2JxZi9PQ0ZKZzFSUVpF?= =?utf-8?Q?cE2bPRGagN/GFXTg+c0H8ggiCG7EXk=3D?= X-Microsoft-Antispam-Message-Info: elctO07b7YA2oLZ+ZhrFMJi2uiDp51ys9nUqKF0PzfeOLe3/egdXdfZGijkh6Fgxc/AH/4p+MUfWWV4pjcIpwHrn09YmlYosS7CRitRab2eY5CH8kGq2nN6Rrx0dkTPoXbW1Rk5mayf4tIzPs/3hKJHI+XoGecb5hdU3BuOiqSDpGLJsZZ92ANZRxK/5dQJj X-Microsoft-Exchange-Diagnostics: 1;DM6PR15MB2393;6:fNAcO4MZhImfWzCIdtNuY/qDXkOMxwETbtl1AUYhJXKMZoKnKNiWe2+n/3MzPgieX57pTlWNf8rgzoxkHMlZmcuNyz1ykDKnfNzZu3GJzERgyzE/jhF28oNhyYTY1F/CCjOBh16l6p+HbScpyj9wMaM/Vtmc/5ISE3whMRV8c3AJmqdsBRnOGyJyp//5VeCRFd80WxV2yklAokdxOwxeV1xatq3k48L2jLrirbR7aNDqcCFDD5MBNVTKrdlDdzf9j7oxOGstg4X5MoJ2Z7Iux1pD1k2Y/sJk7kNggO6P+J179in3olr4CSt7f3ayrqnZWldD7a1qpAzplPCblGn87Vb3dzigDPvusk6NTUcaVre05Hvx7WHY8IJLyD1QClcYupBCjHPoZznwS5qThlVlrBhGSIuwvx9lJW3loh8VRgHOyNnZbf6S6h53GjkTwV/uGOW5083uSa5b3/ZzdRWOcw==;5:HOnHydEJpjMqeQMVhDVIetBbStdzQQptjBRgM2Ia2V1ceUfFF/1EoyUDCt1gqP6GZfJjxjJnXD9ZNUZ7dpmZCc4M8fC/dzPmzth3RjEpQFKV7jkBHg4o366XVGM/NjieaB04Vkmoy7DVFWWABoJ+yq/ZD0F5sGwjPT9XJBCtpPo=;24:oCeYWLSLd7LYWJtS79YJZXCksC0Tqf9veQNAwKr4tqVILMjySiQyZ1v+/f1xyygQtq5XifpOe8dy7DmI0MFhpxHCof3fbriOBBMm6qIANYU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM6PR15MB2393;7:U9TQyDWpzFZWkTbb45E6vYW0w0tC4UEgMu3nXX82jo/RoCrLXdJIMP7+2xM8yYuClGRSHch6wNnN5gXdMWBstON8tZcMH6YtPckgRJS5edP/5f9NLEsGJDgrtdpwky2p7jaZx481zYpsBN4cdHcfM17qlXmxhcTC/MvEkDXoTxqiVctZJ6a3DEcHsEvk0pVJP6BxrU502aqG5TDd+6XF/jlD0aiTxSPQKtTggHOBBONYQVE/YoGY+fNgqR3gSB3t X-MS-Office365-Filtering-Correlation-Id: 9e2fa982-5c4f-4736-611d-08d5bd02d0fd X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2018 21:03:33.3206 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9e2fa982-5c4f-4736-611d-08d5bd02d0fd X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR15MB2393 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-05/txt/msg00423.txt.bz2 On 2018-05-16 10:18 AM, Pedro Alves wrote: > Currently, we associate gdbarch-related remote protocol state on a > per-gdbarch data object. Things like the size of the g/G packet, and > the max remote packet size. If we'll support being connected to > different remote servers at the same time, then we need to cope with > each having their own packet sizes, even if they are each debugging > programs of the same architecture. I.e., a single instance of > remote_arch_state per arch is not sufficient. > > This patch moves the remote_arch_state object to a map of > gdbarch-to-remote_arch_state saved in the remote_state structure. > Usually there will only be one entry in the map, though we may see > more with stubs that support multi-process and/or archs with multiple > ABIs (e.g, one remote_arch_state for 64-bit inferiors and another for > 32-bit inferiors). LGTM. Simon